Conversation
Collaborator
|
Unfortunately, the rebase to |
drreynolds
force-pushed
the
feature/arkode-sts
branch
from
12940d0 to
62bccbd
Compare
Member
Yeah, I think in the future we should not rebase develop on main (if main is updated directly) and instead do a merge. I don't see a real advantage to having the same linear history for main and develop, and it seems the rebase has a pretty big downside. |
Collaborator
Indeed. Although rebasing might be no big deal for branches with 1-2 commits, it is a huge waste of time for a branch with any appreciable amount of development. |
drreynolds
reviewed
Jul 17, 2024
drreynolds
reviewed
Jul 17, 2024
drreynolds
reviewed
Jul 17, 2024
drreynolds
reviewed
Jul 17, 2024
drreynolds
reviewed
Jul 17, 2024
drreynolds
reviewed
Jul 17, 2024
drreynolds
reviewed
Jul 17, 2024
drreynolds
reviewed
Jul 17, 2024
drreynolds
reviewed
Jul 17, 2024
Collaborator
drreynolds
left a comment
drreynolds
left a comment
There was a problem hiding this comment.
I still need to look at the changes in src/arkode, but I wanted to share my comments so far.
drreynolds
reviewed
Jul 18, 2024
Collaborator
drreynolds
left a comment
drreynolds
left a comment
There was a problem hiding this comment.
One more set of comments, covering the rest of this draft PR.
maggul
requested review from
balos1,
cswoodward and
gardner48
as code owners
drreynolds
requested changes
Sep 11, 2024
Collaborator
drreynolds
left a comment
drreynolds
left a comment
There was a problem hiding this comment.
I've finished reviewing the documentation updates. I'll review the code soon.
drreynolds
requested changes
Sep 11, 2024
Co-authored-by: Daniel R. Reynolds <reynolds@smu.edu>
Co-authored-by: Daniel R. Reynolds <reynolds@smu.edu>
Co-authored-by: Daniel R. Reynolds <reynolds@smu.edu>
Co-authored-by: Daniel R. Reynolds <reynolds@smu.edu>
Co-authored-by: Daniel R. Reynolds <reynolds@smu.edu>
gardner48
reviewed
Nov 15, 2024
gardner48
requested changes
Nov 15, 2024
drreynolds
reviewed
Nov 15, 2024
Collaborator
drreynolds
left a comment
drreynolds
left a comment
There was a problem hiding this comment.
One minor item (I'll commit it myself in a moment).
Broke long comment into multiple lines.
drreynolds
previously approved these changes
Nov 15, 2024
drreynolds
previously approved these changes
Nov 15, 2024
gardner48
requested changes
Nov 15, 2024
gardner48
reviewed
Nov 15, 2024
Member
gardner48
left a comment
gardner48
left a comment
There was a problem hiding this comment.
This looks good. Once the CI passes I'll merge sundials-codes/answers#39 and update the submodule here.
gardner48
pushed a commit
to sundials-codes/answers
that referenced
this pull request
Nov 15, 2024
Output files for LSRKStep, see llnl/sundials#541
gardner48
approved these changes
Nov 15, 2024
gardner48
added a commit
that referenced
this pull request
Jul 21, 2025
Add LSRKStep module to ARKODE with RKC, RKL, and SSPs methods. --------- Co-authored-by: Daniel R. Reynolds <reynolds@smu.edu> Co-authored-by: David Gardner <gardner48@llnl.gov>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a draft PR for feedback on new STS module.