From 86f1b24ff50d09f6e1b437aad83a4a41d9cbcf01 Mon Sep 17 00:00:00 2001
From: Adam Rauch <adam@labkey.com>
Date: Fri, 15 Mar 2024 15:18:59 -0700
Subject: [PATCH] Eliminate javascript:void(0) and unchecked. Document
 mysterious handler attachment.

---
 mGAP/resources/views/login.html | 5 +++--
 mcc/resources/views/login.html  | 5 +++--
 2 files changed, 6 insertions(+), 4 deletions(-)

diff --git a/mGAP/resources/views/login.html b/mGAP/resources/views/login.html
index 02d26ad79..9dd9f23ca 100644
--- a/mGAP/resources/views/login.html
+++ b/mGAP/resources/views/login.html
@@ -13,7 +13,7 @@
     }(jQuery, LABKEY));
 
 </script>
-<form class="auth-form" name="login" action="javascript:void(0)" method="post">
+<form class="auth-form" name="login" method="post">
     <div class="auth-header">Sign In</div>
     <div class="labkey-error" id="errors"></div>
     <div class="auth-form-body">
@@ -28,12 +28,13 @@
             <div class="auth-header auth-item">Terms of Use</div>
             <div class="toucontent auth-item termsOfUseContent"></div>
             <div class="auth-item">
-                <input type="checkbox" tabindex="4" name="approvedTermsOfUse" id="approvedTermsOfUse" class="auth-item" unchecked>
+                <input type="checkbox" tabindex="4" name="approvedTermsOfUse" id="approvedTermsOfUse" class="auth-item">
                 <label for="approvedTermsOfUse">I agree to these terms</label>
             </div>
         </div>
         <input type="hidden" name="termsOfUseType" id="termsOfUseType">
         <div class="auth-item auth-credentials-submit">
+            <!-- Note: login.js attaches an authenticateUser() click event to elements with class "loginSubmitButton" -->
             <input type="submit" tabindex="-1" class="loginSubmitButton"/>
             <a tabindex="5" class="labkey-button primary signin-btn"><span>Sign In</span></a>
             <span class="registrationSection">
diff --git a/mcc/resources/views/login.html b/mcc/resources/views/login.html
index fd2c5a527..cd62ac66f 100644
--- a/mcc/resources/views/login.html
+++ b/mcc/resources/views/login.html
@@ -1,7 +1,7 @@
 <script type="text/javascript" nonce="<%=scriptNonce%>">
 
 </script>
-<form class="auth-form" name="login" action="javascript:void(0)" method="post">
+<form class="auth-form" name="login" method="post">
     <div class="auth-header">Sign In</div>
     <div class="labkey-error" id="errors"></div>
     <div class="auth-form-body">
@@ -16,12 +16,13 @@
             <div class="auth-header auth-item">Terms of Use</div>
             <div class="toucontent auth-item termsOfUseContent"></div>
             <div class="auth-item">
-                <input type="checkbox" tabindex="4" name="approvedTermsOfUse" id="approvedTermsOfUse" class="auth-item" unchecked>
+                <input type="checkbox" tabindex="4" name="approvedTermsOfUse" id="approvedTermsOfUse" class="auth-item">
                 <label for="approvedTermsOfUse">I agree to these terms</label>
             </div>
         </div>
         <input type="hidden" name="termsOfUseType" id="termsOfUseType">
         <div class="auth-item auth-credentials-submit">
+            <!-- Note: login.js attaches an authenticateUser() click event to elements with class "loginSubmitButton" -->
             <input type="submit" tabindex="-1" class="loginSubmitButton"/>
             <a tabindex="5" class="labkey-button primary signin-btn"><span>Sign In</span></a>
             <span class="registrationSection">