diff --git a/flow/src/org/labkey/flow/controllers/ReportsController.java b/flow/src/org/labkey/flow/controllers/ReportsController.java index 8b2fb53384..3f918c443f 100644 --- a/flow/src/org/labkey/flow/controllers/ReportsController.java +++ b/flow/src/org/labkey/flow/controllers/ReportsController.java @@ -303,7 +303,7 @@ public ActionURL getSuccessURL(CopyForm idForm) { ActionURL url = new ActionURL(UpdateAction.class, getContainer()).addParameter("reportId", r.getReportId().toString()); if (idForm.getReturnActionURL() != null) - url.addReturnURL(idForm.getReturnActionURL()); + url.addReturnUrl(idForm.getReturnActionURL()); return url; } @@ -346,7 +346,7 @@ public void validateCommand(IdForm idForm, Errors errors) @Override public URLHelper getCancelUrl() { - return _form.getReturnURLHelper(new ActionURL(BeginAction.class, getContainer())); + return _form.getReturnUrlHelper(new ActionURL(BeginAction.class, getContainer())); } @Override diff --git a/flow/src/org/labkey/flow/controllers/attribute/createAlias.jsp b/flow/src/org/labkey/flow/controllers/attribute/createAlias.jsp index 21ae1f2051..397c8ec63b 100644 --- a/flow/src/org/labkey/flow/controllers/attribute/createAlias.jsp +++ b/flow/src/org/labkey/flow/controllers/attribute/createAlias.jsp @@ -26,7 +26,7 @@ AttributeCache.Entry entry = form.getEntry(getContainer()); ActionURL editURL = getActionURL(); - ActionURL returnURL = form.getReturnActionURL(new ActionURL(ProtocolController.BeginAction.class, getContainer())); + ActionURL returnUrl = form.getReturnActionURL(new ActionURL(ProtocolController.BeginAction.class, getContainer())); %> Create alias for <%=h(entry.getType().name())%>: <%=h(entry.getName())%> @@ -49,7 +49,7 @@ Create alias for <%=h(entry.getType().name())%>: <%=h(entry.getName())%>   <%= button("Submit").submit(true) %> - <%= button("Cancel").href(returnURL) %> + <%= button("Cancel").href(returnUrl) %> diff --git a/flow/src/org/labkey/flow/controllers/attribute/edit.jsp b/flow/src/org/labkey/flow/controllers/attribute/edit.jsp index 6e7fd62b09..ef1b16bc35 100644 --- a/flow/src/org/labkey/flow/controllers/attribute/edit.jsp +++ b/flow/src/org/labkey/flow/controllers/attribute/edit.jsp @@ -29,15 +29,15 @@ if (StringUtils.isEmpty(name)) name = entry.getName(); - ActionURL editURL = getActionURL(); - ActionURL returnURL = form.getReturnActionURL(new ActionURL(ProtocolController.BeginAction.class, getContainer())); + ActionURL editUrl = getActionURL(); + ActionURL returnUrl = form.getReturnActionURL(new ActionURL(ProtocolController.BeginAction.class, getContainer())); %> Change the name of the <%=h(entry.getType().name())%> or clear the name to delete it.
- +
@@ -51,7 +51,7 @@ Change the name of the <%=h(entry.getType().name())%> or clear the name to delet   <%= button("Submit").submit(true) %> - <%= button("Cancel").href(returnURL) %> + <%= button("Cancel").href(returnUrl) %>
diff --git a/flow/src/org/labkey/flow/controllers/attribute/summary.jsp b/flow/src/org/labkey/flow/controllers/attribute/summary.jsp index 8e61b581d2..0341d26318 100644 --- a/flow/src/org/labkey/flow/controllers/attribute/summary.jsp +++ b/flow/src/org/labkey/flow/controllers/attribute/summary.jsp @@ -31,9 +31,9 @@ Map> aliasMap = FlowManager.get().getAliases(getContainer(), type); ActionURL summaryURL = getActionURL(); - ActionURL editURL = new ActionURL(AttributeController.EditAction.class, getContainer()).addParameter(AttributeController.Param.type, type.name()).addReturnURL(summaryURL); - ActionURL detailsURL = new ActionURL(AttributeController.DetailsAction.class, getContainer()).addParameter(AttributeController.Param.type, type.name()).addReturnURL(summaryURL); - ActionURL aliasURL = new ActionURL(AttributeController.CreateAliasAction.class, getContainer()).addParameter(AttributeController.Param.type, type.name()).addReturnURL(summaryURL); + ActionURL editURL = new ActionURL(AttributeController.EditAction.class, getContainer()).addParameter(AttributeController.Param.type, type.name()).addReturnUrl(summaryURL); + ActionURL detailsURL = new ActionURL(AttributeController.DetailsAction.class, getContainer()).addParameter(AttributeController.Param.type, type.name()).addReturnUrl(summaryURL); + ActionURL aliasURL = new ActionURL(AttributeController.CreateAliasAction.class, getContainer()).addParameter(AttributeController.Param.type, type.name()).addReturnUrl(summaryURL); %> diff --git a/flow/src/org/labkey/flow/controllers/copyReport.jsp b/flow/src/org/labkey/flow/controllers/copyReport.jsp index 891ab720a1..82db9a3deb 100644 --- a/flow/src/org/labkey/flow/controllers/copyReport.jsp +++ b/flow/src/org/labkey/flow/controllers/copyReport.jsp @@ -32,7 +32,7 @@ ActionURL copyURL = new ActionURL(ReportsController.CopyAction.class, c).addParameter("reportId", report.getReportId().toString()); if (form.getReturnUrl() != null) - copyURL.addReturnURL(form.getReturnActionURL()); + copyURL.addReturnUrl(form.getReturnActionURL()); %> diff --git a/flow/src/org/labkey/flow/controllers/executescript/AnalysisScriptController.java b/flow/src/org/labkey/flow/controllers/executescript/AnalysisScriptController.java index 24c482ed28..6b7366df1b 100644 --- a/flow/src/org/labkey/flow/controllers/executescript/AnalysisScriptController.java +++ b/flow/src/org/labkey/flow/controllers/executescript/AnalysisScriptController.java @@ -377,7 +377,7 @@ protected ModelAndView uploadRuns(ImportRunsForm form, BindException errors) thr { if (!form.isConfirm()) { - URLHelper url = form.getReturnURLHelper(); + URLHelper url = form.getReturnUrlHelper(); if (url == null) url = new ActionURL(BeginAction.class, getContainer()); return HttpView.redirect(url); diff --git a/flow/src/org/labkey/flow/controllers/executescript/confirmRunsToImport.jsp b/flow/src/org/labkey/flow/controllers/executescript/confirmRunsToImport.jsp index 5aeae1063c..ac63b18561 100644 --- a/flow/src/org/labkey/flow/controllers/executescript/confirmRunsToImport.jsp +++ b/flow/src/org/labkey/flow/controllers/executescript/confirmRunsToImport.jsp @@ -95,12 +95,12 @@
<%=button("Import Selected Runs").submit(true)%> - + <% } else { - %><% + %><% } %> diff --git a/flow/src/org/labkey/flow/controllers/protocol/editICSMetadata.jsp b/flow/src/org/labkey/flow/controllers/protocol/editICSMetadata.jsp index 6f8cf63307..875609724a 100644 --- a/flow/src/org/labkey/flow/controllers/protocol/editICSMetadata.jsp +++ b/flow/src/org/labkey/flow/controllers/protocol/editICSMetadata.jsp @@ -58,7 +58,7 @@ ActionURL submitURL = form.getProtocol().urlFor(ProtocolController.EditICSMetadataAction.class); if (form.getReturnActionURL() != null) - submitURL.addReturnURL(form.getReturnActionURL()); + submitURL.addReturnUrl(form.getReturnActionURL()); %> diff --git a/flow/src/org/labkey/flow/controllers/protocol/showProtocol.jsp b/flow/src/org/labkey/flow/controllers/protocol/showProtocol.jsp index ecfa34b4bd..ba2fc02aa0 100644 --- a/flow/src/org/labkey/flow/controllers/protocol/showProtocol.jsp +++ b/flow/src/org/labkey/flow/controllers/protocol/showProtocol.jsp @@ -63,8 +63,8 @@

Manage Names and Aliases
Create and remove names and aliases for Keywords, Statistics, and Graphs.
- <%=link("Case sensitivity").href(protocol.urlFor(AttributeController.CaseSensitivityAction.class).addReturnURL(getActionURL()))%>
- <%=link("Delete Unused").href(protocol.urlFor(AttributeController.DeleteUnusedAction.class).addReturnURL(getActionURL()))%>
+ <%=link("Case sensitivity").href(protocol.urlFor(AttributeController.CaseSensitivityAction.class).addReturnUrl(getActionURL()))%>
+ <%=link("Delete Unused").href(protocol.urlFor(AttributeController.DeleteUnusedAction.class).addReturnUrl(getActionURL()))%>
<%=link("Manage Keywords").href(protocol.urlFor(AttributeController.SummaryAction.class).addParameter(AttributeController.Param.type, AttributeType.keyword.name()))%>
<%=link("Manage Statistics").href(protocol.urlFor(AttributeController.SummaryAction.class).addParameter(AttributeController.Param.type, AttributeType.statistic.name()))%>
<%=link("Manage Graphs").href(protocol.urlFor(AttributeController.SummaryAction.class).addParameter(AttributeController.Param.type, AttributeType.graph.name()))%>
diff --git a/flow/src/org/labkey/flow/controllers/reports.jsp b/flow/src/org/labkey/flow/controllers/reports.jsp index 2f121ce81d..ae4db64b9f 100644 --- a/flow/src/org/labkey/flow/controllers/reports.jsp +++ b/flow/src/org/labkey/flow/controllers/reports.jsp @@ -42,8 +42,8 @@ boolean canEdit = c.hasPermission(user, UpdatePermission.class); ActionURL currentURL = getActionURL(); - ActionURL copyURL = new ActionURL(ReportsController.CopyAction.class, c).addReturnURL(currentURL); - ActionURL deleteURL = new ActionURL(ReportsController.DeleteAction.class, c).addReturnURL(currentURL); + ActionURL copyURL = new ActionURL(ReportsController.CopyAction.class, c).addReturnUrl(currentURL); + ActionURL deleteURL = new ActionURL(ReportsController.DeleteAction.class, c).addReturnUrl(currentURL); Collection reports = FlowReportManager.getFlowReports(c, user); Map> reportsByType = new TreeMap<>(); @@ -96,7 +96,7 @@ table.reports td { navtree.addChild("Edit", editURL); navtree.addChild("Copy", copyURL); navtree.addChild("Delete", deleteURL); - navtree.addChild("Execute", r.getRunReportURL(context).addParameter("confirm", true).addReturnURL(currentURL)); + navtree.addChild("Execute", r.getRunReportURL(context).addParameter("confirm", true).addReturnUrl(currentURL)); PopupMenu menu = new PopupMenu(navtree, PopupMenu.Align.LEFT, PopupMenu.ButtonStyle.TEXT); %>

<%}%> diff --git a/flow/src/org/labkey/flow/reports/ControlsQCReport.java b/flow/src/org/labkey/flow/reports/ControlsQCReport.java index 312ec458c9..221c180317 100644 --- a/flow/src/org/labkey/flow/reports/ControlsQCReport.java +++ b/flow/src/org/labkey/flow/reports/ControlsQCReport.java @@ -41,11 +41,11 @@ public class ControlsQCReport extends FilterFlowReport public static String DESC = "Flow Controls Statistics over Time"; public static final String STATISTIC_PROP = "statistic"; - public static ActionURL createURL(Container c, @Nullable ActionURL returnURL, @Nullable ActionURL cancelURL) + public static ActionURL createURL(Container c, @Nullable ActionURL returnUrl, @Nullable ActionURL cancelURL) { ActionURL url = new ActionURL(ReportsController.CreateAction.class, c).addParameter(ReportDescriptor.Prop.reportType, TYPE); - if (returnURL != null) - url.addReturnURL(returnURL); + if (returnUrl != null) + url.addReturnUrl(returnUrl); if (cancelURL != null) url.addCancelURL(cancelURL); return url; @@ -70,9 +70,9 @@ String getScriptResource() throws IOException } @Override - public HttpView getConfigureForm(ViewContext context, ActionURL returnURL, ActionURL cancelURL) + public HttpView getConfigureForm(ViewContext context, ActionURL returnUrl, ActionURL cancelUrl) { - return new JspView<>("/org/labkey/flow/reports/editQCReport.jsp", Tuple3.of(this, returnURL, cancelURL)); + return new JspView<>("/org/labkey/flow/reports/editQCReport.jsp", Tuple3.of(this, returnUrl, cancelUrl)); } @Override diff --git a/flow/src/org/labkey/flow/reports/FlowReport.java b/flow/src/org/labkey/flow/reports/FlowReport.java index c6e2718aa6..c13f627903 100644 --- a/flow/src/org/labkey/flow/reports/FlowReport.java +++ b/flow/src/org/labkey/flow/reports/FlowReport.java @@ -153,7 +153,7 @@ String getScriptResource(String file) throws IOException } } - public abstract HttpView getConfigureForm(ViewContext context, ActionURL returnURL, ActionURL cancelURL); + public abstract HttpView getConfigureForm(ViewContext context, ActionURL returnUrl, ActionURL cancelUrl); /** override=true means only set parameters overrideable via the URL on execute */ public abstract boolean updateProperties(ContainerUser cu, PropertyValues pvs, BindException errors, boolean override); diff --git a/flow/src/org/labkey/flow/reports/PositivityFlowReport.java b/flow/src/org/labkey/flow/reports/PositivityFlowReport.java index 8db561f358..22176a84ed 100644 --- a/flow/src/org/labkey/flow/reports/PositivityFlowReport.java +++ b/flow/src/org/labkey/flow/reports/PositivityFlowReport.java @@ -59,13 +59,13 @@ public class PositivityFlowReport extends FilterFlowReport public static final String DESC = "Flow Positivity Call"; public static final String SUBSET_PROP = "subset"; - public static ActionURL createURL(Container c, @Nullable ActionURL returnURL, @Nullable ActionURL cancelURL) + public static ActionURL createURL(Container c, @Nullable ActionURL returnUrl, @Nullable ActionURL cancelUrl) { ActionURL url = new ActionURL(ReportsController.CreateAction.class, c).addParameter(ReportDescriptor.Prop.reportType, TYPE); - if (returnURL != null) - url.addReturnURL(returnURL); - if (cancelURL != null) - url.addCancelURL(cancelURL); + if (returnUrl != null) + url.addReturnUrl(returnUrl); + if (cancelUrl != null) + url.addCancelURL(cancelUrl); return url; } @@ -91,9 +91,9 @@ String getScriptResource() throws IOException } @Override - public HttpView getConfigureForm(ViewContext context, ActionURL returnURL, ActionURL cancelURL) + public HttpView getConfigureForm(ViewContext context, ActionURL returnUrl, ActionURL cancelUrl) { - return new JspView<>("/org/labkey/flow/reports/editPositivityReport.jsp", Tuple3.of(this, returnURL, cancelURL)); + return new JspView<>("/org/labkey/flow/reports/editPositivityReport.jsp", Tuple3.of(this, returnUrl, cancelUrl)); } SubsetSpec getSubset() @@ -174,7 +174,7 @@ public HttpView renderReport(ViewContext context) throws Exception FlowProtocol protocol = FlowProtocol.getForContainer(context.getContainer()); ActionURL currentURL = context.getActionURL(); ActionURL editICSMetadataURL = protocol.urlFor(ProtocolController.EditICSMetadataAction.class); - editICSMetadataURL.addReturnURL(currentURL); + editICSMetadataURL.addReturnUrl(currentURL); return HtmlView.unsafe( "

Positivity report requires configuring flow experiment metadata for study and background information before running.

" + diff --git a/flow/src/org/labkey/flow/reports/editPositivityReport.jsp b/flow/src/org/labkey/flow/reports/editPositivityReport.jsp index 410aa65ded..f5ce93d709 100644 --- a/flow/src/org/labkey/flow/reports/editPositivityReport.jsp +++ b/flow/src/org/labkey/flow/reports/editPositivityReport.jsp @@ -45,13 +45,13 @@ Tuple3 bean = (Tuple3) HttpView.currentModel(); PositivityFlowReport report = bean.first; - ActionURL returnURL = bean.second; - ActionURL cancelURL = bean.third; + ActionURL returnUrl = bean.second; + ActionURL cancelUrl = bean.third; ReportDescriptor d = report.getDescriptor(); String reportId = d.getReportId() == null ? null : d.getReportId().toString(); - ActionURL retURL = returnURL == null ? urlFor(BeginAction.class) : returnURL; - ActionURL canURL = cancelURL == null ? retURL : cancelURL; + ActionURL retURL = returnUrl == null ? urlFor(BeginAction.class) : returnUrl; + ActionURL canURL = cancelUrl == null ? retURL : cancelUrl; FlowProtocol protocol = FlowProtocol.getForContainer(c); ICSMetadata metadata = protocol == null ? null : protocol.getICSMetadata(); @@ -61,7 +61,7 @@ if (protocol != null) { editICSMetadataURL = protocol.urlFor(EditICSMetadataAction.class); - editICSMetadataURL.addReturnURL(currentURL); + editICSMetadataURL.addReturnUrl(currentURL); } %> @@ -142,12 +142,12 @@ function Form_onDelete() if (d.getReportId() != null) { url = urlFor(DeleteAction.class).addParameter("reportId", report.getReportId().toString()); - if (returnURL != null) - url.addReturnURL(returnURL); + if (returnUrl != null) + url.addReturnUrl(returnUrl); } - else if (returnURL != null) + else if (returnUrl != null) { - url = returnURL; + url = returnUrl; } else { diff --git a/flow/src/org/labkey/flow/reports/editQCReport.jsp b/flow/src/org/labkey/flow/reports/editQCReport.jsp index 5fa626c6b8..8b69802459 100644 --- a/flow/src/org/labkey/flow/reports/editQCReport.jsp +++ b/flow/src/org/labkey/flow/reports/editQCReport.jsp @@ -37,13 +37,13 @@ <% Tuple3 bean = (Tuple3) HttpView.currentModel(); FilterFlowReport report = bean.first; - ActionURL returnURL = bean.second; - ActionURL cancelURL = bean.third; + ActionURL returnUrl = bean.second; + ActionURL cancelUrl = bean.third; ReportDescriptor d = report.getDescriptor(); String reportId = d.getReportId() == null ? null : d.getReportId().toString(); - ActionURL retURL = returnURL == null ? urlFor(BeginAction.class) : returnURL; - ActionURL canURL = cancelURL == null ? retURL : cancelURL; + ActionURL retURL = returnUrl == null ? urlFor(BeginAction.class) : returnUrl; + ActionURL canURL = cancelUrl == null ? retURL : cancelUrl; %>
<% menu.render(out); %>