From 2f4ca1596cbe810a5f983ad1bfa7d9713b750f4e Mon Sep 17 00:00:00 2001 From: ankurjuneja Date: Wed, 6 Apr 2022 10:01:52 -0700 Subject: [PATCH 1/2] Throw exception when lsid is not found in table selector list --- api/src/org/labkey/api/query/DefaultQueryUpdateService.java | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/api/src/org/labkey/api/query/DefaultQueryUpdateService.java b/api/src/org/labkey/api/query/DefaultQueryUpdateService.java index 5f2b431de0c..2fbe1950e67 100644 --- a/api/src/org/labkey/api/query/DefaultQueryUpdateService.java +++ b/api/src/org/labkey/api/query/DefaultQueryUpdateService.java @@ -50,6 +50,7 @@ import org.labkey.api.security.permissions.Permission; import org.labkey.api.security.permissions.UpdatePermission; import org.labkey.api.util.Pair; +import org.labkey.api.view.NotFoundException; import org.labkey.api.view.UnauthorizedException; import org.springframework.web.multipart.MultipartFile; @@ -254,6 +255,10 @@ protected Map _select(Container container, Object[] keys) throws } } } + else + { + throw new NotFoundException("LSID value not found in table - " + table.getName()); + } } return row; From 3120344b23e44f2552f1cc29e66c18e3eebb3ba7 Mon Sep 17 00:00:00 2001 From: ankurjuneja Date: Wed, 6 Apr 2022 10:30:13 -0700 Subject: [PATCH 2/2] cr feedback - change exception type --- api/src/org/labkey/api/query/DefaultQueryUpdateService.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/api/src/org/labkey/api/query/DefaultQueryUpdateService.java b/api/src/org/labkey/api/query/DefaultQueryUpdateService.java index 2fbe1950e67..04a036037e1 100644 --- a/api/src/org/labkey/api/query/DefaultQueryUpdateService.java +++ b/api/src/org/labkey/api/query/DefaultQueryUpdateService.java @@ -257,7 +257,7 @@ protected Map _select(Container container, Object[] keys) throws } else { - throw new NotFoundException("LSID value not found in table - " + table.getName()); + throw new IllegalStateException("LSID value not found in table - " + table.getName()); } }