diff --git a/api/src/org/labkey/api/data/AbstractFileDisplayColumn.java b/api/src/org/labkey/api/data/AbstractFileDisplayColumn.java index 088b506bef7..3d3ebac5e18 100644 --- a/api/src/org/labkey/api/data/AbstractFileDisplayColumn.java +++ b/api/src/org/labkey/api/data/AbstractFileDisplayColumn.java @@ -281,7 +281,7 @@ public void renderInputHtml(RenderContext ctx, HtmlWriter out, Object value) if (null != filename) { // Existing value, so tell the user the file name, allow the file to be removed, and a new file uploaded - renderThumbnailAndRemoveLink(out, ctx, filename, input.build().toString()); + renderThumbnailAndRemoveLink(out, ctx, filename, input); } else { @@ -302,8 +302,7 @@ protected String getRemovalWarningText(String filename) return "Previous file " + filename + " will be removed."; } - // TODO: filePicker should be a builder or HtmlString or something sensible like that - private void renderThumbnailAndRemoveLink(HtmlWriter out, RenderContext ctx, String filename, String filePicker) + private void renderThumbnailAndRemoveLink(HtmlWriter out, RenderContext ctx, String filename, InputBuilder filePicker) { String divId = GUID.makeGUID(); String linkId = "remove" + divId; diff --git a/api/src/org/labkey/api/data/JavaScriptDisplayColumn.java b/api/src/org/labkey/api/data/JavaScriptDisplayColumn.java index d3badf02866..92328f38fcc 100644 --- a/api/src/org/labkey/api/data/JavaScriptDisplayColumn.java +++ b/api/src/org/labkey/api/data/JavaScriptDisplayColumn.java @@ -64,7 +64,7 @@ public JavaScriptDisplayColumn(ColumnInfo col, @Nullable Collection depe } @Override - public void renderGridCellContents(RenderContext ctx, Writer oldWriter, HtmlWriter out) throws IOException + public void renderGridCellContents(RenderContext ctx, HtmlWriter out) { Object o = getValue(ctx); @@ -75,13 +75,13 @@ public void renderGridCellContents(RenderContext ctx, Writer oldWriter, HtmlWrit if (_onClickExpression != null) onClick = StringUtils.trim(_onClickExpression.eval(ctx)); - renderLink(oldWriter, getFormattedHtml(ctx), onClick, _linkClassName); + renderLink(out, getFormattedHtml(ctx), onClick, _linkClassName); } else - oldWriter.write(" "); + out.write(HtmlString.NBSP); } - protected void renderLink(Writer out, HtmlString html, @Nullable String onClick, @Nullable String linkClassName) + protected void renderLink(HtmlWriter out, HtmlString html, @Nullable String onClick, @Nullable String linkClassName) { LinkBuilder builder = new LinkBuilder(html) .href("#") diff --git a/api/src/org/labkey/api/view/PopupMenu.java b/api/src/org/labkey/api/view/PopupMenu.java index 3b002f35975..5efc1b69d6e 100644 --- a/api/src/org/labkey/api/view/PopupMenu.java +++ b/api/src/org/labkey/api/view/PopupMenu.java @@ -113,7 +113,12 @@ public void render(RenderContext ctx, Writer out) throws IOException public void render(Writer out) throws IOException { - renderMenuButton(null, HtmlWriter.of(out), false, null); + render(HtmlWriter.of(out)); + } + + public void render(HtmlWriter out) + { + renderMenuButton(null, out, false, null); } public void renderMenuButton(@Nullable RenderContext ctx, HtmlWriter out, boolean requiresSelection, @Nullable ActionButton button)