From 1c6d47e3973bd57438af3a04350f04a41059fa14 Mon Sep 17 00:00:00 2001 From: Binal Patel Date: Fri, 22 Apr 2022 00:42:44 -0700 Subject: [PATCH 1/2] Report error back to the user by throwing an exception --- .../labkey/wnprc_purchasing/WNPRC_PurchasingManager.java | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/WNPRC_Purchasing/src/org/labkey/wnprc_purchasing/WNPRC_PurchasingManager.java b/WNPRC_Purchasing/src/org/labkey/wnprc_purchasing/WNPRC_PurchasingManager.java index 4338d8df5..3b30bfef1 100644 --- a/WNPRC_Purchasing/src/org/labkey/wnprc_purchasing/WNPRC_PurchasingManager.java +++ b/WNPRC_Purchasing/src/org/labkey/wnprc_purchasing/WNPRC_PurchasingManager.java @@ -116,7 +116,7 @@ public void insertData(Container c, User user, TableInfo table, List submitRequestForm(User user, Container container, WNPRC_PurchasingController.RequestForm requestForm) + public List submitRequestForm(User user, Container container, WNPRC_PurchasingController.RequestForm requestForm) throws Exception { UserSchema us = QueryService.get().getUserSchema(user, container, "ehr_purchasing"); boolean isNewRequest = null == requestForm.getRowId(); @@ -333,10 +333,9 @@ else if (null != lineItem.get("quantityReceived")) } catch (Exception e) { - List rowErrors = new ArrayList<>(); - rowErrors.add(new ValidationException().addError(new SimpleValidationError(e.getMessage()))); - return rowErrors; + throw new Exception(e.getMessage(), e);// is there a less generic exception to use to capture exceptions from insertRows, updateRows, and deleteRows in addition to other exceptions (like IllegalStateException)? } + return validationErrors; } From 021c2cbe5aa577823857d645459d44676814cdd9 Mon Sep 17 00:00:00 2001 From: Binal Patel Date: Fri, 22 Apr 2022 15:18:34 -0700 Subject: [PATCH 2/2] Remove unneeded catch block --- .../org/labkey/wnprc_purchasing/WNPRC_PurchasingManager.java | 4 ---- 1 file changed, 4 deletions(-) diff --git a/WNPRC_Purchasing/src/org/labkey/wnprc_purchasing/WNPRC_PurchasingManager.java b/WNPRC_Purchasing/src/org/labkey/wnprc_purchasing/WNPRC_PurchasingManager.java index 3b30bfef1..81dcd9369 100644 --- a/WNPRC_Purchasing/src/org/labkey/wnprc_purchasing/WNPRC_PurchasingManager.java +++ b/WNPRC_Purchasing/src/org/labkey/wnprc_purchasing/WNPRC_PurchasingManager.java @@ -331,10 +331,6 @@ else if (null != lineItem.get("quantityReceived")) transaction.commit(); } - catch (Exception e) - { - throw new Exception(e.getMessage(), e);// is there a less generic exception to use to capture exceptions from insertRows, updateRows, and deleteRows in addition to other exceptions (like IllegalStateException)? - } return validationErrors; }