From 6d76d3abd45d344c631d08a92f0167c1b5084876 Mon Sep 17 00:00:00 2001 From: Cristian Magherusan-Stanciu Date: Mon, 27 Apr 2026 20:08:13 +0200 Subject: [PATCH] chore(settings): drop stale .account-overrides-panel cleanup selector MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit PR #124 (issue #122) moved per-account overrides into a modal and deleted the inline `.account-overrides-panel` element from the accounts table. The cleanup selector at renderAccountsList top still listed it, which is dead — no such element ever exists now. Drop the class from the querySelectorAll list and explain in the comment that overrides moved to the modal so a future reader doesn't restore the reference. No behaviour change. Tests + typecheck + build still green. --- frontend/src/settings.ts | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/frontend/src/settings.ts b/frontend/src/settings.ts index 140abf72..95318c6d 100644 --- a/frontend/src/settings.ts +++ b/frontend/src/settings.ts @@ -275,10 +275,13 @@ function renderAccountsList( provider: AccountProvider, filter: AccountStatusFilter = 'all' ): void { - // Remove prior rendered rows (Overrides panels are sibling elements, - // banner lives in a separate className managed by renderSelfAccountBanner). + // Remove prior rendered rows (banner lives in a separate className + // managed by renderSelfAccountBanner). `.account-overrides-panel` used + // to be cleaned up here too — it was the inline expandable panel each + // account carried before #122/#124 moved overrides into a per-account + // modal. No such elements exist anymore. container.querySelectorAll( - '.accounts-table, .account-overrides-panel, .accounts-empty, .status-chip-row' + '.accounts-table, .accounts-empty, .status-chip-row' ).forEach(el => el.remove()); if (!accounts || accounts.length === 0) {