From e0260d2ed8c46a62c33f06a26e1a5e7c8066bd8e Mon Sep 17 00:00:00 2001
From: Cristian Magherusan-Stanciu <cristi@leanercloud.com>
Date: Sat, 25 Apr 2026 00:06:50 +0200
Subject: [PATCH] fix(commitmentOptions): align savingsplans key with
 SERVICE_FIELDS/dropdown/DB
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

CodeRabbit flagged a key mismatch on PR #30: `SERVICE_FIELDS` in
`settings.ts` uses `service: 'savingsplans'`, while `commitmentConfigs`
in `commitmentOptions.ts` registered the AWS entry under `'savings-plans'`
(hyphenated). Any lookup via `isValidCombination`/`getCommitmentConfig`
with the non-hyphenated identifier silently fell through to `_default`
instead of hitting the Savings-Plans-specific config. Today both configs
are identical so behaviour is unchanged, but any future restriction
added to `'savings-plans'` would have been silently skipped.

CodeRabbit's suggestion was to rewrite `SERVICE_FIELDS` to the hyphenated
form, but `field.service` in `SERVICE_FIELDS` flows directly to
`api.updateServiceConfig(provider, service, cfg)` (settings.ts:1443)
which persists `service` as the primary key in the `service_configs`
table — existing production rows are `('aws', 'savingsplans')`, and
renaming SERVICE_FIELDS without a DB migration would have created
duplicate rows and orphaned the old config. The dropdown at
`index.html:112,703` (`<option value="savingsplans">`) and the backend
CLI flag (`cmd/main.go:92`) also use the non-hyphenated form.

Fix by renaming the `commitmentConfigs.aws` key from `'savings-plans'`
to `savingsplans` so every frontend call site — the SERVICE_FIELDS
path, the plan-form dropdown path, and any direct lookups — resolves
to the Savings-Plans-specific config. Update the two test cases in
`commitmentOptions.test.ts` to match.

This addresses the only live CodeRabbit finding across all open/closed
PRs (24-39, 52-54); PR #52's nitpicks were already resolved in db429fe,
and the remaining PR #30 nitpicks (double `Promise.resolve()` in
settings.test.ts:854, memorydb absent from SERVICE_FIELDS) apply only
to code that lives on PR #30's branch and not the base.
---
 frontend/src/__tests__/commitmentOptions.test.ts | 10 +++++-----
 frontend/src/commitmentOptions.ts                |  2 +-
 2 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/frontend/src/__tests__/commitmentOptions.test.ts b/frontend/src/__tests__/commitmentOptions.test.ts
index 0c97ad1b..762bc554 100644
--- a/frontend/src/__tests__/commitmentOptions.test.ts
+++ b/frontend/src/__tests__/commitmentOptions.test.ts
@@ -35,8 +35,8 @@ describe('commitmentOptions', () => {
         expect(config.invalidCombinations).toBeUndefined();
       });
 
-      it('should return savings-plans config with all options', () => {
-        const config = getCommitmentConfig('aws', 'savings-plans');
+      it('should return savingsplans config with all options', () => {
+        const config = getCommitmentConfig('aws', 'savingsplans');
 
         expect(config.terms).toHaveLength(2);
         expect(config.payments).toHaveLength(3);
@@ -198,9 +198,9 @@ describe('commitmentOptions', () => {
         expect(isValidCombination('aws', 'ec2', 3, 'all-upfront')).toBe(true);
       });
 
-      it('should return true for all savings-plans combinations', () => {
-        expect(isValidCombination('aws', 'savings-plans', 1, 'no-upfront')).toBe(true);
-        expect(isValidCombination('aws', 'savings-plans', 3, 'no-upfront')).toBe(true);
+      it('should return true for all savingsplans combinations', () => {
+        expect(isValidCombination('aws', 'savingsplans', 1, 'no-upfront')).toBe(true);
+        expect(isValidCombination('aws', 'savingsplans', 3, 'no-upfront')).toBe(true);
       });
     });
 
diff --git a/frontend/src/commitmentOptions.ts b/frontend/src/commitmentOptions.ts
index d78c500d..98e7b720 100644
--- a/frontend/src/commitmentOptions.ts
+++ b/frontend/src/commitmentOptions.ts
@@ -55,7 +55,7 @@ const commitmentConfigs: Record<string, Record<string, CommitmentConfig>> = {
       payments: AWS_PAYMENTS
     },
     // Savings Plans - all options available
-    'savings-plans': {
+    savingsplans: {
       terms: STANDARD_TERMS,
       payments: AWS_PAYMENTS
     },