Typographic corrections and clarifications#1106
Open
jrpool wants to merge 12 commits intoLearnersGuild:masterfrom
Open
Typographic corrections and clarifications#1106jrpool wants to merge 12 commits intoLearnersGuild:masterfrom
jrpool wants to merge 12 commits intoLearnersGuild:masterfrom
Conversation
2 more advanced members of P4 say that this line is not needed. If it is needed, it needs a clear specification for the token that is to be used in place of the placeholder. For now, I am proposing its deletion.
The need to still have RethinkDB running since the IDM installation, or to start it again, was not obvious. State instruction was ambiguous.
To avoid API errors in the execution of “npm run workers”, one would already need the 2 Slack-related entries in the .env.development file that were shown later on the page. This would require getting invited by a teammate to the Slack dev team. But current P4 members are not aware of such a team, are not members of it, and cannot give invitations. Therefore it is appropriate to warn about the error message and delete the entirety of the section on Slack integration.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #<GITHUB_ISSUE_NUMBER>.
Overview
(quick description of solution to original issue)
Data Model / DB Schema Changes
(if there were data changes, explain them)
(also note whether it is necessary to run any database migrations)
Environment / Configuration Changes
(any updated third-party libraries / packages?)
(any updates to the configuration files?)
Notes
(heads up on anything not super intuitive or obvious)