From 341cea28d9276dd883a3f163131338dac156c2cc Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Mustafa=20=C3=96NCEL?= Date: Wed, 17 Feb 2021 19:18:32 +0300 Subject: [PATCH] Use hash set instead of array list for performance We only use the contains and add methods, and do not add duplicate entries, and we use String, each String should have unique hash code. So, by using HashSet instead of ArrayList, we can gain a performance improvement somewhere between %5 to %10. --- .../bytecodeversionanalyzer/BytecodeVersionAnalyzer.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/main/java/com/lifemcserver/bytecodeversionanalyzer/BytecodeVersionAnalyzer.java b/src/main/java/com/lifemcserver/bytecodeversionanalyzer/BytecodeVersionAnalyzer.java index c3b4756..3d1f02a 100644 --- a/src/main/java/com/lifemcserver/bytecodeversionanalyzer/BytecodeVersionAnalyzer.java +++ b/src/main/java/com/lifemcserver/bytecodeversionanalyzer/BytecodeVersionAnalyzer.java @@ -964,7 +964,7 @@ public final void uncaughtException(final Thread t, final Throwable e) { */ private static final class JarEntryVersionConsumer implements Consumer { private final Map classes = new HashMap<>(); - private final List entries = new ArrayList<>(); + private final Set entries = new HashSet<>(); private final JarFile jar;