From cf09f89e81a5863b19ccebe9157fa949d8ddef5a Mon Sep 17 00:00:00 2001
From: Martin Marmsoler <martin.marmsoler@gmail.com>
Date: Fri, 20 Jan 2023 17:18:17 +0100
Subject: [PATCH] Big Endian is zero not 1

---
 src/dbc.cpp       |  2 +-
 test/test_dbc.cpp | 31 ++++++++++++++++++++++++++++++-
 2 files changed, 31 insertions(+), 2 deletions(-)

diff --git a/src/dbc.cpp b/src/dbc.cpp
index bb21845..905f237 100644
--- a/src/dbc.cpp
+++ b/src/dbc.cpp
@@ -147,7 +147,7 @@ namespace libdbc {
 				bool is_multiplexed = false; // No support yet
 				uint32_t start_bit = std::stoul(match.str(3));
 				uint32_t size = std::stoul(match.str(4));
-				bool is_bigendian = (std::stoul(match.str(5)) == 1);
+				bool is_bigendian = (std::stoul(match.str(5)) == 0);
 				bool is_signed = (match.str(6) == "-");
 				// Alternate groups because a group is for the decimal portion
 				double factor = std::stod(match.str(7));
diff --git a/test/test_dbc.cpp b/test/test_dbc.cpp
index f69edb7..04dddb2 100644
--- a/test/test_dbc.cpp
+++ b/test/test_dbc.cpp
@@ -53,7 +53,7 @@ TEST_CASE("Testing dbc file loading", "[fileio]") {
 		libdbc::Message msg(500, "IO_DEBUG", 4, "IO");
 
 		std::vector<std::string> receivers{"DBG"};
-		libdbc::Signal sig("IO_DEBUG_test_unsigned", false, 0, 8, true, false, 1, 0, 0, 0, "", receivers);
+		libdbc::Signal sig("IO_DEBUG_test_unsigned", false, 0, 8, false, false, 1, 0, 0, 0, "", receivers);
  		msg.signals.push_back(sig);
 
 		std::vector<libdbc::Message> msgs = {msg};
@@ -71,6 +71,35 @@ TEST_CASE("Testing dbc file loading", "[fileio]") {
 
 }
 
+TEST_CASE("Testing  big endian, little endian") {
+  const auto* filename = std::tmpnam(NULL);
+
+  auto* file = std::fopen(filename, "w");
+  CHECK(file);
+
+  std::fputs(PRIMITIVE_DBC.c_str(), file);
+  // first big endian
+  // second little endian
+  std::fputs(R"(BO_ 234 MSG1: 8 Vector__XXX
+ SG_ Sig1 : 55|16@0- (0.1,0) [-3276.8|-3276.7] "C" Vector__XXX
+ SG_ Sig2 : 39|16@1- (0.1,0) [-3276.8|-3276.7] "C" Vector__XXX)", file);
+  std::fclose(file);
+
+  auto parser = libdbc::DbcParser();
+  parser.parse_file(filename);
+
+  REQUIRE(parser.get_messages().size() == 1);
+  REQUIRE(parser.get_messages().at(0).signals.size() == 2);
+  {
+    const auto signal = parser.get_messages().at(0).signals.at(0);
+    REQUIRE(signal.is_bigendian == true);
+  }
+  {
+    const auto signal = parser.get_messages().at(0).signals.at(1);
+    REQUIRE(signal.is_bigendian == false);
+  }
+}
+
 TEST_CASE("Testing negative values") {
   const auto* filename = std::tmpnam(NULL);