Use signed int32

Author: brad-richardson

src/confighttp.cpp

@@ -311,9 +311,8 @@ void saveApp(resp_https_t response, req_https_t request) {
     pt::read_json(config::stream.file_apps, fileTree);
 
     // Moonlight checks the id of an item to determine if an item was changed
-    // Add a property named "id" to the inputTree with a random id (min of 1 as "0" indicates no app running)
-    // Fixed to 32-bit integer because some Moonlight clients cannot accept more than that
-    inputTree.put("id", util::generate_uint32(1, std::numeric_limits<std::uint32_t>::max()));
+    // Needs to be 32-bit positive, signed integer due to client limitations (min of 1 as "0" indicates no app running)
+    inputTree.put("id", util::generate_int32(1, std::numeric_limits<std::int32_t>::max()));
 
     if(inputTree.get_child("prep-cmd").empty()) {
       inputTree.erase("prep-cmd");

src/rand.h

@@ -5,18 +5,18 @@
 
 namespace util {
 
-static uint32_t generate_uint32(std::default_random_engine &engine, uint32_t min, uint32_t max) {
-  std::uniform_int_distribution<std::uint32_t> dist(min, max);
+static int32_t generate_int32(std::default_random_engine &engine, int32_t min, int32_t max) {
+  std::uniform_int_distribution<std::int32_t> dist(min, max);
 
   return dist(engine);
 }
 
-static uint32_t generate_uint32(uint32_t min, uint32_t max) {
+static int32_t generate_int32(int32_t min, int32_t max) {
   std::random_device r;
 
   std::default_random_engine engine { r() };
 
-  return util::generate_uint32(engine, min, max);
+  return util::generate_int32(engine, min, max);
 }
 
 } // namespace util