From 09ef8a1266a245038870f47d27ebbe47284029cb Mon Sep 17 00:00:00 2001 From: Cameron Gutman Date: Wed, 4 Jan 2023 00:15:27 -0600 Subject: [PATCH 1/8] Clarify that the min_threads value only affects software encoding --- docs/source/about/advanced_usage.rst | 2 +- src_assets/common/assets/web/config.html | 3 +-- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/docs/source/about/advanced_usage.rst b/docs/source/about/advanced_usage.rst index ab46db3a27f..ec8b5a41a7f 100644 --- a/docs/source/about/advanced_usage.rst +++ b/docs/source/about/advanced_usage.rst @@ -683,7 +683,7 @@ min_threads ^^^^^^^^^^^ **Description** - Minimum number of threads used by ffmpeg to encode the video. + Minimum number of threads used for software encoding. .. Note:: Increasing the value slightly reduces encoding efficiency, but the tradeoff is usually worth it to gain the use of more CPU cores for encoding. The ideal value is the lowest value that can reliably encode at your diff --git a/src_assets/common/assets/web/config.html b/src_assets/common/assets/web/config.html index 849ccac626a..3d852d2f31d 100644 --- a/src_assets/common/assets/web/config.html +++ b/src_assets/common/assets/web/config.html @@ -479,7 +479,7 @@

Configuration

Minimum Software Encoding Thread Count Configuration v-model="config.min_threads" />
- Minimum number of threads used by ffmpeg to encode the video.
Increasing the value slightly reduces encoding efficiency, but the tradeoff is usually
worth it to gain the use of more CPU cores for encoding. The ideal value is the lowest
value that can reliably encode at your desired streaming settings on your hardware. From 2113a79b2ad94e8f4019eeb1f374371c0a321c11 Mon Sep 17 00:00:00 2001 From: Cameron Gutman Date: Wed, 4 Jan 2023 00:16:49 -0600 Subject: [PATCH 2/8] Add "AMD" to the AMF encoder title --- src_assets/common/assets/web/config.html | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src_assets/common/assets/web/config.html b/src_assets/common/assets/web/config.html index 3d852d2f31d..3949803ba1e 100644 --- a/src_assets/common/assets/web/config.html +++ b/src_assets/common/assets/web/config.html @@ -815,7 +815,7 @@

Configuration

}, { id: "amd", - name: "AMF Encoder", + name: "AMD AMF Encoder", }, { id: "va-api", From e13389f86764a5eb127fa6544148aefc5ed97c25 Mon Sep 17 00:00:00 2001 From: Cameron Gutman Date: Wed, 4 Jan 2023 00:17:43 -0600 Subject: [PATCH 3/8] Hide tabs for encoders that are not available --- src_assets/common/assets/web/config.html | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/src_assets/common/assets/web/config.html b/src_assets/common/assets/web/config.html index 3949803ba1e..e9b3f27afc4 100644 --- a/src_assets/common/assets/web/config.html +++ b/src_assets/common/assets/web/config.html @@ -838,12 +838,17 @@

Configuration

var app = document.getElementById("app"); if (this.platform == "windows") { this.tabs = this.tabs.filter((el) => { - return el.id !== "va-api"; + return el.id !== "va-api" && el.id !== "vt"; }); } if (this.platform == "linux") { this.tabs = this.tabs.filter((el) => { - return el.id !== "amd"; + return el.id !== "amd" && el.id !== "vt"; + }); + } + if (this.platform == "macos") { + this.tabs = this.tabs.filter((el) => { + return el.id !== "amd" && el.id !== "va-api" && el.id !== "nv"; }); } From 98cc2e8ab2db50413f7d85cfeff14087160b61a6 Mon Sep 17 00:00:00 2001 From: Cameron Gutman Date: Wed, 4 Jan 2023 00:21:25 -0600 Subject: [PATCH 4/8] Fix QP misspelling --- docs/source/about/advanced_usage.rst | 2 +- src_assets/common/assets/web/config.html | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/docs/source/about/advanced_usage.rst b/docs/source/about/advanced_usage.rst index ec8b5a41a7f..f208772889d 100644 --- a/docs/source/about/advanced_usage.rst +++ b/docs/source/about/advanced_usage.rst @@ -667,7 +667,7 @@ qp ^^ **Description** - Quantitization Parameter. Some devices don't support Constant Bit Rate. For those devices, QP is used instead. + Quantization Parameter. Some devices don't support Constant Bit Rate. For those devices, QP is used instead. .. Warning:: Higher value means more compression, but less quality. diff --git a/src_assets/common/assets/web/config.html b/src_assets/common/assets/web/config.html index e9b3f27afc4..578fb6500bb 100644 --- a/src_assets/common/assets/web/config.html +++ b/src_assets/common/assets/web/config.html @@ -461,7 +461,7 @@

Configuration

- + Configuration v-model="config.qp" />
- Quantitization Parameter
+ Quantization Parameter
Some devices may not support Constant Bit Rate.
For those devices, QP is used instead.
Higher value means more compression, but less quality
From 2436bd2d150e94261add82fd450b1b93171d87c4 Mon Sep 17 00:00:00 2001 From: Cameron Gutman Date: Wed, 4 Jan 2023 00:31:35 -0600 Subject: [PATCH 5/8] Sort encoder tabs in priority order --- src_assets/common/assets/web/config.html | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/src_assets/common/assets/web/config.html b/src_assets/common/assets/web/config.html index 578fb6500bb..ab58f4a74dc 100644 --- a/src_assets/common/assets/web/config.html +++ b/src_assets/common/assets/web/config.html @@ -726,6 +726,7 @@

Configuration

+
Configuration id: "advanced", name: "Advanced", }, - { - id: "sw", - name: "Software Encoder", - }, { id: "nv", name: "NVENC Encoder", @@ -825,6 +822,10 @@

Configuration

id: "vt", name: "VideoToolbox encoder", }, + { + id: "sw", + name: "Software Encoder", + }, ], }; }, From 1a7cdb70cb9f4ebe43016c429f31ba1abf051363 Mon Sep 17 00:00:00 2001 From: Cameron Gutman Date: Wed, 4 Jan 2023 17:06:23 -0600 Subject: [PATCH 6/8] Standardize NVENC name and and capitalization for VT and VA-API --- src_assets/common/assets/web/config.html | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src_assets/common/assets/web/config.html b/src_assets/common/assets/web/config.html index ab58f4a74dc..9a6dd29729d 100644 --- a/src_assets/common/assets/web/config.html +++ b/src_assets/common/assets/web/config.html @@ -522,7 +522,7 @@

Configuration

- - - + + + +