fix p2p stats safety

Author: mateeullahmalik

p2p/kademlia/dht.go

@@ -463,7 +463,26 @@ func (s *DHT) PeersSnapshot() []*Node {
 	if s == nil || s.ht == nil {
 		return nil
 	}
-	return s.ht.nodes()
+	in := s.ht.nodes()
+	if len(in) == 0 {
+		return nil
+	}
+
+	out := make([]*Node, 0, len(in))
+	for _, n := range in {
+		if n == nil {
+			continue
+		}
+		cp := *n
+		if n.ID != nil {
+			cp.ID = append([]byte(nil), n.ID...)
+		}
+		if n.HashedID != nil {
+			cp.HashedID = append([]byte(nil), n.HashedID...)
+		}
+		out = append(out, &cp)
+	}
+	return out
 }
 
 func (s *DHT) NetworkHandleMetricsSnapshot() map[string]HandleCounters {

p2p/p2p.go

@@ -4,6 +4,7 @@ import (
 	"context"
 	"encoding/hex"
 	"fmt"
+	"sync"
 	"time"
 
 	"github.com/LumeraProtocol/supernode/v2/p2p/kademlia"
@@ -49,6 +50,7 @@ type p2p struct {
 	keyring      keyring.Keyring // Add the keyring field
 	rqstore      rqstore.Store
 	stats        *p2pStatsManager
+	statsOnce    sync.Once
 }
 
 // Run the kademlia network
@@ -172,8 +174,13 @@ func (s *p2p) Stats(ctx context.Context) (*StatsSnapshot, error) {
 	if err := ctx.Err(); err != nil {
 		return nil, err
 	}
+	s.statsOnce.Do(func() {
+		if s.stats == nil {
+			s.stats = newP2PStatsManager()
+		}
+	})
 	if s.stats == nil {
-		s.stats = newP2PStatsManager()
+		return nil, errors.New("p2p stats manager is nil")
 	}
 	return s.stats.Stats(ctx, s)
 }

p2p/p2p_stats.go

@@ -210,7 +210,20 @@ func cloneSnapshot(in *StatsSnapshot) *StatsSnapshot {
 	out := *in
 
 	if in.Peers != nil {
-		out.Peers = append([]*kademlia.Node(nil), in.Peers...)
+		out.Peers = make([]*kademlia.Node, len(in.Peers))
+		for i, peer := range in.Peers {
+			if peer == nil {
+				continue
+			}
+			cp := *peer
+			if peer.ID != nil {
+				cp.ID = append([]byte(nil), peer.ID...)
+			}
+			if peer.HashedID != nil {
+				cp.HashedID = append([]byte(nil), peer.HashedID...)
+			}
+			out.Peers[i] = &cp
+		}
 	}
 
 	if in.BanList != nil {

supernode/status/service.go

@@ -136,6 +136,9 @@ func (s *SupernodeStatusService) GetStatus(ctx context.Context, includeP2PMetric
 		if peers := snap.Peers; len(peers) > 0 {
 			resp.Network.PeerAddresses = make([]string, 0, len(peers))
 			for _, peer := range peers {
+				if peer == nil {
+					continue
+				}
 				resp.Network.PeerAddresses = append(resp.Network.PeerAddresses, fmt.Sprintf("%s@%s:%d", string(peer.ID), peer.IP, peer.Port))
 			}
 		}