Skip to content

Commit 1340497

Browse files
author
Mark Zhang
committed
Add comments
1 parent af75f84 commit 1340497

File tree

3 files changed

+7
-5
lines changed

3 files changed

+7
-5
lines changed

src/simulation/m_ibm.fpp

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -156,6 +156,8 @@ contains
156156
integer :: j1, j2, k1, k2, l1, l2
157157
real(wp) :: coeff, jac_IP
158158
type(ghost_point) :: gp
159+
160+
! At all ghost points, use its image point to interpolate sigma
159161
if (num_gps > 0) then
160162
$:GPU_PARALLEL_LOOP(private='[i, j, k, l, j1, j2, k1, k2, l1, l2, r, s, t, gp, coeff, jac_IP]')
161163
do i = 1, num_gps
@@ -195,7 +197,7 @@ contains
195197

196198
type(scalar_field), &
197199
dimension(sys_size), &
198-
intent(INOUT) :: q_cons_vf !< Primitive Variables
200+
intent(INOUT) :: q_cons_vf !< Conservative Variables
199201

200202
type(scalar_field), &
201203
dimension(sys_size), &
@@ -311,7 +313,7 @@ contains
311313
end if
312314

313315
! set the pressure
314-
! !TEMPORARY, NEED TO FIX FOR IGR
316+
! !TEMPORARY, NEED TO FIX FOR MOVING IGR
315317
if (.not. igr) then
316318
if (patch_ib(patch_id)%moving_ibm <= 1) then
317319
q_prim_vf(E_idx)%sf(j, k, l) = pres_IP
@@ -959,6 +961,8 @@ contains
959961
coeff = gp%interp_coeffs(i - i1 + 1, j - j1 + 1, k - k1 + 1)
960962
961963
if (igr) then
964+
! For IGR, we will need to perform operations on
965+
! the conservative variables instead
962966
alphaSum = 0._wp
963967
dyn_pres = 0._wp
964968
if (num_fluids == 1) then

src/simulation/m_igr.fpp

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -383,6 +383,7 @@ contains
383383
end do
384384
$:END_GPU_PARALLEL_LOOP()
385385
call s_update_igr(jac_sf)
386+
! If using Jacobi Iter, we need to update jac_old again
386387
if (igr_iter_solver == 1) then
387388
$:GPU_PARALLEL_LOOP(private='[j,k,l]', collapse=3)
388389
do l = idwbuff(3)%beg, idwbuff(3)%end

toolchain/mfc/case_validator.py

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -709,7 +709,6 @@ def check_igr_simulation(self): # pylint: disable=too-many-locals
709709
igr_iter_solver = self.get('igr_iter_solver')
710710
alf_factor = self.get('alf_factor')
711711
model_eqns = self.get('model_eqns')
712-
ib = self.get('ib', 'F') == 'T'
713712
bubbles_euler = self.get('bubbles_euler', 'F') == 'T'
714713
bubbles_lagrange = self.get('bubbles_lagrange', 'F') == 'T'
715714
alt_soundspeed = self.get('alt_soundspeed', 'F') == 'T'
@@ -732,8 +731,6 @@ def check_igr_simulation(self): # pylint: disable=too-many-locals
732731
"alf_factor must be non-negative")
733732
self.prohibit(model_eqns is not None and model_eqns != 2,
734733
"IGR only supports model_eqns = 2")
735-
# self.prohibit(ib,
736-
# "IGR does not support the immersed boundary method")
737734
self.prohibit(bubbles_euler,
738735
"IGR does not support Euler-Euler bubble models")
739736
self.prohibit(bubbles_lagrange,

0 commit comments

Comments
 (0)