From 31a86de19c3f006891aa587f2bf8f888ab4c4f89 Mon Sep 17 00:00:00 2001 From: jazairi <16103405+jazairi@users.noreply.github.com> Date: Tue, 22 Jul 2025 14:06:36 -0400 Subject: [PATCH] Remove testing line from fake auth config Why these changes are being introduced: While debugging a build failure, I noticed a todo to remove a bit of code that we used to test the new AWS org. That migration has finished, so we no longer need it. Relevant ticket(s): N/A How this addresses that need: This removes the line of code in question. Side effects of this change: None. --- app/models/concerns/fake_auth_config.rb | 4 ---- test/models/fake_auth_test.rb | 7 ------- 2 files changed, 11 deletions(-) diff --git a/app/models/concerns/fake_auth_config.rb b/app/models/concerns/fake_auth_config.rb index 8418d677..c477e4e7 100644 --- a/app/models/concerns/fake_auth_config.rb +++ b/app/models/concerns/fake_auth_config.rb @@ -27,10 +27,6 @@ def self.fake_auth_status private_class_method def self.app_name_pattern_match? return true if Rails.env.development? - # TODO: remove this line once we have confirmed the S3 and SQS migration to the new AWS org. We created a temporary - # second review app to test that migration. - return true if ENV.fetch('HEROKU_APP_NAME', nil) == 'thesis-submit-staging-new' - review_app_pattern = /^thesis-(submit|dropbox)-pr-\d+$/ review_app_pattern.match(ENV.fetch('HEROKU_APP_NAME', nil)).present? end diff --git a/test/models/fake_auth_test.rb b/test/models/fake_auth_test.rb index d20001f3..7b08ae99 100644 --- a/test/models/fake_auth_test.rb +++ b/test/models/fake_auth_test.rb @@ -60,11 +60,4 @@ class FakeAuthTest < ActiveSupport::TestCase assert_equal(false, FakeAuthConfig.fake_auth_status) end end - - test 'fakeauth enabled temp staging app name' do - ClimateControl.modify FAKE_AUTH_ENABLED: 'true', - HEROKU_APP_NAME: 'thesis-submit-staging-new' do - assert_equal true, FakeAuthConfig.fake_auth_status - end - end end