From 09787f3aa623dd72197fb96a1c7e8d3fc42fc742 Mon Sep 17 00:00:00 2001 From: BelfordZ Date: Tue, 7 Nov 2023 12:23:34 -0800 Subject: [PATCH 1/8] Release 89.0.0 --- package.json | 2 +- packages/queued-request-controller/CHANGELOG.md | 12 +++++++++++- packages/queued-request-controller/package.json | 2 +- 3 files changed, 13 insertions(+), 3 deletions(-) diff --git a/package.json b/package.json index 0d5c383e0a9..616f1d41832 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "@metamask/core-monorepo", - "version": "88.0.0", + "version": "89.0.0", "private": true, "description": "Monorepo for packages shared between MetaMask clients", "repository": { diff --git a/packages/queued-request-controller/CHANGELOG.md b/packages/queued-request-controller/CHANGELOG.md index f10492ee335..626ca5643a6 100644 --- a/packages/queued-request-controller/CHANGELOG.md +++ b/packages/queued-request-controller/CHANGELOG.md @@ -6,6 +6,15 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 ## [Unreleased] +## [0.1.3] +### Uncategorized +- Fix network nicknames ([#2000](https://github.com/MetaMask/core/pull/2000)) +- Release 88.0.0 ([#1996](https://github.com/MetaMask/core/pull/1996)) +- Bump @metamask/auto-changelog from 3.4.2 to 3.4.3 ([#1997](https://github.com/MetaMask/core/pull/1997)) +- move json-rpc-engine from merged-packages to packages ([#1895](https://github.com/MetaMask/core/pull/1895)) +- Bump @metamask/utils from 8.1.0 to 8.2.0 ([#1957](https://github.com/MetaMask/core/pull/1957)) +- Change `test` build scripts to only show output for failed tests by default ([#1949](https://github.com/MetaMask/core/pull/1949)) + ## [0.1.2] ### Fixed - Fix issue where switching chain would ultimately fail due to the wrong `networkClientId` / `type` ([#1962](https://github.com/MetaMask/core/pull/1962)) @@ -18,7 +27,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 ### Added - Initial release -[Unreleased]: https://github.com/MetaMask/core/compare/@metamask/queued-request-controller@0.1.2...HEAD +[Unreleased]: https://github.com/MetaMask/core/compare/@metamask/queued-request-controller@0.1.3...HEAD +[0.1.3]: https://github.com/MetaMask/core/compare/@metamask/queued-request-controller@0.1.2...@metamask/queued-request-controller@0.1.3 [0.1.2]: https://github.com/MetaMask/core/compare/@metamask/queued-request-controller@0.1.1...@metamask/queued-request-controller@0.1.2 [0.1.1]: https://github.com/MetaMask/core/compare/@metamask/queued-request-controller@0.1.0...@metamask/queued-request-controller@0.1.1 [0.1.0]: https://github.com/MetaMask/core/releases/tag/@metamask/queued-request-controller@0.1.0 diff --git a/packages/queued-request-controller/package.json b/packages/queued-request-controller/package.json index bcea9a64f43..bcb59d24482 100644 --- a/packages/queued-request-controller/package.json +++ b/packages/queued-request-controller/package.json @@ -1,6 +1,6 @@ { "name": "@metamask/queued-request-controller", - "version": "0.1.2", + "version": "0.1.3", "description": "Includes a controller and middleware that implements a request queue", "keywords": [ "MetaMask", From 4dd34f75238f965862151d5946ebbe9de5d0c0b3 Mon Sep 17 00:00:00 2001 From: BelfordZ Date: Tue, 7 Nov 2023 12:32:15 -0800 Subject: [PATCH 2/8] update changelog --- packages/queued-request-controller/CHANGELOG.md | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/packages/queued-request-controller/CHANGELOG.md b/packages/queued-request-controller/CHANGELOG.md index 626ca5643a6..5402c583bcd 100644 --- a/packages/queued-request-controller/CHANGELOG.md +++ b/packages/queued-request-controller/CHANGELOG.md @@ -7,13 +7,14 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 ## [Unreleased] ## [0.1.3] -### Uncategorized +### Fixed - Fix network nicknames ([#2000](https://github.com/MetaMask/core/pull/2000)) -- Release 88.0.0 ([#1996](https://github.com/MetaMask/core/pull/1996)) -- Bump @metamask/auto-changelog from 3.4.2 to 3.4.3 ([#1997](https://github.com/MetaMask/core/pull/1997)) + +### Changed +- Change `test` build scripts to only show output for failed tests by default ([#1949](https://github.com/MetaMask/core/pull/1949)) - move json-rpc-engine from merged-packages to packages ([#1895](https://github.com/MetaMask/core/pull/1895)) - Bump @metamask/utils from 8.1.0 to 8.2.0 ([#1957](https://github.com/MetaMask/core/pull/1957)) -- Change `test` build scripts to only show output for failed tests by default ([#1949](https://github.com/MetaMask/core/pull/1949)) +- Bump @metamask/auto-changelog from 3.4.2 to 3.4.3 ([#1997](https://github.com/MetaMask/core/pull/1997)) ## [0.1.2] ### Fixed From 7c47f52a01202d36a9a95fcedfde31958d55243f Mon Sep 17 00:00:00 2001 From: Zachary Belford Date: Tue, 7 Nov 2023 12:40:33 -0800 Subject: [PATCH 3/8] Fixup changelog --- packages/queued-request-controller/CHANGELOG.md | 2 -- 1 file changed, 2 deletions(-) diff --git a/packages/queued-request-controller/CHANGELOG.md b/packages/queued-request-controller/CHANGELOG.md index 5402c583bcd..c4881414ed9 100644 --- a/packages/queued-request-controller/CHANGELOG.md +++ b/packages/queued-request-controller/CHANGELOG.md @@ -11,10 +11,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 - Fix network nicknames ([#2000](https://github.com/MetaMask/core/pull/2000)) ### Changed -- Change `test` build scripts to only show output for failed tests by default ([#1949](https://github.com/MetaMask/core/pull/1949)) - move json-rpc-engine from merged-packages to packages ([#1895](https://github.com/MetaMask/core/pull/1895)) - Bump @metamask/utils from 8.1.0 to 8.2.0 ([#1957](https://github.com/MetaMask/core/pull/1957)) -- Bump @metamask/auto-changelog from 3.4.2 to 3.4.3 ([#1997](https://github.com/MetaMask/core/pull/1997)) ## [0.1.2] ### Fixed From a633e7b8ad20492b95050d395b9c0b62580cbe14 Mon Sep 17 00:00:00 2001 From: Zachary Belford Date: Tue, 7 Nov 2023 12:42:06 -0800 Subject: [PATCH 4/8] Update changelog to include addEthereumChain fix --- packages/queued-request-controller/CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/packages/queued-request-controller/CHANGELOG.md b/packages/queued-request-controller/CHANGELOG.md index c4881414ed9..33514386f08 100644 --- a/packages/queued-request-controller/CHANGELOG.md +++ b/packages/queued-request-controller/CHANGELOG.md @@ -9,6 +9,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 ## [0.1.3] ### Fixed - Fix network nicknames ([#2000](https://github.com/MetaMask/core/pull/2000)) +- Fix addEthereumChain showing switch ethereum chain dialog ([#2000](https://github.com/MetaMask/core/pull/2000)) ### Changed - move json-rpc-engine from merged-packages to packages ([#1895](https://github.com/MetaMask/core/pull/1895)) From 9d747e94998ed7f79a02ee09c491fdaeffb496d5 Mon Sep 17 00:00:00 2001 From: Zachary Belford Date: Tue, 7 Nov 2023 12:43:25 -0800 Subject: [PATCH 5/8] Fix wording on changelog for updating dependency --- packages/queued-request-controller/CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/queued-request-controller/CHANGELOG.md b/packages/queued-request-controller/CHANGELOG.md index 33514386f08..81ff885ae96 100644 --- a/packages/queued-request-controller/CHANGELOG.md +++ b/packages/queued-request-controller/CHANGELOG.md @@ -12,7 +12,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 - Fix addEthereumChain showing switch ethereum chain dialog ([#2000](https://github.com/MetaMask/core/pull/2000)) ### Changed -- move json-rpc-engine from merged-packages to packages ([#1895](https://github.com/MetaMask/core/pull/1895)) +- Bump dependency on @metamask/json-rpc-engine to ^7.2.0 ([#1895](https://github.com/MetaMask/core/pull/1895))([#1895](https://github.com/MetaMask/core/pull/1895)) - Bump @metamask/utils from 8.1.0 to 8.2.0 ([#1957](https://github.com/MetaMask/core/pull/1957)) ## [0.1.2] From afbc3f5d6a3a43469550239ed4019b5d9906f778 Mon Sep 17 00:00:00 2001 From: Zachary Belford Date: Tue, 7 Nov 2023 12:47:23 -0800 Subject: [PATCH 6/8] fix typo on changelog Co-authored-by: jiexi --- packages/queued-request-controller/CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/queued-request-controller/CHANGELOG.md b/packages/queued-request-controller/CHANGELOG.md index 81ff885ae96..17b4c49f5e8 100644 --- a/packages/queued-request-controller/CHANGELOG.md +++ b/packages/queued-request-controller/CHANGELOG.md @@ -12,7 +12,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 - Fix addEthereumChain showing switch ethereum chain dialog ([#2000](https://github.com/MetaMask/core/pull/2000)) ### Changed -- Bump dependency on @metamask/json-rpc-engine to ^7.2.0 ([#1895](https://github.com/MetaMask/core/pull/1895))([#1895](https://github.com/MetaMask/core/pull/1895)) +- Bump dependency on @metamask/json-rpc-engine to ^7.2.0 ([#1895](https://github.com/MetaMask/core/pull/1895)) - Bump @metamask/utils from 8.1.0 to 8.2.0 ([#1957](https://github.com/MetaMask/core/pull/1957)) ## [0.1.2] From 68132367fcd9d02884ffb8e6d845e57bcaf2bde2 Mon Sep 17 00:00:00 2001 From: BelfordZ Date: Tue, 7 Nov 2023 13:04:03 -0800 Subject: [PATCH 7/8] fix changelog formatting --- packages/queued-request-controller/CHANGELOG.md | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/packages/queued-request-controller/CHANGELOG.md b/packages/queued-request-controller/CHANGELOG.md index 17b4c49f5e8..8622ea3005a 100644 --- a/packages/queued-request-controller/CHANGELOG.md +++ b/packages/queued-request-controller/CHANGELOG.md @@ -7,14 +7,14 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 ## [Unreleased] ## [0.1.3] -### Fixed -- Fix network nicknames ([#2000](https://github.com/MetaMask/core/pull/2000)) -- Fix addEthereumChain showing switch ethereum chain dialog ([#2000](https://github.com/MetaMask/core/pull/2000)) - ### Changed - Bump dependency on @metamask/json-rpc-engine to ^7.2.0 ([#1895](https://github.com/MetaMask/core/pull/1895)) - Bump @metamask/utils from 8.1.0 to 8.2.0 ([#1957](https://github.com/MetaMask/core/pull/1957)) +### Fixed +- Fix network nicknames ([#2000](https://github.com/MetaMask/core/pull/2000)) +- Fix addEthereumChain showing switch ethereum chain dialog ([#2000](https://github.com/MetaMask/core/pull/2000)) + ## [0.1.2] ### Fixed - Fix issue where switching chain would ultimately fail due to the wrong `networkClientId` / `type` ([#1962](https://github.com/MetaMask/core/pull/1962)) From 9538f9430e9a86b648edba373b255d7cb00ebf1a Mon Sep 17 00:00:00 2001 From: Zachary Belford Date: Tue, 7 Nov 2023 13:26:32 -0800 Subject: [PATCH 8/8] Added better descriptions to the changelog --- packages/queued-request-controller/CHANGELOG.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/queued-request-controller/CHANGELOG.md b/packages/queued-request-controller/CHANGELOG.md index 8622ea3005a..06b55cb3a0d 100644 --- a/packages/queued-request-controller/CHANGELOG.md +++ b/packages/queued-request-controller/CHANGELOG.md @@ -12,8 +12,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 - Bump @metamask/utils from 8.1.0 to 8.2.0 ([#1957](https://github.com/MetaMask/core/pull/1957)) ### Fixed -- Fix network nicknames ([#2000](https://github.com/MetaMask/core/pull/2000)) -- Fix addEthereumChain showing switch ethereum chain dialog ([#2000](https://github.com/MetaMask/core/pull/2000)) +- Fixes an issue in the extension when 'useRequestQueue' is enabled. The problem occurred when a DApp's selected network differed from the globally selected network, and when the DApp's chosen network was not a built-in network. Under these conditions, the nickname would not be displayed in the 'toNetworkConfiguration' parameter passed to the `addApproval` function ([#2000](https://github.com/MetaMask/core/pull/2000)). +- Fixes an issue in the extension when 'useRequestQueue' is activated. Previously, when invoking 'wallet_addEthereumChain', if the DApp's selected network was different from the globally selected network, the user was incorrectly prompted to switch the Ethereum chain prior to the 'addEthereumChain' request. With this update, 'addEthereumChain' will still be queued (due to its confirmation requirement), but the unnecessary chain switch prompt has been eliminated ([#2000](https://github.com/MetaMask/core/pull/2000)). ## [0.1.2] ### Fixed