From 2995e389352a14ad650c77fe49e17670ba78fa19 Mon Sep 17 00:00:00 2001 From: Mark Stacey Date: Wed, 10 Feb 2021 01:12:43 -0330 Subject: [PATCH] Update approval controller test import The approval controller tests were importing the _built_ version of the approval controller, rather than the original source. This resulted in odd coverage stats, and necessitated ignoring `dist/BaseController*`. By updating the import to use the source directly, the coverage stats look fine without ignoring anything. --- package.json | 1 - tests/ApprovalController.test.js | 2 +- tests/ApprovalController.test.ts | 2 +- 3 files changed, 2 insertions(+), 3 deletions(-) diff --git a/package.json b/package.json index b439e75dea2..69987d207af 100644 --- a/package.json +++ b/package.json @@ -96,7 +96,6 @@ ], "coveragePathIgnorePatterns": [ "/node_modules/", - "dist/BaseController*", "tests/" ], "coverageThreshold": { diff --git a/tests/ApprovalController.test.js b/tests/ApprovalController.test.js index 2b92d1b046d..547d94f9aad 100644 --- a/tests/ApprovalController.test.js +++ b/tests/ApprovalController.test.js @@ -1,5 +1,5 @@ const { errorCodes } = require('eth-rpc-errors'); -const ApprovalController = require('../dist/approval/ApprovalController').default; +const ApprovalController = require('../src/approval/ApprovalController').default; const defaultConfig = { showApprovalRequest: () => undefined, diff --git a/tests/ApprovalController.test.ts b/tests/ApprovalController.test.ts index 4f55c698aa6..1856157852e 100644 --- a/tests/ApprovalController.test.ts +++ b/tests/ApprovalController.test.ts @@ -1,5 +1,5 @@ import { errorCodes } from 'eth-rpc-errors'; -import ApprovalController from '../dist/approval/ApprovalController'; +import ApprovalController from '../src/approval/ApprovalController'; const sinon = require('sinon');