From b30fc4540851afc3f5d013d3f927a247efcaac6d Mon Sep 17 00:00:00 2001 From: Elliot Winkler Date: Thu, 15 Feb 2024 14:04:00 -0700 Subject: [PATCH 1/2] Add SL as codeowners for snaps-owned controllers MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Whenever the version of a package in this monorepo is bumped, all dependencies on that package in other workspace packages are also bumped. This happens frequently in release PRs. The Snaps team is listed as codeowners of `permission-controller`, `notification-controller`, and `rate-limit-controller`, so when any changes to these packages occur in a PR, the Snaps team must approve that PR. This means that if a dependency on a package is bumped in any of these controllers within a release PR, then the Snaps team must approve that release — even if none of those controllers are included in the release. This creates an obstacle to creating releases quickly. To fix this, this commit adds the Shared Libraries team as codeowners of these controllers as well. This way, they can ask the Snaps team to approve only if it is necessary. --- .github/CODEOWNERS | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS index 2cfff3ee82e..e87487f6b4c 100644 --- a/.github/CODEOWNERS +++ b/.github/CODEOWNERS @@ -1,8 +1,7 @@ # Lines starting with '#' are comments. # Each line is a file pattern followed by one or more owners. -* @MetaMask/devs - -/packages/permission-controller @MetaMask/snaps-devs -/packages/notification-controller @MetaMask/snaps-devs -/packages/rate-limit-controller @MetaMask/snaps-devs +* @MetaMask/engineering +/packages/permission-controller @MetaMask/snaps-devs @MetaMask/shared-libraries-engineers +/packages/notification-controller @MetaMask/snaps-devs @MetaMask/shared-libraries-engineers +/packages/rate-limit-controller @MetaMask/snaps-devs @MetaMask/shared-libraries-engineers From 68654dda2ab897221eb81ec45185fd88d83eb594 Mon Sep 17 00:00:00 2001 From: Elliot Winkler Date: Thu, 15 Feb 2024 15:20:46 -0700 Subject: [PATCH 2/2] Use smaller teams for default codeowners --- .github/CODEOWNERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS index e87487f6b4c..6692cb37e1b 100644 --- a/.github/CODEOWNERS +++ b/.github/CODEOWNERS @@ -1,7 +1,7 @@ # Lines starting with '#' are comments. # Each line is a file pattern followed by one or more owners. -* @MetaMask/engineering +* @MetaMask/extension-devs @MetaMask/mobile-devs @MetaMask/shared-libraries-engineers /packages/permission-controller @MetaMask/snaps-devs @MetaMask/shared-libraries-engineers /packages/notification-controller @MetaMask/snaps-devs @MetaMask/shared-libraries-engineers /packages/rate-limit-controller @MetaMask/snaps-devs @MetaMask/shared-libraries-engineers