PRODENG-2480 remove docker lib/run folders#403
Closed
james-nesbitt wants to merge 1 commit into
Closed
Conversation
Collaborator
james-nesbitt
commented
Jan 18, 2024
james-nesbitt
commented
- new docker info function to detect folders
- new linux function for removing lib/run folders (default or found)
- run new linux remove function in various linux configurer uninstall MCR functions
- new docker info function to detect folders - new linux function for removing lib/run folders (default or found) - run new linux remove function in various linux configurer uninstall MCR functions Signed-off-by: James Nesbitt <jnesbitt@mirantis.com>
Collaborator
Author
|
I don't think that this is a good approach:
|
james-nesbitt
commented
Jan 18, 2024
| endif | ||
| GOOS ?= ${uname_s} | ||
| BUILDER_IMAGE = launchpad-builder | ||
| GO = docker run --rm -v "$(CURDIR)":/go/src/github.com/Mirantis/mcc \ |
Collaborator
Author
There was a problem hiding this comment.
this rewires the GO flag so that you can use a local GOLANG and avoid some of the poor impacts of building in a docker image locally.
Collaborator
Author
|
replaced by #404 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.