PRODENG-2480 Launchpad reset now cleans the lingering MCR files#404
Conversation
|
Tested on both Ubuntu20 and rhel9.3 alongside Windows2019. |
| "github.com/k0sproject/rig/os" | ||
| ) | ||
|
|
||
| type CommonConfigurer struct{} |
There was a problem hiding this comment.
Please rename this to DockerConfigurer (and change file name as well.) When using Composition, you should target your implementations when possible, instead of letting them grow large. The risk for large Composition bases is unneeded complexity, while the strength is atomicity and isolation.
There was a problem hiding this comment.
You could also consider importing the new configurer directly into the LinuxConfigurator parent, but I think it is not necessarily a good idea.
There was a problem hiding this comment.
It is imported directly into both LinuxConfigurator and WindowsConfigurator
| var err error | ||
| info, getDockerError := c.GetDockerInfo(h, c.Kind()) | ||
| if getDockerError == nil { | ||
| if err = h.Exec("sudo docker system prune -f"); err != nil { |
There was a problem hiding this comment.
should we put this into engineConfig.Prune control? Not required for this change, but it might be easy.
There was a problem hiding this comment.
That's a good point. I don't think we need to include it in this PR, but we might want to have a separate PR.
|
@cranzy can you confirm what you tested? the image doesn't work. Did you test positive and negative prune flags? |
I do confirm the image worked when I tested it both with |
Signed-off-by: Dimitar Dimitrov <ddimitrov@mirantis.com>
2 participants
launchpad reseteven when docker is malformed or not correctly installedhttps://mirantis.jira.com/browse/PRODENG-2480