From 986c49b152dbf43dd59b02866490a8d56bc79334 Mon Sep 17 00:00:00 2001 From: oraqlle <41113853+oraqlle@users.noreply.github.com> Date: Sun, 23 Jul 2023 13:17:08 +1000 Subject: [PATCH 1/4] Added GitHub PR template. --- .github/PULL_REQUEST_TEMPLATE.md | 35 ++++++++++++++++++++++++++++++++ 1 file changed, 35 insertions(+) create mode 100644 .github/PULL_REQUEST_TEMPLATE.md diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md new file mode 100644 index 0000000..7b842e6 --- /dev/null +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -0,0 +1,35 @@ +# Submit a pull request + +Thank you for submitting a pull request! To speed up the review process, please ensure that everything below +is true: + +1. You have followed the [contributing guidelines][1] +2. The repositories you have linked are owned by you or you have permission to link them. +3. The PRs title is followed by your name eg. "Added solutions for {YYYY} - {First} {Last}" + +Any questions should be directed to @MonashDeepNeuron/executives. + +> Note: Ensure to delete the instructions once you have finished your PR. + +--- + +Replace any "X" below with information about your pull request. + +## Details + + + +X + +## Linked + + + +- X + +[1]: https://github.com/MonashDeepNeuron/HPC-Training/blob/main/CONTRIBUTING.md From ac8bcc0fb691c55a4eb5ac6c33d9e2071d29ea72 Mon Sep 17 00:00:00 2001 From: oraqlle <41113853+oraqlle@users.noreply.github.com> Date: Sun, 23 Jul 2023 13:21:29 +1000 Subject: [PATCH 2/4] Fixed some instructions to be more appropriate for this repo. --- .github/PULL_REQUEST_TEMPLATE.md | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 7b842e6..5ba45b0 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -4,10 +4,10 @@ Thank you for submitting a pull request! To speed up the review process, please is true: 1. You have followed the [contributing guidelines][1] -2. The repositories you have linked are owned by you or you have permission to link them. -3. The PRs title is followed by your name eg. "Added solutions for {YYYY} - {First} {Last}" +2. You have added an appropriate title to the PR. +3. Requested a review from the HPC Training team. -Any questions should be directed to @MonashDeepNeuron/executives. +Any questions should be directed to @MonashDeepNeuron/hpc-training. > Note: Ensure to delete the instructions once you have finished your PR. From 0184f85ce6010a788ddcdbfb79f46972ed3415fa Mon Sep 17 00:00:00 2001 From: oraqlle <41113853+oraqlle@users.noreply.github.com> Date: Sun, 23 Jul 2023 13:23:56 +1000 Subject: [PATCH 3/4] Clarified the delete instructions. --- .github/PULL_REQUEST_TEMPLATE.md | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 5ba45b0..f8e876c 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -6,11 +6,10 @@ is true: 1. You have followed the [contributing guidelines][1] 2. You have added an appropriate title to the PR. 3. Requested a review from the HPC Training team. +4. Delete any Markdown comments, instructions or anything else outside the below divider section once you have finished your PR. Any questions should be directed to @MonashDeepNeuron/hpc-training. -> Note: Ensure to delete the instructions once you have finished your PR. - --- Replace any "X" below with information about your pull request. @@ -32,4 +31,6 @@ eg. - X +--- + [1]: https://github.com/MonashDeepNeuron/HPC-Training/blob/main/CONTRIBUTING.md From ef93ab89fb69af4a1e437d1ecc71434e1fcee104 Mon Sep 17 00:00:00 2001 From: oraqlle <41113853+oraqlle@users.noreply.github.com> Date: Sun, 23 Jul 2023 13:25:53 +1000 Subject: [PATCH 4/4] Added step to ensure merging into dev staging branch. --- .github/PULL_REQUEST_TEMPLATE.md | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index f8e876c..0e83422 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -7,6 +7,7 @@ is true: 2. You have added an appropriate title to the PR. 3. Requested a review from the HPC Training team. 4. Delete any Markdown comments, instructions or anything else outside the below divider section once you have finished your PR. +5. Ensure that you are merging into the `dev` and not `main`. Any questions should be directed to @MonashDeepNeuron/hpc-training.