Better management of text messages ( JSONize )

[arkanoider]

Create a new variant in Conten enum to Jsonize also text messages, to get nicer parsing options in CLI, this is what you did exactly for PayHoldInvoice message:

pub enum Content { Order(Order), PaymentRequest(String), PayHoldInvoice(Order, String), TextMessage(String), }

this could be managed in a better way on CLI side in util.rs line line 76: I think we can eliminate the Err part, or using it for a real Err, than we can match agains differnent Content

while let Ok(notification) = notifications.recv().await {
        if wait_for_dm_ans {
            let dm = get_direct_messages(client, mostro_pubkey, my_key, 1).await;

            for el in dm.iter() {
                match Message::from_json(&el.0) {
                    Ok(m) => {
                        if let Some(Content::PayHoldInvoice(ord, inv)) = m.content {
                            println!("NEW MESSAGE:");
                            println!(
                                "Mostro sent you this hold invoice for order id: {}",
                                ord.id.unwrap()
                            );
                            println!();
                            println!("Pay this invoice to continue -->  {}", inv);
                            println!();
                        }
                    }
                    Err(_) => {
                        println!("NEW MESSAGE:");
                        println!();
                        println!("Mostro sent you this message -->  {}", el.0);
                        println!();
                    }
                }
            }

Let me know boss!

[grunch]

That's right we need to fix this, current Content

pub enum Content {
    Order(NewOrder),
    PaymentRequest(String),
    PayHoldInvoice(NewOrder, String),
}

We can make it better and rehuse variants like this

pub enum Content {
    Order(NewOrder),
    PaymentRequest(Option<NewOrder>, String),
}

So when user send a takesell message it should created it like this:

  let content = Some(Content::PaymentRequest(None, invoice.to_string()));
  let message = Message::new(0, Some(order), Action::TakeSell, content)
                .as_json()
                .unwrap();

When send a message to the seller with the hold invoice, it should be:

  let new_order = order.as_new_order();
  let content = Some(Content::PaymentRequest(Some(new_order), hold_invoice.to_string()));
  let message = Message::new(0, Some(order_id), Action::PayInvoice, content)
                .as_json()
                .unwrap();

About TextMessage(String) sounds good to me, after all this Content will be like this:

pub enum Content {
    Order(NewOrder),
    PaymentRequest(Option<NewOrder>, String),
    TextMessage(String),
}

[grunch]

Closing this discussion via MostroP2P/mostro-cli#23 and #25