Fix pythonfmu-export module on OSX#187
Merged
Merged
Conversation
Member
|
Busy week, but I'll check your work next week. |
Contributor
Author
|
hi @markaren, any chance to give this a look ? this is a tiny but important fix |
Member
|
Thanks, LGTM |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
on Linux it should not be linked at all as symbols are loaded through the interpreter (same on MacOS but using a dedicated flag), linking is only required on Windows where undefined symbols are not allowed
Another possibility is linking to Python::Module, but it requires cmake>=3.24 (using Development.Module component) and that's a bit too recent
First l only wanted to help building on osx: see conda-forge/pythonfmu-feedstock#13
Closes #116
(involuntary bonus :)
Maybe it will help for #152 too