From f533dd28f91f73ed205d922adcd1ff9152bf8103 Mon Sep 17 00:00:00 2001 From: Pablo Garay Date: Mon, 15 Jul 2024 14:38:34 -0700 Subject: [PATCH 1/3] update pytorch 24.03 --- Dockerfile | 2 +- Dockerfile.ci | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/Dockerfile b/Dockerfile index a42ae592a9bd..dcacaba21886 100644 --- a/Dockerfile +++ b/Dockerfile @@ -14,7 +14,7 @@ # See the License for the specific language governing permissions and # limitations under the License. -ARG BASE_IMAGE=nvcr.io/nvidia/pytorch:24.01-py3 +ARG BASE_IMAGE=nvcr.io/nvidia/pytorch:24.03-py3 # build an image that includes only the nemo dependencies, ensures that dependencies # are included first for optimal caching, and useful for building a development diff --git a/Dockerfile.ci b/Dockerfile.ci index 15cd016073ca..0670070b862a 100644 --- a/Dockerfile.ci +++ b/Dockerfile.ci @@ -14,7 +14,7 @@ # See the License for the specific language governing permissions and # limitations under the License. -ARG BASE_IMAGE=nvcr.io/nvidia/pytorch:24.02-py3 +ARG BASE_IMAGE=nvcr.io/nvidia/pytorch:24.03-py3 FROM ${BASE_IMAGE} From 4076cca06a25843b1678ae466f170f416fb899a9 Mon Sep 17 00:00:00 2001 From: Pablo Garay Date: Tue, 16 Jul 2024 16:24:09 -0700 Subject: [PATCH 2/3] Ignore problematic unit test --- tests/collections/asr/decoding/rnnt_alignments_check.py | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/collections/asr/decoding/rnnt_alignments_check.py b/tests/collections/asr/decoding/rnnt_alignments_check.py index d44f7f8fd985..d56f8e0b53fa 100644 --- a/tests/collections/asr/decoding/rnnt_alignments_check.py +++ b/tests/collections/asr/decoding/rnnt_alignments_check.py @@ -72,6 +72,7 @@ def cleanup_local_folder(): # TODO: add the same tests for multi-blank RNNT decoding +@pytest.mark.pleasefixme @pytest.mark.skipif(not os.path.exists('/home/TestData'), reason='Not a Jenkins machine') @pytest.mark.parametrize("loop_labels", [True, False]) @pytest.mark.parametrize("use_cuda_graph_decoder", [True, False]) From 982fac473f6828eaeb77d5c4962bb7b17013dc78 Mon Sep 17 00:00:00 2001 From: Pablo Garay Date: Wed, 31 Jul 2024 10:56:25 -0700 Subject: [PATCH 3/3] PR adjustment --- tests/collections/asr/decoding/rnnt_alignments_check.py | 2 -- 1 file changed, 2 deletions(-) diff --git a/tests/collections/asr/decoding/rnnt_alignments_check.py b/tests/collections/asr/decoding/rnnt_alignments_check.py index 062c13e18ea1..ec0656cbce49 100644 --- a/tests/collections/asr/decoding/rnnt_alignments_check.py +++ b/tests/collections/asr/decoding/rnnt_alignments_check.py @@ -109,8 +109,6 @@ def cleanup_local_folder(): # TODO: add the same tests for multi-blank RNNT decoding -@pytest.mark.pleasefixme -@pytest.mark.skipif(not os.path.exists('/home/TestData'), reason='Not a Jenkins machine') @pytest.mark.parametrize("device", DEVICES) @pytest.mark.parametrize("loop_labels", [True, False]) @pytest.mark.parametrize("use_cuda_graph_decoder", [True, False])