[Audio] Remove torchaudio from spectrogram transforms#9802
Merged
anteju merged 3 commits intoNVIDIA-NeMo:mainfrom Jul 23, 2024
Merged
[Audio] Remove torchaudio from spectrogram transforms#9802anteju merged 3 commits intoNVIDIA-NeMo:mainfrom
anteju merged 3 commits intoNVIDIA-NeMo:mainfrom
Conversation
3f7fc34 to
5cdd568
Compare
5cdd568 to
3187b0a
Compare
racoiaws
reviewed
Jul 22, 2024
racoiaws
reviewed
Jul 22, 2024
racoiaws
reviewed
Jul 22, 2024
racoiaws
reviewed
Jul 22, 2024
racoiaws
reviewed
Jul 22, 2024
racoiaws
reviewed
Jul 22, 2024
racoiaws
reviewed
Jul 22, 2024
Collaborator
|
Overall LGTM, but needs documenting of all reshapes (e.g. via |
Signed-off-by: Ante Jukić <ajukic@nvidia.com>
dc63f1f to
8102bd0
Compare
Signed-off-by: Ante Jukić <ajukic@nvidia.com>
8102bd0 to
8c606e2
Compare
tonyjie
pushed a commit
to tonyjie/NeMo
that referenced
this pull request
Jul 24, 2024
* Spectrogram transforms without torchaudio Signed-off-by: Ante Jukić <ajukic@nvidia.com> * Use einops, added comments Signed-off-by: Ante Jukić <ajukic@nvidia.com> --------- Signed-off-by: Ante Jukić <ajukic@nvidia.com> Co-authored-by: Roman Korostik <roman.korostik@pm.me>
akoumpa
pushed a commit
that referenced
this pull request
Jul 25, 2024
* Spectrogram transforms without torchaudio Signed-off-by: Ante Jukić <ajukic@nvidia.com> * Use einops, added comments Signed-off-by: Ante Jukić <ajukic@nvidia.com> --------- Signed-off-by: Ante Jukić <ajukic@nvidia.com> Co-authored-by: Roman Korostik <roman.korostik@pm.me> Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>
BoxiangW
pushed a commit
to BoxiangW/NeMo
that referenced
this pull request
Jul 30, 2024
* Spectrogram transforms without torchaudio Signed-off-by: Ante Jukić <ajukic@nvidia.com> * Use einops, added comments Signed-off-by: Ante Jukić <ajukic@nvidia.com> --------- Signed-off-by: Ante Jukić <ajukic@nvidia.com> Co-authored-by: Roman Korostik <roman.korostik@pm.me> Signed-off-by: Boxiang Wang <boxiangw@nvidia.com>
xuanzic
pushed a commit
to xuanzic/NeMo
that referenced
this pull request
Aug 1, 2024
* Spectrogram transforms without torchaudio Signed-off-by: Ante Jukić <ajukic@nvidia.com> * Use einops, added comments Signed-off-by: Ante Jukić <ajukic@nvidia.com> --------- Signed-off-by: Ante Jukić <ajukic@nvidia.com> Co-authored-by: Roman Korostik <roman.korostik@pm.me> Signed-off-by: Vivian Chen <xuanzic@example.com>
kchike
pushed a commit
to kchike/NeMo
that referenced
this pull request
Aug 8, 2024
* Spectrogram transforms without torchaudio Signed-off-by: Ante Jukić <ajukic@nvidia.com> * Use einops, added comments Signed-off-by: Ante Jukić <ajukic@nvidia.com> --------- Signed-off-by: Ante Jukić <ajukic@nvidia.com> Co-authored-by: Roman Korostik <roman.korostik@pm.me> Signed-off-by: kchike <kohei.chike@jp.ricoh.com>
monica-sekoyan
pushed a commit
that referenced
this pull request
Oct 14, 2024
* Spectrogram transforms without torchaudio Signed-off-by: Ante Jukić <ajukic@nvidia.com> * Use einops, added comments Signed-off-by: Ante Jukić <ajukic@nvidia.com> --------- Signed-off-by: Ante Jukić <ajukic@nvidia.com> Co-authored-by: Roman Korostik <roman.korostik@pm.me>
hainan-xv
pushed a commit
to hainan-xv/NeMo
that referenced
this pull request
Nov 5, 2024
* Spectrogram transforms without torchaudio Signed-off-by: Ante Jukić <ajukic@nvidia.com> * Use einops, added comments Signed-off-by: Ante Jukić <ajukic@nvidia.com> --------- Signed-off-by: Ante Jukić <ajukic@nvidia.com> Co-authored-by: Roman Korostik <roman.korostik@pm.me> Signed-off-by: Hainan Xu <hainanx@nvidia.com>
XuesongYang
pushed a commit
to paarthneekhara/NeMo
that referenced
this pull request
Jan 18, 2025
* Spectrogram transforms without torchaudio Signed-off-by: Ante Jukić <ajukic@nvidia.com> * Use einops, added comments Signed-off-by: Ante Jukić <ajukic@nvidia.com> --------- Signed-off-by: Ante Jukić <ajukic@nvidia.com> Co-authored-by: Roman Korostik <roman.korostik@pm.me>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
This PR removes use of
torchaudiofromAudioToSpectrogramandSpectrogramToAudio.Classes using
torchaudioare kept underAudioToSpectrogamTAandSpectrogramToAudioTA, similarly toFilterbankFeaturesandFilterbankFeaturesTA.Collection: audio
Changelog
torchaudiorequirement forAudioToSpectrogramandSpectrogramToAudiotorchaudioversionUsage
GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
Before your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information