From bb676abfa211fc0f24a13b4ab7c4c3e6772a1094 Mon Sep 17 00:00:00 2001 From: ashors1 Date: Wed, 22 Oct 2025 14:33:43 -0700 Subject: [PATCH 1/4] append to hf_overrides rather than overwriting Signed-off-by: ashors1 --- nemo_rl/models/generation/vllm/vllm_worker.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/nemo_rl/models/generation/vllm/vllm_worker.py b/nemo_rl/models/generation/vllm/vllm_worker.py index 7ce826a27f..9e71acbe45 100644 --- a/nemo_rl/models/generation/vllm/vllm_worker.py +++ b/nemo_rl/models/generation/vllm/vllm_worker.py @@ -375,7 +375,9 @@ def _patch_vllm_sampler(): # overriden by quant config, however vllm complains if this not passed self.precision = "bfloat16" - vllm_kwargs["hf_overrides"] = self.cfg["vllm_cfg"].get("hf_overrides", {}) or {} + if "hf_overrides" not in vllm_kwargs: + vllm_kwargs["hf_overrides"] = {} + vllm_kwargs["hf_overrides"].update(self.cfg["vllm_cfg"].get("hf_overrides", {})) llm_kwargs = dict( model=self.model_name, From 903bed723553042454cac3a65305aab38c8a0322 Mon Sep 17 00:00:00 2001 From: ashors1 Date: Wed, 22 Oct 2025 14:47:40 -0700 Subject: [PATCH 2/4] commit suggestion Signed-off-by: ashors1 --- nemo_rl/models/generation/vllm/vllm_worker.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/nemo_rl/models/generation/vllm/vllm_worker.py b/nemo_rl/models/generation/vllm/vllm_worker.py index 9e71acbe45..8a960ec0a9 100644 --- a/nemo_rl/models/generation/vllm/vllm_worker.py +++ b/nemo_rl/models/generation/vllm/vllm_worker.py @@ -375,7 +375,7 @@ def _patch_vllm_sampler(): # overriden by quant config, however vllm complains if this not passed self.precision = "bfloat16" - if "hf_overrides" not in vllm_kwargs: + if not isinstance(vllm_kwargs.get("hf_overrides"), dict): vllm_kwargs["hf_overrides"] = {} vllm_kwargs["hf_overrides"].update(self.cfg["vllm_cfg"].get("hf_overrides", {})) From efd88e43e0d890513b93053c969cc5207af35099 Mon Sep 17 00:00:00 2001 From: ashors1 Date: Wed, 22 Oct 2025 20:03:30 -0700 Subject: [PATCH 3/4] fix case when hf_overrides is None Signed-off-by: ashors1 --- nemo_rl/models/generation/vllm/vllm_worker.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/nemo_rl/models/generation/vllm/vllm_worker.py b/nemo_rl/models/generation/vllm/vllm_worker.py index 8a960ec0a9..5d6854827e 100644 --- a/nemo_rl/models/generation/vllm/vllm_worker.py +++ b/nemo_rl/models/generation/vllm/vllm_worker.py @@ -377,7 +377,7 @@ def _patch_vllm_sampler(): if not isinstance(vllm_kwargs.get("hf_overrides"), dict): vllm_kwargs["hf_overrides"] = {} - vllm_kwargs["hf_overrides"].update(self.cfg["vllm_cfg"].get("hf_overrides", {})) + vllm_kwargs["hf_overrides"].update(self.cfg["vllm_cfg"].get("hf_overrides", {}) or {}) llm_kwargs = dict( model=self.model_name, From 0a34cd526de166a673ff527c0d48f3ac80b6a0dc Mon Sep 17 00:00:00 2001 From: ashors1 Date: Thu, 23 Oct 2025 15:02:58 -0700 Subject: [PATCH 4/4] lint Signed-off-by: ashors1 --- nemo_rl/models/generation/vllm/vllm_worker.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/nemo_rl/models/generation/vllm/vllm_worker.py b/nemo_rl/models/generation/vllm/vllm_worker.py index 5d6854827e..668b18f9f1 100644 --- a/nemo_rl/models/generation/vllm/vllm_worker.py +++ b/nemo_rl/models/generation/vllm/vllm_worker.py @@ -377,7 +377,9 @@ def _patch_vllm_sampler(): if not isinstance(vllm_kwargs.get("hf_overrides"), dict): vllm_kwargs["hf_overrides"] = {} - vllm_kwargs["hf_overrides"].update(self.cfg["vllm_cfg"].get("hf_overrides", {}) or {}) + vllm_kwargs["hf_overrides"].update( + self.cfg["vllm_cfg"].get("hf_overrides", {}) or {} + ) llm_kwargs = dict( model=self.model_name,