From 951f67889a2b5ff2cd2d519a80a919e7fc53a1da Mon Sep 17 00:00:00 2001 From: Jacob Hinkle Date: Tue, 21 May 2024 23:44:53 +0000 Subject: [PATCH] Replace bitwise assignment ops on bools --- csrc/device_lower/analysis/predicate_elimination.cpp | 8 ++++---- csrc/dynamic_transform.cpp | 3 ++- csrc/python_frontend/fusion_record.h | 9 +++++---- 3 files changed, 11 insertions(+), 9 deletions(-) diff --git a/csrc/device_lower/analysis/predicate_elimination.cpp b/csrc/device_lower/analysis/predicate_elimination.cpp index f3bfe3d8fee..7eb575ccf12 100644 --- a/csrc/device_lower/analysis/predicate_elimination.cpp +++ b/csrc/device_lower/analysis/predicate_elimination.cpp @@ -299,10 +299,10 @@ class PredicateChcker : public IterVisitor { "Should never have a reduction op without a tensor view input."); bool found_expand = false; for (auto tv_input : tv_inputs) { - found_expand |= std::any_of( - tv_input->getMaybeRFactorDomain().begin(), - tv_input->getMaybeRFactorDomain().end(), - [](IterDomain* id) { return id->hasExpandedExtent(); }); + found_expand = found_expand || + std::any_of(tv_input->getMaybeRFactorDomain().begin(), + tv_input->getMaybeRFactorDomain().end(), + [](IterDomain* id) { return id->hasExpandedExtent(); }); } if (!found_expand) { diff --git a/csrc/dynamic_transform.cpp b/csrc/dynamic_transform.cpp index 1a5b1a4da5b..3d0c08c866a 100644 --- a/csrc/dynamic_transform.cpp +++ b/csrc/dynamic_transform.cpp @@ -1263,7 +1263,8 @@ bool DynamicTransformConcretizer::propagateFromProducerToConsumer( "Producer ID not concretized: ", input_id->toString()); - has_expanded_producer |= input_id->hasExpandedExtent(); + has_expanded_producer = + has_expanded_producer || input_id->hasExpandedExtent(); if (id_type.has_value()) { id_type = ops::promoteIterType(*id_type, input_id->getIterType()); diff --git a/csrc/python_frontend/fusion_record.h b/csrc/python_frontend/fusion_record.h index 7f804e7e527..67980695701 100644 --- a/csrc/python_frontend/fusion_record.h +++ b/csrc/python_frontend/fusion_record.h @@ -817,10 +817,11 @@ struct BroadcastOpRecord : RecordFunctor { auto result = false; if (auto child_ptr = dynamic_cast(&other)) { result = RecordFunctor::operator==(other); - result &= std::equal( - is_broadcast_dim_.begin(), - is_broadcast_dim_.end(), - child_ptr->is_broadcast_dim_.begin()); + result = result && + std::equal( + is_broadcast_dim_.begin(), + is_broadcast_dim_.end(), + child_ptr->is_broadcast_dim_.begin()); } return result; }