From 9f14fb287375a5ac3e3590a454be14ff09f22202 Mon Sep 17 00:00:00 2001 From: Carlos Eduardo Arango Gutierrez Date: Thu, 17 Jul 2025 13:32:00 +0200 Subject: [PATCH] Fix NVDriver templating Signed-off-by: Carlos Eduardo Arango Gutierrez --- pkg/provisioner/templates/nv-driver.go | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/pkg/provisioner/templates/nv-driver.go b/pkg/provisioner/templates/nv-driver.go index 170754d92..5e4100223 100644 --- a/pkg/provisioner/templates/nv-driver.go +++ b/pkg/provisioner/templates/nv-driver.go @@ -24,6 +24,8 @@ import ( "github.com/NVIDIA/holodeck/api/holodeck/v1alpha1" ) +const defaultNVBranch = "575" + // From https://docs.nvidia.com/datacenter/tesla/tesla-installation-notes/index.html#ubuntu-lts const NvDriverTemplate = ` # Install Dependencies @@ -61,10 +63,14 @@ type NvDriver v1alpha1.NVIDIADriver func NewNvDriver(env v1alpha1.Environment) *NvDriver { var nvDriver NvDriver + // Propagate user-supplied settings nvDriver.Install = env.Spec.NVIDIADriver.Install + nvDriver.Branch = env.Spec.NVIDIADriver.Branch + nvDriver.Version = env.Spec.NVIDIADriver.Version - if env.Spec.NVIDIADriver.Branch == "" { - nvDriver.Branch = "575" + // Apply default branch only when neither a specific version nor a branch was provided + if nvDriver.Version == "" && nvDriver.Branch == "" { + nvDriver.Branch = defaultNVBranch } return &nvDriver