From d04fe89cdd724ad09f309119be80f82e3daace19 Mon Sep 17 00:00:00 2001 From: fatme Date: Fri, 25 May 2018 15:57:48 +0300 Subject: [PATCH] Make per platform appResourcesChanged check --- lib/services/project-changes-service.ts | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/lib/services/project-changes-service.ts b/lib/services/project-changes-service.ts index 4e21c90cbe..ff5c93bff1 100644 --- a/lib/services/project-changes-service.ts +++ b/lib/services/project-changes-service.ts @@ -66,7 +66,9 @@ export class ProjectChangesService implements IProjectChangesService { this._changesInfo.appFilesChanged = await this.hasChangedAppFiles(projectData); this._changesInfo.packageChanged = this.isProjectFileChanged(projectData, platform); - this._changesInfo.appResourcesChanged = this.containsNewerFiles(projectData.appResourcesDirectoryPath, null, projectData); + + const platformResourcesDir = path.join(projectData.appResourcesDirectoryPath, platformData.normalizedPlatformName); + this._changesInfo.appResourcesChanged = this.containsNewerFiles(platformResourcesDir, null, projectData); /*done because currently all node_modules are traversed, a possible improvement could be traversing only the production dependencies*/ this._changesInfo.nativeChanged = this.containsNewerFiles( path.join(projectData.projectDir, NODE_MODULES_FOLDER_NAME), @@ -77,7 +79,6 @@ export class ProjectChangesService implements IProjectChangesService { if (this._newFiles > 0 || this._changesInfo.nativeChanged) { this._changesInfo.modulesChanged = true; } - const platformResourcesDir = path.join(projectData.appResourcesDirectoryPath, platformData.normalizedPlatformName); if (platform === this.$devicePlatformsConstants.iOS.toLowerCase()) { this._changesInfo.configChanged = this.filesChanged([path.join(platformResourcesDir, platformData.configurationFileName), path.join(platformResourcesDir, "LaunchScreen.storyboard"),