From c11c6c74b641ff8c897995d494ba9b04d1218879 Mon Sep 17 00:00:00 2001
From: erwan-joly <erwan.joly+pro@gmail.com>
Date: Fri, 24 Apr 2026 17:27:28 +1200
Subject: [PATCH] feat!: migrate NetworkClient from Serilog.ILogger to
 Microsoft.Extensions.Logging.ILogger

BREAKING CHANGE: NetworkClient ctor now takes
Microsoft.Extensions.Logging.ILogger (non-generic) instead of
Serilog.ILogger. Derived classes can pass their ILogger<Derived>
directly because the generic variant extends the non-generic.
Bumps to 8.0.0.

Refs NosCoreIO/NosCore#1607.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
---
 src/NosCore.Networking/NetworkClient.cs          | 8 ++++----
 src/NosCore.Networking/NosCore.Networking.csproj | 2 +-
 2 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/NosCore.Networking/NetworkClient.cs b/src/NosCore.Networking/NetworkClient.cs
index ac91cc0..5a15e54 100644
--- a/src/NosCore.Networking/NetworkClient.cs
+++ b/src/NosCore.Networking/NetworkClient.cs
@@ -10,12 +10,12 @@
 using System.Linq;
 using System.Reflection;
 using System.Threading.Tasks;
+using Microsoft.Extensions.Logging;
 using NosCore.Networking.Encoding;
 using NosCore.Networking.Resource;
 using NosCore.Packets.Attributes;
 using NosCore.Packets.Interfaces;
 using NosCore.Shared.I18N;
-using Serilog;
 
 namespace NosCore.Networking
 {
@@ -92,7 +92,7 @@ public void RegisterChannel(IChannel channel)
         /// <returns>A task representing the asynchronous disconnect operation.</returns>
         public async Task DisconnectAsync()
         {
-            _logger.Information(_logLanguage[LogLanguageKey.FORCED_DISCONNECTION], SessionId);
+            _logger.LogInformation(_logLanguage[LogLanguageKey.FORCED_DISCONNECTION], SessionId);
             NetworkClientRegistry.Unregister(this);
             if (_channel != null)
             {
@@ -145,7 +145,7 @@ public async Task SendPacketsAsync(IEnumerable<IPacket?> packets)
                         }));
                         return $"{rendered}: {v.ErrorMessage ?? "validation failed"}";
                     }));
-                    _logger.Error(_logLanguage[LogLanguageKey.SENDING_INVALID_PACKET], header, packetType.FullName, errors);
+                    _logger.LogError(_logLanguage[LogLanguageKey.SENDING_INVALID_PACKET], header, packetType.FullName, errors);
                 }
                 LastPackets.Enqueue(packet);
             }
@@ -167,7 +167,7 @@ public async Task SendPacketsAsync(IEnumerable<IPacket?> packets)
             }
             catch (Exception ex)
             {
-                _logger.Warning(ex, _logLanguage[LogLanguageKey.ENCODE_ERROR], SessionId);
+                _logger.LogWarning(ex, _logLanguage[LogLanguageKey.ENCODE_ERROR], SessionId);
             }
         }
     }
diff --git a/src/NosCore.Networking/NosCore.Networking.csproj b/src/NosCore.Networking/NosCore.Networking.csproj
index ce41266..6fc4074 100644
--- a/src/NosCore.Networking/NosCore.Networking.csproj
+++ b/src/NosCore.Networking/NosCore.Networking.csproj
@@ -12,7 +12,7 @@
 		<RepositoryUrl>https://github.com/NosCoreIO/NosCore.Networking.git</RepositoryUrl>
 		<PackageIconUrl></PackageIconUrl>
 		<PackageTags>nostale, noscore, nostale private server source, nostale emulator</PackageTags>
-		<Version>7.2.0</Version>
+		<Version>8.0.0</Version>
 		<PackageRequireLicenseAcceptance>false</PackageRequireLicenseAcceptance>
 		<Description>NosCore Networking</Description>
 		<PackageLicenseExpression>MIT</PackageLicenseExpression>