From b16a1513192168fc5243c8e5548a7bc3fe80e58d Mon Sep 17 00:00:00 2001 From: shakedregev Date: Fri, 5 Sep 2025 08:57:31 -0400 Subject: [PATCH 1/4] fixed failing test by resetting workspace --- tests/unit/hykkt/runHykktCholeskyTests.cpp | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/unit/hykkt/runHykktCholeskyTests.cpp b/tests/unit/hykkt/runHykktCholeskyTests.cpp index 5ac493f0a..bd6bb5806 100644 --- a/tests/unit/hykkt/runHykktCholeskyTests.cpp +++ b/tests/unit/hykkt/runHykktCholeskyTests.cpp @@ -29,6 +29,8 @@ void runTests(const std::string& backend, ReSolve::memory::MemorySpace memspace, ReSolve::tests::HykktCholeskyTests test(memspace, handler); result += test.minimalCorrectness(); + handler.setValuesChanged(true, memspace); + workspace.resetLinAlgWorkspace(); for (int size : {3, 10, 100, 1000}) { From f23f42723c4732233bda6932d982bf8ae1c3a69d Mon Sep 17 00:00:00 2001 From: shakedregev Date: Fri, 5 Sep 2025 13:01:47 +0000 Subject: [PATCH 2/4] Apply pre-commmit fixes --- resolve/hykkt/cholesky/CholeskySolverHip.cpp | 16 ++++++++-------- resolve/hykkt/cholesky/CholeskySolverHip.hpp | 4 ++-- 2 files changed, 10 insertions(+), 10 deletions(-) diff --git a/resolve/hykkt/cholesky/CholeskySolverHip.cpp b/resolve/hykkt/cholesky/CholeskySolverHip.cpp index 0b7601c20..d03eaf8b0 100644 --- a/resolve/hykkt/cholesky/CholeskySolverHip.cpp +++ b/resolve/hykkt/cholesky/CholeskySolverHip.cpp @@ -109,10 +109,10 @@ namespace ReSolve mem_.allocateArrayOnDevice(&Q_, A_->getNumRows()); mem_.copyArrayHostToDevice(Q_, static_cast(factorization_->Perm), A_->getNumRows()); - //tmp rhs for analysis + // tmp rhs for analysis mem_.allocateArrayOnDevice(&rhs_tmp_, A_->getNumColumns()); mem_.setArrayToConstOnHost(rhs_tmp_, 1.0, A_->getNumColumns()); - + // Store analysis in rfinfo_ rocblas_status status = rocsolver_dcsrrf_analysis(handle_, A_->getNumRows(), @@ -130,12 +130,12 @@ namespace ReSolve rhs_tmp_, A_->getNumRows(), rfinfo_); - mem_.deleteOnDevice(rhs_tmp_); - rhs_tmp_ = nullptr; - if (status != rocblas_status_success) - { - out::error() << "Analysis step failed with status: " << status << "\n"; - } + mem_.deleteOnDevice(rhs_tmp_); + rhs_tmp_ = nullptr; + if (status != rocblas_status_success) + { + out::error() << "Analysis step failed with status: " << status << "\n"; + } } else // re-factorize { diff --git a/resolve/hykkt/cholesky/CholeskySolverHip.hpp b/resolve/hykkt/cholesky/CholeskySolverHip.hpp index 166fa3bb0..3661bcaa6 100644 --- a/resolve/hykkt/cholesky/CholeskySolverHip.hpp +++ b/resolve/hykkt/cholesky/CholeskySolverHip.hpp @@ -39,8 +39,8 @@ namespace ReSolve matrix::Csr* L_; index_type* Q_; - real_type* rhs_tmp_;// used during analysis - + real_type* rhs_tmp_; // used during analysis + cholmod_sparse* convertToCholmod(matrix::Csr* A); }; } // namespace hykkt From b92c4c02a2026f7e07f3be08190ba5aef5bd55fc Mon Sep 17 00:00:00 2001 From: Shaked Regev <35384901+shakedregev@users.noreply.github.com> Date: Fri, 5 Sep 2025 09:05:04 -0400 Subject: [PATCH 3/4] Update tests/unit/hykkt/runHykktCholeskyTests.cpp --- tests/unit/hykkt/runHykktCholeskyTests.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/unit/hykkt/runHykktCholeskyTests.cpp b/tests/unit/hykkt/runHykktCholeskyTests.cpp index bd6bb5806..fdcdbdec6 100644 --- a/tests/unit/hykkt/runHykktCholeskyTests.cpp +++ b/tests/unit/hykkt/runHykktCholeskyTests.cpp @@ -30,7 +30,7 @@ void runTests(const std::string& backend, ReSolve::memory::MemorySpace memspace, result += test.minimalCorrectness(); handler.setValuesChanged(true, memspace); - workspace.resetLinAlgWorkspace(); + workspace.resetLinAlgWorkspace(); //reset is necessary due to different sparsity. for (int size : {3, 10, 100, 1000}) { From 3b5fc07ead57de368dda7ed4fe969da26fb21eda Mon Sep 17 00:00:00 2001 From: shakedregev Date: Fri, 5 Sep 2025 13:05:28 +0000 Subject: [PATCH 4/4] Apply pre-commmit fixes --- tests/unit/hykkt/runHykktCholeskyTests.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/unit/hykkt/runHykktCholeskyTests.cpp b/tests/unit/hykkt/runHykktCholeskyTests.cpp index fdcdbdec6..f350dc738 100644 --- a/tests/unit/hykkt/runHykktCholeskyTests.cpp +++ b/tests/unit/hykkt/runHykktCholeskyTests.cpp @@ -30,7 +30,7 @@ void runTests(const std::string& backend, ReSolve::memory::MemorySpace memspace, result += test.minimalCorrectness(); handler.setValuesChanged(true, memspace); - workspace.resetLinAlgWorkspace(); //reset is necessary due to different sparsity. + workspace.resetLinAlgWorkspace(); // reset is necessary due to different sparsity. for (int size : {3, 10, 100, 1000}) {