From 0638015d380f32c6bbe986ca3fdeb892459c12a8 Mon Sep 17 00:00:00 2001 From: Josh Kasten Date: Mon, 4 Mar 2024 19:59:09 -0500 Subject: [PATCH] rm refresh User on login of same external_id We already refresh when the app is cold started, so this results in two GET calls back-to-back for apps that call login every time the app is opened the by the user. We are still refreshing the user if switch user happens. Didn't add any unit test since there is no existing test infrastructure to test code in OneSignalImp. Also such code should be refactored out into a different class to make it more testable anyway. --- .../src/main/java/com/onesignal/internal/OneSignalImp.kt | 9 --------- 1 file changed, 9 deletions(-) diff --git a/OneSignalSDK/onesignal/core/src/main/java/com/onesignal/internal/OneSignalImp.kt b/OneSignalSDK/onesignal/core/src/main/java/com/onesignal/internal/OneSignalImp.kt index 5cc217e6e4..53877bf80b 100644 --- a/OneSignalSDK/onesignal/core/src/main/java/com/onesignal/internal/OneSignalImp.kt +++ b/OneSignalSDK/onesignal/core/src/main/java/com/onesignal/internal/OneSignalImp.kt @@ -359,15 +359,6 @@ internal class OneSignalImp : IOneSignal, IServiceProvider { currentIdentityOneSignalId = identityModelStore!!.model.onesignalId if (currentIdentityExternalId == externalId) { - // login is for same user that is already logged in, fetch (refresh) - // the current user. - operationRepo!!.enqueue( - RefreshUserOperation( - configModel!!.appId, - identityModelStore!!.model.onesignalId, - ), - true, - ) return }