From ef3758ba5060112c01f38fd0c4059782f45a7a87 Mon Sep 17 00:00:00 2001 From: Josh Kasten Date: Sun, 14 Apr 2024 18:09:27 -0400 Subject: [PATCH] never set OperationRepo.enqueue's flush to true OneSignal.login() was setting OperationRepo.enqueue to true, while this means the OneSignal backend is updated up to 5 seconds faster it means a possible increase in load, as not having a delay means we may not have batched as many network requests. There is a high chance we will re-introduce the flush via a new public commit() method, so it wasn't remove in this commit. But before doing so we need budget rules so it can't be abused. One oddly I notice here is the login had a flush, but the logout did not. This seems like a bug, but either way we don't want to flush anywhere now. --- .../onesignal/core/internal/operations/impl/OperationRepo.kt | 1 + .../core/src/main/java/com/onesignal/internal/OneSignalImp.kt | 2 -- .../user/internal/migrations/RecoverFromDroppedLoginBug.kt | 1 - 3 files changed, 1 insertion(+), 3 deletions(-) diff --git a/OneSignalSDK/onesignal/core/src/main/java/com/onesignal/core/internal/operations/impl/OperationRepo.kt b/OneSignalSDK/onesignal/core/src/main/java/com/onesignal/core/internal/operations/impl/OperationRepo.kt index c0f646af6a..e94de1be20 100644 --- a/OneSignalSDK/onesignal/core/src/main/java/com/onesignal/core/internal/operations/impl/OperationRepo.kt +++ b/OneSignalSDK/onesignal/core/src/main/java/com/onesignal/core/internal/operations/impl/OperationRepo.kt @@ -110,6 +110,7 @@ internal class OperationRepo( return waiter.waitForWake() } + // WARNING: Never set to true, until budget rules are added, even for internal use! private fun internalEnqueue( queueItem: OperationQueueItem, flush: Boolean, diff --git a/OneSignalSDK/onesignal/core/src/main/java/com/onesignal/internal/OneSignalImp.kt b/OneSignalSDK/onesignal/core/src/main/java/com/onesignal/internal/OneSignalImp.kt index 15fa601abb..67b0befc8a 100644 --- a/OneSignalSDK/onesignal/core/src/main/java/com/onesignal/internal/OneSignalImp.kt +++ b/OneSignalSDK/onesignal/core/src/main/java/com/onesignal/internal/OneSignalImp.kt @@ -380,7 +380,6 @@ internal class OneSignalImp : IOneSignal, IServiceProvider { externalId, if (currentIdentityExternalId == null) currentIdentityOneSignalId else null, ), - true, ) if (!result) { @@ -395,7 +394,6 @@ internal class OneSignalImp : IOneSignal, IServiceProvider { configModel!!.appId, identityModelStore!!.model.onesignalId, ), - true, ) } } diff --git a/OneSignalSDK/onesignal/core/src/main/java/com/onesignal/user/internal/migrations/RecoverFromDroppedLoginBug.kt b/OneSignalSDK/onesignal/core/src/main/java/com/onesignal/user/internal/migrations/RecoverFromDroppedLoginBug.kt index 573a72f29a..e0aab13cdf 100644 --- a/OneSignalSDK/onesignal/core/src/main/java/com/onesignal/user/internal/migrations/RecoverFromDroppedLoginBug.kt +++ b/OneSignalSDK/onesignal/core/src/main/java/com/onesignal/user/internal/migrations/RecoverFromDroppedLoginBug.kt @@ -79,7 +79,6 @@ class RecoverFromDroppedLoginBug( _identityModelStore.model.externalId, null, ), - true, ) } }