From ef3b9c7cc3ef392ad862edfb375e03134a58a0da Mon Sep 17 00:00:00 2001 From: Doris Lam Date: Fri, 31 Mar 2023 14:05:28 -0700 Subject: [PATCH] fixes #238 elasticsearch scroll --- .../mms/elastic/services/ElasticSearchService.java | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/elastic/src/main/java/org/openmbee/mms/elastic/services/ElasticSearchService.java b/elastic/src/main/java/org/openmbee/mms/elastic/services/ElasticSearchService.java index 13b8798c2..74bb12b70 100644 --- a/elastic/src/main/java/org/openmbee/mms/elastic/services/ElasticSearchService.java +++ b/elastic/src/main/java/org/openmbee/mms/elastic/services/ElasticSearchService.java @@ -209,20 +209,20 @@ private List performElasticQuery(Set allNodeDocIds, SearchR sourceBuilder.query(query); sourceBuilder.size(resultLimit); searchRequest.source(sourceBuilder); - searchRequest.scroll(TimeValue.timeValueMillis(scrollTimeout)); + searchRequest.scroll(TimeValue.timeValueSeconds(scrollTimeout)); SearchResponse searchResponse = client.search(searchRequest, RequestOptions.DEFAULT); String scrollId = null; - do { - for(SearchHit hit : searchResponse.getHits()) { + for (SearchHit hit : searchResponse.getHits()) { ElementJson ob = parseResult(hit); - if(allNodeDocIds.contains(ob.getDocId())) { + if (allNodeDocIds.contains(ob.getDocId())) { result.add(ob); } } scrollId = searchResponse.getScrollId(); if (scrollId != null) { SearchScrollRequest scrollRequest = new SearchScrollRequest(scrollId); + scrollRequest.scroll(TimeValue.timeValueSeconds(scrollTimeout)); searchResponse = client.scroll(scrollRequest, RequestOptions.DEFAULT); } @@ -255,8 +255,6 @@ private Collection> filterIndexedElementsUsingDatabas } else if(showDeletedAsRejected) { deletedElements.add(new OrderedResult<>(new Rejection(currentJson.getWrapped(), 410, SearchConstants.ELEMENT_DELETED_INFO), currentJson.getOrder())); } - } else { // node found in DB not found in the index - logger.warn(SearchConstants.POSSIBLE_ELASTIC_DISCREPANCY, n.getNodeId()); } }