From c43557be1a08f70d9a4b984af16980fdb413efe0 Mon Sep 17 00:00:00 2001 From: ParakhMittal <69970521+ParakhMittal@users.noreply.github.com> Date: Thu, 20 Aug 2020 20:16:30 +0530 Subject: [PATCH 1/2] Update apiInvoker.mustache In scala-akka-client code that is getting generated, addAuthentication method is called after setting headers using header parameter in the below mentioned line addAuthentication(request.credentials)( httpRequest.withHeaders(headers(request.headerParams)) ) However, in addAuthentication method, we are using withHeaders method that overwrites the headers set using header parameters. So, I am proposing to change the addAuthentication method be replacing withHeaders() method to addHeader() to add authentication header to the list of already existing headers. --- .../main/resources/scala-akka-client/apiInvoker.mustache | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/modules/openapi-generator/src/main/resources/scala-akka-client/apiInvoker.mustache b/modules/openapi-generator/src/main/resources/scala-akka-client/apiInvoker.mustache index 5999fe098214..8c81b0b2d8b5 100644 --- a/modules/openapi-generator/src/main/resources/scala-akka-client/apiInvoker.mustache +++ b/modules/openapi-generator/src/main/resources/scala-akka-client/apiInvoker.mustache @@ -103,11 +103,11 @@ class ApiInvoker(formats: Formats)(implicit system: ActorSystem) extends CustomC request: HttpRequest => credentialsSeq.foldLeft(request) { case (req, BasicCredentials(login, password)) => - req.withHeaders(Authorization(BasicHttpCredentials(login, password))) + req.addHeader(Authorization(BasicHttpCredentials(login, password))) case (req, ApiKeyCredentials(keyValue, keyName, ApiKeyLocations.HEADER)) => - req.withHeaders(RawHeader(keyName, keyValue.value)) + req.addHeader(RawHeader(keyName, keyValue.value)) case (req, BearerToken(token)) => - req.withHeaders(RawHeader("Authorization", s"Bearer $token")) + req.addHeader(RawHeader("Authorization", s"Bearer $token")) case (req, _) => req } } From 04e3357d6a06a79abf2ad4868908b2d343e0f3a6 Mon Sep 17 00:00:00 2001 From: ParakhMittal <69970521+ParakhMittal@users.noreply.github.com> Date: Thu, 20 Aug 2020 20:47:07 +0530 Subject: [PATCH 2/2] Update ApiInvoker.scala Added changes to sample for the client generator code change --- .../scala/org/openapitools/client/core/ApiInvoker.scala | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/samples/client/petstore/scala-akka/src/main/scala/org/openapitools/client/core/ApiInvoker.scala b/samples/client/petstore/scala-akka/src/main/scala/org/openapitools/client/core/ApiInvoker.scala index 3e6c1dbeb442..d3ff4cadb8ec 100644 --- a/samples/client/petstore/scala-akka/src/main/scala/org/openapitools/client/core/ApiInvoker.scala +++ b/samples/client/petstore/scala-akka/src/main/scala/org/openapitools/client/core/ApiInvoker.scala @@ -113,11 +113,11 @@ class ApiInvoker(formats: Formats)(implicit system: ActorSystem) extends CustomC request: HttpRequest => credentialsSeq.foldLeft(request) { case (req, BasicCredentials(login, password)) => - req.withHeaders(Authorization(BasicHttpCredentials(login, password))) + req.addHeader(Authorization(BasicHttpCredentials(login, password))) case (req, ApiKeyCredentials(keyValue, keyName, ApiKeyLocations.HEADER)) => - req.withHeaders(RawHeader(keyName, keyValue.value)) + req.addHeader(RawHeader(keyName, keyValue.value)) case (req, BearerToken(token)) => - req.withHeaders(RawHeader("Authorization", s"Bearer $token")) + req.addHeader(RawHeader("Authorization", s"Bearer $token")) case (req, _) => req } }