From 20e908c2ec2881e60fe51f89307ce9bed7382d95 Mon Sep 17 00:00:00 2001 From: Mike Henry <11765982+mikemhenry@users.noreply.github.com> Date: Fri, 28 Feb 2025 13:59:51 -0700 Subject: [PATCH 01/24] test larger cpu runner --- .github/workflows/cpu-runner.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/cpu-runner.yaml b/.github/workflows/cpu-runner.yaml index 67c698b1a..b173102d7 100644 --- a/.github/workflows/cpu-runner.yaml +++ b/.github/workflows/cpu-runner.yaml @@ -23,7 +23,7 @@ jobs: provider: "aws" action: "start" aws_image_id: ami-0b7f661c228e6a4bb - aws_instance_type: t3a.small # TODO try t3a.medium next + aws_instance_type: t3a.medium # TODO try t3a.medium next aws_region_name: us-east-2 aws_home_dir: /home/ubuntu env: From 778e73585d74ef2175d1e68787fa7f204a0f5356 Mon Sep 17 00:00:00 2001 From: Mike Henry <11765982+mikemhenry@users.noreply.github.com> Date: Fri, 28 Feb 2025 14:01:56 -0700 Subject: [PATCH 02/24] update omsf runner version --- .github/workflows/cpu-runner.yaml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/cpu-runner.yaml b/.github/workflows/cpu-runner.yaml index b173102d7..e0f368595 100644 --- a/.github/workflows/cpu-runner.yaml +++ b/.github/workflows/cpu-runner.yaml @@ -18,7 +18,7 @@ jobs: aws-region: us-east-2 - name: Create cloud runner id: aws-start - uses: omsf-eco-infra/gha-runner@v0.2.0 + uses: omsf-eco-infra/gha-runner@v0.4.0 with: provider: "aws" action: "start" @@ -114,7 +114,7 @@ jobs: role-to-assume: arn:aws:iam::010438489691:role/GHARunnerAWS aws-region: us-east-2 - name: Stop instances - uses: omsf-eco-infra/gha-runner@v0.2.0 + uses: omsf-eco-infra/gha-runner@v0.4.0 with: provider: "aws" action: "stop" From bee83676903d53e65c2754e6e1eae27ec3d630b5 Mon Sep 17 00:00:00 2001 From: Mike Henry <11765982+mikemhenry@users.noreply.github.com> Date: Fri, 28 Feb 2025 15:29:57 -0700 Subject: [PATCH 03/24] nvidia-smi throws an error if there is no GPU --- .github/workflows/cpu-runner.yaml | 3 --- 1 file changed, 3 deletions(-) diff --git a/.github/workflows/cpu-runner.yaml b/.github/workflows/cpu-runner.yaml index e0f368595..45f094a0d 100644 --- a/.github/workflows/cpu-runner.yaml +++ b/.github/workflows/cpu-runner.yaml @@ -49,9 +49,6 @@ jobs: - name: Print Docker details run: "docker version || true" - - name: Check for nvidia-smi - run: "nvidia-smi" - - name: "Setup Micromamba" uses: mamba-org/setup-micromamba@v2 with: From 973201d7bedaed4b3c9591cd381877ef7b9bc737 Mon Sep 17 00:00:00 2001 From: Mike Henry <11765982+mikemhenry@users.noreply.github.com> Date: Tue, 4 Mar 2025 14:37:56 -0700 Subject: [PATCH 04/24] Try a large --- .github/workflows/cpu-runner.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/cpu-runner.yaml b/.github/workflows/cpu-runner.yaml index 45f094a0d..1719efcde 100644 --- a/.github/workflows/cpu-runner.yaml +++ b/.github/workflows/cpu-runner.yaml @@ -23,7 +23,7 @@ jobs: provider: "aws" action: "start" aws_image_id: ami-0b7f661c228e6a4bb - aws_instance_type: t3a.medium # TODO try t3a.medium next + aws_instance_type: t3a.large # TODO try t3a.xlarge next aws_region_name: us-east-2 aws_home_dir: /home/ubuntu env: From 98cec71d28a0bed61d3ffbe433447ad0c66d31d6 Mon Sep 17 00:00:00 2001 From: Mike Henry <11765982+mikemhenry@users.noreply.github.com> Date: Wed, 5 Mar 2025 09:31:44 -0700 Subject: [PATCH 05/24] just run slow tets --- .github/workflows/cpu-runner.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/cpu-runner.yaml b/.github/workflows/cpu-runner.yaml index 1719efcde..0d2a4f3e8 100644 --- a/.github/workflows/cpu-runner.yaml +++ b/.github/workflows/cpu-runner.yaml @@ -91,7 +91,7 @@ jobs: # Set the OFE_SLOW_TESTS to True if running a Cron job OFE_SLOW_TESTS: "true" DUECREDIT_ENABLE: 'yes' - OFE_INTEGRATION_TESTS: TRUE + OFE_INTEGRATION_TESTS: FALSE run: | pytest -n logical -vv --durations=10 From 6f6b35ca349cd09c7f14708f66a01eea4eecc1bf Mon Sep 17 00:00:00 2001 From: Mike Henry <11765982+mikemhenry@users.noreply.github.com> Date: Mon, 10 Mar 2025 13:07:31 -0700 Subject: [PATCH 06/24] try xlarge (should fail but thats okay) --- .github/workflows/cpu-runner.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/cpu-runner.yaml b/.github/workflows/cpu-runner.yaml index 0d2a4f3e8..69098a53d 100644 --- a/.github/workflows/cpu-runner.yaml +++ b/.github/workflows/cpu-runner.yaml @@ -23,7 +23,7 @@ jobs: provider: "aws" action: "start" aws_image_id: ami-0b7f661c228e6a4bb - aws_instance_type: t3a.large # TODO try t3a.xlarge next + aws_instance_type: t3a.xlarge # TODO try t3a.xlarge next aws_region_name: us-east-2 aws_home_dir: /home/ubuntu env: From 5c392d2e0c831ec8b184344f6363c18d61d98d33 Mon Sep 17 00:00:00 2001 From: Mike Henry <11765982+mikemhenry@users.noreply.github.com> Date: Wed, 12 Mar 2025 16:11:15 -0700 Subject: [PATCH 07/24] lets see if the intel flavor is any faster --- .github/workflows/cpu-runner.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/cpu-runner.yaml b/.github/workflows/cpu-runner.yaml index 69098a53d..b4ad20000 100644 --- a/.github/workflows/cpu-runner.yaml +++ b/.github/workflows/cpu-runner.yaml @@ -23,7 +23,7 @@ jobs: provider: "aws" action: "start" aws_image_id: ami-0b7f661c228e6a4bb - aws_instance_type: t3a.xlarge # TODO try t3a.xlarge next + aws_instance_type: t3.xlarge aws_region_name: us-east-2 aws_home_dir: /home/ubuntu env: From 25ac23e31ed7f2e6fc806426ce410ef0d8ab5878 Mon Sep 17 00:00:00 2001 From: Mike Henry <11765982+mikemhenry@users.noreply.github.com> Date: Thu, 13 Mar 2025 16:02:16 -0700 Subject: [PATCH 08/24] see if this changes the runtime at all --- .github/workflows/cpu-runner.yaml | 2 -- 1 file changed, 2 deletions(-) diff --git a/.github/workflows/cpu-runner.yaml b/.github/workflows/cpu-runner.yaml index b4ad20000..9f48ecf26 100644 --- a/.github/workflows/cpu-runner.yaml +++ b/.github/workflows/cpu-runner.yaml @@ -88,10 +88,8 @@ jobs: - name: "Run tests" env: - # Set the OFE_SLOW_TESTS to True if running a Cron job OFE_SLOW_TESTS: "true" DUECREDIT_ENABLE: 'yes' - OFE_INTEGRATION_TESTS: FALSE run: | pytest -n logical -vv --durations=10 From ababe63df68d4c0bae8ef3d966451feec996b900 Mon Sep 17 00:00:00 2001 From: Mike Henry <11765982+mikemhenry@users.noreply.github.com> Date: Thu, 13 Mar 2025 16:02:50 -0700 Subject: [PATCH 09/24] go back to working runner instance type --- .github/workflows/cpu-runner.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/cpu-runner.yaml b/.github/workflows/cpu-runner.yaml index 9f48ecf26..127e6f7eb 100644 --- a/.github/workflows/cpu-runner.yaml +++ b/.github/workflows/cpu-runner.yaml @@ -23,7 +23,7 @@ jobs: provider: "aws" action: "start" aws_image_id: ami-0b7f661c228e6a4bb - aws_instance_type: t3.xlarge + aws_instance_type: t3a.xlarge aws_region_name: us-east-2 aws_home_dir: /home/ubuntu env: From df35dbc628983431c452a5164c7730e30dae4b2b Mon Sep 17 00:00:00 2001 From: Mike Henry <11765982+mikemhenry@users.noreply.github.com> Date: Mon, 24 Mar 2025 13:06:17 -0700 Subject: [PATCH 10/24] bump size of disk --- .github/workflows/cpu-runner.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/cpu-runner.yaml b/.github/workflows/cpu-runner.yaml index 19927a46f..00d5ea20a 100644 --- a/.github/workflows/cpu-runner.yaml +++ b/.github/workflows/cpu-runner.yaml @@ -23,6 +23,7 @@ jobs: aws_image_id: ami-0b7f661c228e6a4bb aws_instance_type: t3a.xlarge aws_home_dir: /home/ubuntu + aws_root_device_size: 125 env: GH_PAT: ${{ secrets.GH_PAT }} From fd952aede41e780fec9415f47651890679b972fd Mon Sep 17 00:00:00 2001 From: Mike Henry <11765982+mikemhenry@users.noreply.github.com> Date: Tue, 27 May 2025 14:58:07 -0700 Subject: [PATCH 11/24] check time on a t3 med --- .github/workflows/cpu-runner.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/cpu-runner.yaml b/.github/workflows/cpu-runner.yaml index 00d5ea20a..3e01e2938 100644 --- a/.github/workflows/cpu-runner.yaml +++ b/.github/workflows/cpu-runner.yaml @@ -21,7 +21,7 @@ jobs: uses: omsf/start-aws-gha-runner@v1.0.0 with: aws_image_id: ami-0b7f661c228e6a4bb - aws_instance_type: t3a.xlarge + aws_instance_type: t3.medium aws_home_dir: /home/ubuntu aws_root_device_size: 125 env: From 66d008da51aad49ef98cbad8286385d187718aa2 Mon Sep 17 00:00:00 2001 From: Mike Henry <11765982+mikemhenry@users.noreply.github.com> Date: Wed, 28 May 2025 11:49:56 -0700 Subject: [PATCH 12/24] try xlarge --- .github/workflows/cpu-runner.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/cpu-runner.yaml b/.github/workflows/cpu-runner.yaml index 3e01e2938..cded1af36 100644 --- a/.github/workflows/cpu-runner.yaml +++ b/.github/workflows/cpu-runner.yaml @@ -21,7 +21,7 @@ jobs: uses: omsf/start-aws-gha-runner@v1.0.0 with: aws_image_id: ami-0b7f661c228e6a4bb - aws_instance_type: t3.medium + aws_instance_type: t3.xlarge aws_home_dir: /home/ubuntu aws_root_device_size: 125 env: From 04fbd293cf149028bfefaf6e9d439f0ee6581157 Mon Sep 17 00:00:00 2001 From: Mike Henry <11765982+mikemhenry@users.noreply.github.com> Date: Wed, 28 May 2025 11:50:52 -0700 Subject: [PATCH 13/24] try t3a.xlarge --- .github/workflows/cpu-runner.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/cpu-runner.yaml b/.github/workflows/cpu-runner.yaml index cded1af36..00d5ea20a 100644 --- a/.github/workflows/cpu-runner.yaml +++ b/.github/workflows/cpu-runner.yaml @@ -21,7 +21,7 @@ jobs: uses: omsf/start-aws-gha-runner@v1.0.0 with: aws_image_id: ami-0b7f661c228e6a4bb - aws_instance_type: t3.xlarge + aws_instance_type: t3a.xlarge aws_home_dir: /home/ubuntu aws_root_device_size: 125 env: From 10c637d91ebeca30ae4b7eaaa548167988c1a871 Mon Sep 17 00:00:00 2001 From: Mike Henry <11765982+mikemhenry@users.noreply.github.com> Date: Wed, 28 May 2025 11:51:27 -0700 Subject: [PATCH 14/24] now t3a.2xl --- .github/workflows/cpu-runner.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/cpu-runner.yaml b/.github/workflows/cpu-runner.yaml index 00d5ea20a..c0c3af033 100644 --- a/.github/workflows/cpu-runner.yaml +++ b/.github/workflows/cpu-runner.yaml @@ -21,7 +21,7 @@ jobs: uses: omsf/start-aws-gha-runner@v1.0.0 with: aws_image_id: ami-0b7f661c228e6a4bb - aws_instance_type: t3a.xlarge + aws_instance_type: t3a.2xlarge aws_home_dir: /home/ubuntu aws_root_device_size: 125 env: From 7a44864117d45f7f690fdcf811e424a16575583e Mon Sep 17 00:00:00 2001 From: Mike Henry <11765982+mikemhenry@users.noreply.github.com> Date: Wed, 28 May 2025 11:51:57 -0700 Subject: [PATCH 15/24] now t3.2xl --- .github/workflows/cpu-runner.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/cpu-runner.yaml b/.github/workflows/cpu-runner.yaml index c0c3af033..e4a82a986 100644 --- a/.github/workflows/cpu-runner.yaml +++ b/.github/workflows/cpu-runner.yaml @@ -21,7 +21,7 @@ jobs: uses: omsf/start-aws-gha-runner@v1.0.0 with: aws_image_id: ami-0b7f661c228e6a4bb - aws_instance_type: t3a.2xlarge + aws_instance_type: t3.2xlarge aws_home_dir: /home/ubuntu aws_root_device_size: 125 env: From 2bc498f0f11e8e21ad2000b73064c874e128a18d Mon Sep 17 00:00:00 2001 From: Mike Henry <11765982+mikemhenry@users.noreply.github.com> Date: Thu, 29 May 2025 13:34:33 -0700 Subject: [PATCH 16/24] use platforms that actually will work --- openfe/tests/protocols/conftest.py | 30 ++++++++++++++++++- .../tests/protocols/test_openmm_afe_slow.py | 9 ++---- .../tests/protocols/test_openmm_rfe_slow.py | 9 ++---- 3 files changed, 33 insertions(+), 15 deletions(-) diff --git a/openfe/tests/protocols/conftest.py b/openfe/tests/protocols/conftest.py index 67cc21d1c..2f340db9e 100644 --- a/openfe/tests/protocols/conftest.py +++ b/openfe/tests/protocols/conftest.py @@ -214,7 +214,7 @@ def afe_solv_transformation_json() -> str: """ d = resources.files('openfe.tests.data.openmm_afe') fname = "AHFEProtocol_json_results.gz" - + with gzip.open((d / fname).as_posix(), 'r') as f: # type: ignore return f.read().decode() # type: ignore @@ -231,3 +231,31 @@ def md_json() -> str: with gzip.open((d / fname).as_posix(), 'r') as f: # type: ignore return f.read().decode() # type: ignore + +@pytest.fixture +def get_available_openmm_platforms() -> set[str]: + """ + OpenMM Platforms that are available and functional on system + """ + import openmm + from openmm import Platform + # Get platforms that openmm was built with + platforms = {Platform.getPlatform(i).getName() for i in range(Platform.getNumPlatforms())} + + # Now check if we can actually use the platforms + working_platforms = {} + for platform in platforms: + system = openmm.System() + system.addParticle(1.0) + integrator = openmm.VerletIntegrator(0.001) + try: + context = openmm.Context(system, integrator, Platform.getPlatformByName(platform)) + working_platforms.add(platform) + del context + except openmm.OpenMMException: + continue + finally: + del system, integrator + + + return working_platforms diff --git a/openfe/tests/protocols/test_openmm_afe_slow.py b/openfe/tests/protocols/test_openmm_afe_slow.py index 37b5b83aa..e985dd048 100644 --- a/openfe/tests/protocols/test_openmm_afe_slow.py +++ b/openfe/tests/protocols/test_openmm_afe_slow.py @@ -12,11 +12,6 @@ from openfe.protocols import openmm_afe -@pytest.fixture -def available_platforms() -> set[str]: - return {Platform.getPlatform(i).getName() for i in range(Platform.getNumPlatforms())} - - @pytest.fixture def set_openmm_threads_1(): # for vacuum sims, we want to limit threads to one @@ -37,10 +32,10 @@ def set_openmm_threads_1(): @pytest.mark.flaky(reruns=3) # pytest-rerunfailures; we can get bad minimisation @pytest.mark.parametrize('platform', ['CPU', 'CUDA']) def test_openmm_run_engine(platform, - available_platforms, + get_available_openmm_platforms, benzene_modifications, set_openmm_threads_1, tmpdir): - if platform not in available_platforms: + if platform not in get_available_openmm_platforms: pytest.skip(f"OpenMM Platform: {platform} not available") # Run a really short calculation to check everything is going well diff --git a/openfe/tests/protocols/test_openmm_rfe_slow.py b/openfe/tests/protocols/test_openmm_rfe_slow.py index f0fe5a0a7..78e02a560 100644 --- a/openfe/tests/protocols/test_openmm_rfe_slow.py +++ b/openfe/tests/protocols/test_openmm_rfe_slow.py @@ -13,11 +13,6 @@ from openfe.protocols import openmm_rfe -@pytest.fixture -def available_platforms() -> set[str]: - return {Platform.getPlatform(i).getName() for i in range(Platform.getNumPlatforms())} - - @pytest.fixture def set_openmm_threads_1(): # for vacuum sims, we want to limit threads to one @@ -38,9 +33,9 @@ def set_openmm_threads_1(): @pytest.mark.flaky(reruns=3) # pytest-rerunfailures; we can get bad minimisation @pytest.mark.parametrize('platform', ['CPU', 'CUDA']) def test_openmm_run_engine(benzene_vacuum_system, platform, - available_platforms, benzene_modifications, + get_available_openmm_platforms, benzene_modifications, set_openmm_threads_1, tmpdir): - if platform not in available_platforms: + if platform not in get_available_openmm_platforms: pytest.skip(f"OpenMM Platform: {platform} not available") # this test actually runs MD # these settings are a small self to self sim, that has enough eq that From fc67eabcad769db1864b485fa5e3f151337c3500 Mon Sep 17 00:00:00 2001 From: Mike Henry <11765982+mikemhenry@users.noreply.github.com> Date: Thu, 29 May 2025 13:36:51 -0700 Subject: [PATCH 17/24] need empty set not dict --- openfe/tests/protocols/conftest.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/openfe/tests/protocols/conftest.py b/openfe/tests/protocols/conftest.py index 2f340db9e..961ffd7b3 100644 --- a/openfe/tests/protocols/conftest.py +++ b/openfe/tests/protocols/conftest.py @@ -243,7 +243,7 @@ def get_available_openmm_platforms() -> set[str]: platforms = {Platform.getPlatform(i).getName() for i in range(Platform.getNumPlatforms())} # Now check if we can actually use the platforms - working_platforms = {} + working_platforms = set() for platform in platforms: system = openmm.System() system.addParticle(1.0) From 9bdfaec837c6864fa125fb2fe612a83717da59d8 Mon Sep 17 00:00:00 2001 From: Mike Henry <11765982+mikemhenry@users.noreply.github.com> Date: Thu, 29 May 2025 14:01:25 -0700 Subject: [PATCH 18/24] pin buggy mypy --- .github/workflows/mypy.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/mypy.yaml b/.github/workflows/mypy.yaml index c05de15c4..1ef99dc4a 100644 --- a/.github/workflows/mypy.yaml +++ b/.github/workflows/mypy.yaml @@ -43,7 +43,7 @@ jobs: - name: "Install steps" run: | python -m pip install --no-deps git+https://github.com/OpenFreeEnergy/gufe@main - python -m pip install mypy + python -m pip install mypy < 1.16.0 python -m pip install types-setuptools python -m pip install --no-deps -e . From 8d17990ad0e11de7d3e1f503bca5d3fdbe58386b Mon Sep 17 00:00:00 2001 From: Mike Henry <11765982+mikemhenry@users.noreply.github.com> Date: Thu, 29 May 2025 14:14:41 -0700 Subject: [PATCH 19/24] fix mypy pin --- .github/workflows/mypy.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/mypy.yaml b/.github/workflows/mypy.yaml index 1ef99dc4a..12ce3971f 100644 --- a/.github/workflows/mypy.yaml +++ b/.github/workflows/mypy.yaml @@ -43,7 +43,7 @@ jobs: - name: "Install steps" run: | python -m pip install --no-deps git+https://github.com/OpenFreeEnergy/gufe@main - python -m pip install mypy < 1.16.0 + python -m pip install "mypy<1.16.0" python -m pip install types-setuptools python -m pip install --no-deps -e . From 12895e54c0354c6bf7d3e328f4bdb352787f4d90 Mon Sep 17 00:00:00 2001 From: Mike Henry <11765982+mikemhenry@users.noreply.github.com> Date: Thu, 29 May 2025 15:42:17 -0700 Subject: [PATCH 20/24] see if large works --- .github/workflows/cpu-runner.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/cpu-runner.yaml b/.github/workflows/cpu-runner.yaml index e4a82a986..61fcd575b 100644 --- a/.github/workflows/cpu-runner.yaml +++ b/.github/workflows/cpu-runner.yaml @@ -21,7 +21,7 @@ jobs: uses: omsf/start-aws-gha-runner@v1.0.0 with: aws_image_id: ami-0b7f661c228e6a4bb - aws_instance_type: t3.2xlarge + aws_instance_type: t3a.large aws_home_dir: /home/ubuntu aws_root_device_size: 125 env: From 38a0448b0868e1a293cbf449929c2cc2afcab2b2 Mon Sep 17 00:00:00 2001 From: Mike Henry <11765982+mikemhenry@users.noreply.github.com> Date: Thu, 29 May 2025 15:50:00 -0700 Subject: [PATCH 21/24] check t3.2xlarge --- .github/workflows/cpu-runner.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/cpu-runner.yaml b/.github/workflows/cpu-runner.yaml index 61fcd575b..e4a82a986 100644 --- a/.github/workflows/cpu-runner.yaml +++ b/.github/workflows/cpu-runner.yaml @@ -21,7 +21,7 @@ jobs: uses: omsf/start-aws-gha-runner@v1.0.0 with: aws_image_id: ami-0b7f661c228e6a4bb - aws_instance_type: t3a.large + aws_instance_type: t3.2xlarge aws_home_dir: /home/ubuntu aws_root_device_size: 125 env: From 69ee3da0484a354f6025f4136251e459944e7915 Mon Sep 17 00:00:00 2001 From: Mike Henry <11765982+mikemhenry@users.noreply.github.com> Date: Fri, 30 May 2025 10:50:06 -0700 Subject: [PATCH 22/24] make sure we load the marks correctly --- .github/workflows/cpu-runner.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/cpu-runner.yaml b/.github/workflows/cpu-runner.yaml index e4a82a986..6d4fc71f9 100644 --- a/.github/workflows/cpu-runner.yaml +++ b/.github/workflows/cpu-runner.yaml @@ -89,7 +89,7 @@ jobs: OFE_SLOW_TESTS: "true" DUECREDIT_ENABLE: 'yes' run: | - pytest -n logical -vv --durations=10 + pytest -n logical -vv --durations=10 openfecli/tests/ openfe/tests/ stop-aws-runner: runs-on: ubuntu-latest From 7d6858835d53fc2ee79e600bfddd25fac0495970 Mon Sep 17 00:00:00 2001 From: Mike Henry <11765982+mikemhenry@users.noreply.github.com> Date: Fri, 30 May 2025 13:33:21 -0700 Subject: [PATCH 23/24] I think we are using the wrong instance family --- .github/workflows/cpu-runner.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/cpu-runner.yaml b/.github/workflows/cpu-runner.yaml index 6d4fc71f9..1af9bd5c1 100644 --- a/.github/workflows/cpu-runner.yaml +++ b/.github/workflows/cpu-runner.yaml @@ -21,7 +21,7 @@ jobs: uses: omsf/start-aws-gha-runner@v1.0.0 with: aws_image_id: ami-0b7f661c228e6a4bb - aws_instance_type: t3.2xlarge + aws_instance_type: c7i.xlarge aws_home_dir: /home/ubuntu aws_root_device_size: 125 env: From caec4c08b35e385602fc402be0fbf1fa7cd4fb7c Mon Sep 17 00:00:00 2001 From: Mike Henry <11765982+mikemhenry@users.noreply.github.com> Date: Wed, 11 Jun 2025 11:38:53 -0700 Subject: [PATCH 24/24] don't run itergration tests on the CPU --- .github/workflows/cpu-long-tests.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/cpu-long-tests.yaml b/.github/workflows/cpu-long-tests.yaml index e35602f4a..416e23a6b 100644 --- a/.github/workflows/cpu-long-tests.yaml +++ b/.github/workflows/cpu-long-tests.yaml @@ -88,7 +88,7 @@ jobs: env: OFE_SLOW_TESTS: "true" DUECREDIT_ENABLE: 'yes' - OFE_INTEGRATION_TESTS: TRUE + OFE_INTEGRATION_TESTS: FALSE run: | pytest -n logical -vv --durations=10 openfecli/tests/ openfe/tests/