From eeb2f32e7b3e553b45e17524ee4185f32e0cd639 Mon Sep 17 00:00:00 2001
From: Pierre Laborde <49183340+labordep@users.noreply.github.com>
Date: Wed, 1 Nov 2023 13:24:55 +0100
Subject: [PATCH 1/6] Initialize edit on running plugin

---
 .../PyramidPluginEditOnRunningTest.class.st   | 42 +++++++++++++++++++
 .../PyramidPluginEditOnRunning.class.st       | 40 ++++++++++++++++++
 2 files changed, 82 insertions(+)
 create mode 100644 src/Pyramid-Tests/PyramidPluginEditOnRunningTest.class.st
 create mode 100644 src/Pyramid/PyramidPluginEditOnRunning.class.st

diff --git a/src/Pyramid-Tests/PyramidPluginEditOnRunningTest.class.st b/src/Pyramid-Tests/PyramidPluginEditOnRunningTest.class.st
new file mode 100644
index 00000000..d1c40af3
--- /dev/null
+++ b/src/Pyramid-Tests/PyramidPluginEditOnRunningTest.class.st
@@ -0,0 +1,42 @@
+"
+A PyramidPluginEditOnRunningTest is a test class for testing the behavior of PyramidPluginEditOnRunning
+"
+Class {
+	#name : #PyramidPluginEditOnRunningTest,
+	#superclass : #TestCase,
+	#instVars : [
+		'editOnRunning'
+	],
+	#category : #'Pyramid-Tests-cases-plugin-edit-on-running'
+}
+
+{ #category : #tests }
+PyramidPluginEditOnRunningTest >> setUp [ 
+
+	super setUp.
+	editOnRunning := PyramidPluginEditOnRunning editOnRunning.
+]
+
+{ #category : #tests }
+PyramidPluginEditOnRunningTest >> tearDown [ 
+
+	super tearDown.
+	PyramidPluginEditOnRunning editOnRunning: editOnRunning.
+]
+
+{ #category : #tests }
+PyramidPluginEditOnRunningTest >> testEditOnRunning [
+
+	PyramidPluginEditOnRunning editOnRunning: true.
+	self assert: PyramidPluginEditOnRunning editOnRunning.
+	
+	PyramidPluginEditOnRunning editOnRunning: false.
+	self deny: PyramidPluginEditOnRunning editOnRunning.
+]
+
+{ #category : #tests }
+PyramidPluginEditOnRunningTest >> testPlugin [
+
+	| plugin |
+	plugin := PyramidPluginEditOnRunning new.
+]
diff --git a/src/Pyramid/PyramidPluginEditOnRunning.class.st b/src/Pyramid/PyramidPluginEditOnRunning.class.st
new file mode 100644
index 00000000..bfae5d04
--- /dev/null
+++ b/src/Pyramid/PyramidPluginEditOnRunning.class.st
@@ -0,0 +1,40 @@
+Class {
+	#name : #PyramidPluginEditOnRunning,
+	#superclass : #Object,
+	#traits : 'TPyramidPlugin',
+	#classTraits : 'TPyramidPlugin classTrait',
+	#classInstVars : [
+		'editOnRunning'
+	],
+	#category : #'Pyramid-plugin-edit-on-running'
+}
+
+{ #category : #accessing }
+PyramidPluginEditOnRunning class >> editOnRunning [
+
+	^ editOnRunning ifNil: [ editOnRunning := true ]
+]
+
+{ #category : #accessing }
+PyramidPluginEditOnRunning class >> editOnRunning: aBoolean [
+
+	editOnRunning := aBoolean
+]
+
+{ #category : #adding }
+PyramidPluginEditOnRunning >> addPanelsOn: aPyramidSimpleWindow [
+
+	"do nothing"
+]
+
+{ #category : #actions }
+PyramidPluginEditOnRunning >> configureBuilder: aPyramidEditorBuilder [
+
+	"do nothing"
+]
+
+{ #category : #'as yet unclassified' }
+PyramidPluginEditOnRunning >> connectOn: aPyramidEditor [
+
+	"do nothing"
+]

From 969ee3a74ade5f6149d51c9ac21987c670ad16c5 Mon Sep 17 00:00:00 2001
From: Pierre Laborde <49183340+labordep@users.noreply.github.com>
Date: Wed, 1 Nov 2023 13:42:19 +0100
Subject: [PATCH 2/6] Plugins initialize refactoring

---
 src/Pyramid-Bloc/PyramidBlocPlugin.class.st   |  8 +----
 .../PyramidBlocTextPlugin.class.st            |  8 +----
 .../PyramidContextMenuPlugin.class.st         |  3 +-
 .../PyramidCopyPastePlugin.class.st           |  6 ----
 src/Pyramid-Bloc/PyramidSavePlugin.class.st   |  8 +----
 src/Pyramid-Bloc/PyramidSpacePlugin.class.st  |  9 +-----
 src/Pyramid-Bloc/PyramidTreePlugin.class.st   |  8 +----
 src/Pyramid/PyramidHistoryPlugin.class.st     |  8 +----
 .../PyramidPluginDynamicLayout.class.st       |  8 +----
 .../PyramidPluginEditOnRunning.class.st       | 31 ++++++++++++++++++-
 src/Pyramid/PyramidPluginSelection.class.st   |  8 +----
 src/Pyramid/TPyramidPlugin.trait.st           | 10 +++++-
 12 files changed, 49 insertions(+), 66 deletions(-)

diff --git a/src/Pyramid-Bloc/PyramidBlocPlugin.class.st b/src/Pyramid-Bloc/PyramidBlocPlugin.class.st
index 9ae6842b..5cc72fc8 100644
--- a/src/Pyramid-Bloc/PyramidBlocPlugin.class.st
+++ b/src/Pyramid-Bloc/PyramidBlocPlugin.class.st
@@ -197,12 +197,6 @@ PyramidBlocPlugin class >> geometry [
 	^ property
 ]
 
-{ #category : #'class initialization' }
-PyramidBlocPlugin class >> initialize [
-
-	PyramidPluginManager uniqueInstance addPlugin: self
-]
-
 { #category : #accessing }
 PyramidBlocPlugin class >> layout [
 
@@ -301,7 +295,7 @@ PyramidBlocPlugin >> addPanelsOn: aPyramidSimpleWindow [
 		addItem: [ :builder | self menuChangeOrderOn: builder ]
 ]
 
-{ #category : #'as yet unclassified' }
+{ #category : #connecting }
 PyramidBlocPlugin >> connectOn: aPyramidEditor [
 
 	self editor: aPyramidEditor.
diff --git a/src/Pyramid-Bloc/PyramidBlocTextPlugin.class.st b/src/Pyramid-Bloc/PyramidBlocTextPlugin.class.st
index 41e2dab4..385fc993 100644
--- a/src/Pyramid-Bloc/PyramidBlocTextPlugin.class.st
+++ b/src/Pyramid-Bloc/PyramidBlocTextPlugin.class.st
@@ -46,12 +46,6 @@ PyramidBlocTextPlugin class >> fontWeight [
 	^ property
 ]
 
-{ #category : #'class initialization' }
-PyramidBlocTextPlugin class >> initialize [
-
-	PyramidPluginManager uniqueInstance addPlugin: self
-]
-
 { #category : #accessing }
 PyramidBlocTextPlugin class >> textForeground [
 
@@ -67,7 +61,7 @@ PyramidBlocTextPlugin class >> textForeground [
 	^ property
 ]
 
-{ #category : #'as yet unclassified' }
+{ #category : #connecting }
 PyramidBlocTextPlugin >> connectOn: aPyramidEditor [
 
 	aPyramidEditor propertiesManager addProperty: self class changeText.
diff --git a/src/Pyramid-Bloc/PyramidContextMenuPlugin.class.st b/src/Pyramid-Bloc/PyramidContextMenuPlugin.class.st
index bd1a07b8..e259496a 100644
--- a/src/Pyramid-Bloc/PyramidContextMenuPlugin.class.st
+++ b/src/Pyramid-Bloc/PyramidContextMenuPlugin.class.st
@@ -12,6 +12,7 @@ Class {
 { #category : #'class initialization' }
 PyramidContextMenuPlugin class >> initialize [
 
+	self flag:'labordep: Why remove before add ?'.
 	PyramidPluginManager uniqueInstance removePlugin: self.
 	PyramidPluginManager uniqueInstance addPlugin: self
 ]
@@ -24,7 +25,7 @@ PyramidContextMenuPlugin >> addPanelsOn: aPyramidSimpleWindow [
 		self menuBrowseAndInspectOn: builder ]
 ]
 
-{ #category : #'as yet unclassified' }
+{ #category : #connecting }
 PyramidContextMenuPlugin >> connectOn: aPyramidEditor [
 
 	self editor: aPyramidEditor.
diff --git a/src/Pyramid-Bloc/PyramidCopyPastePlugin.class.st b/src/Pyramid-Bloc/PyramidCopyPastePlugin.class.st
index 8c2b8009..80ee52d8 100644
--- a/src/Pyramid-Bloc/PyramidCopyPastePlugin.class.st
+++ b/src/Pyramid-Bloc/PyramidCopyPastePlugin.class.st
@@ -6,12 +6,6 @@ Class {
 	#category : #'Pyramid-Bloc-plugin-copy-paste'
 }
 
-{ #category : #'class initialization' }
-PyramidCopyPastePlugin class >> initialize [
-
-	PyramidPluginManager uniqueInstance addPlugin: self
-]
-
 { #category : #adding }
 PyramidCopyPastePlugin >> addPanelsOn: aPyramidSimpleWindow [
 
diff --git a/src/Pyramid-Bloc/PyramidSavePlugin.class.st b/src/Pyramid-Bloc/PyramidSavePlugin.class.st
index 933cc930..7c7ee66f 100644
--- a/src/Pyramid-Bloc/PyramidSavePlugin.class.st
+++ b/src/Pyramid-Bloc/PyramidSavePlugin.class.st
@@ -15,12 +15,6 @@ Class {
 	#category : #'Pyramid-Bloc-plugin-save'
 }
 
-{ #category : #'class initialization' }
-PyramidSavePlugin class >> initialize [
-
-	PyramidPluginManager uniqueInstance addPlugin: self
-]
-
 { #category : #'instance creation' }
 PyramidSavePlugin class >> openOn: aCollectionOfBlElement saveModel: aSaveModel [
 
@@ -51,7 +45,7 @@ PyramidSavePlugin >> addPanelsOn: aPyramidSimpleWindow [
 		builder makeButtonWithIcon: self inputsButton order: 2 ]
 ]
 
-{ #category : #'as yet unclassified' }
+{ #category : #connecting }
 PyramidSavePlugin >> connectOn: aPyramidEditor [
 
 	self projectModel: aPyramidEditor projectModel.
diff --git a/src/Pyramid-Bloc/PyramidSpacePlugin.class.st b/src/Pyramid-Bloc/PyramidSpacePlugin.class.st
index 29508430..ee8ba982 100644
--- a/src/Pyramid-Bloc/PyramidSpacePlugin.class.st
+++ b/src/Pyramid-Bloc/PyramidSpacePlugin.class.st
@@ -11,13 +11,6 @@ Class {
 	#category : #'Pyramid-Bloc-plugin-space'
 }
 
-{ #category : #'class initialization' }
-PyramidSpacePlugin class >> initialize [
-	PyramidPluginManager uniqueInstance addPlugin: self
-
-	
-]
-
 { #category : #adding }
 PyramidSpacePlugin >> addPanelsOn: aPyramidSimpleWindow [
 
@@ -34,7 +27,7 @@ PyramidSpacePlugin >> builder [
 ^ builder
 ]
 
-{ #category : #'as yet unclassified' }
+{ #category : #connecting }
 PyramidSpacePlugin >> connectOn: aPyramidEditor [
 
 	builder editor: aPyramidEditor.
diff --git a/src/Pyramid-Bloc/PyramidTreePlugin.class.st b/src/Pyramid-Bloc/PyramidTreePlugin.class.st
index 0da26612..81fbcdd6 100644
--- a/src/Pyramid-Bloc/PyramidTreePlugin.class.st
+++ b/src/Pyramid-Bloc/PyramidTreePlugin.class.st
@@ -85,12 +85,6 @@ PyramidTreePlugin class >> columnZIndex: aPyramidTreePlugin [
 		  yourself
 ]
 
-{ #category : #'class initialization' }
-PyramidTreePlugin class >> initialize [
-
-	PyramidPluginManager uniqueInstance addPlugin: self
-]
-
 { #category : #initialization }
 PyramidTreePlugin class >> setId: aString of: aBlElement onEditor: aPyramidEditor [
 
@@ -124,7 +118,7 @@ PyramidTreePlugin >> addPanelsOn: aPyramidSimpleWindow [
 		addItem: [ :builder | self menuAddAndDeleteOn: builder ]
 ]
 
-{ #category : #'as yet unclassified' }
+{ #category : #connecting }
 PyramidTreePlugin >> connectOn: aPyramidEditor [
 
 	self editor: aPyramidEditor.
diff --git a/src/Pyramid/PyramidHistoryPlugin.class.st b/src/Pyramid/PyramidHistoryPlugin.class.st
index 7387397c..dde8d092 100644
--- a/src/Pyramid/PyramidHistoryPlugin.class.st
+++ b/src/Pyramid/PyramidHistoryPlugin.class.st
@@ -12,12 +12,6 @@ Class {
 	#category : #'Pyramid-history'
 }
 
-{ #category : #'class initialization' }
-PyramidHistoryPlugin class >> initialize [
-
-	PyramidPluginManager uniqueInstance addPlugin: self
-]
-
 { #category : #adding }
 PyramidHistoryPlugin >> addPanelsOn: aPyramidSimpleWindow [
 
@@ -31,7 +25,7 @@ PyramidHistoryPlugin >> addPanelsOn: aPyramidSimpleWindow [
 		builder makeButtonWithIcon: self redoButton order: 20 ]
 ]
 
-{ #category : #'as yet unclassified' }
+{ #category : #connecting }
 PyramidHistoryPlugin >> connectOn: aPyramidEditor [
 
 	self history: aPyramidEditor propertiesManager history.
diff --git a/src/Pyramid/PyramidPluginDynamicLayout.class.st b/src/Pyramid/PyramidPluginDynamicLayout.class.st
index af086c3b..1a209533 100644
--- a/src/Pyramid/PyramidPluginDynamicLayout.class.st
+++ b/src/Pyramid/PyramidPluginDynamicLayout.class.st
@@ -13,12 +13,6 @@ Class {
 	#category : #'Pyramid-plugin-dynamic-layout'
 }
 
-{ #category : #initialization }
-PyramidPluginDynamicLayout class >> initialize [
-
-	PyramidPluginManager uniqueInstance addPlugin: self
-]
-
 { #category : #adding }
 PyramidPluginDynamicLayout >> addPanelsOn: aPyramidWindow [
 
@@ -71,7 +65,7 @@ PyramidPluginDynamicLayout >> configureBuilder: aPyramidBuilder [
 	aPyramidBuilder window: editorWindow
 ]
 
-{ #category : #'as yet unclassified' }
+{ #category : #connecting }
 PyramidPluginDynamicLayout >> connectOn: aPyramidEditor [
 
 	self changeEditorLayout
diff --git a/src/Pyramid/PyramidPluginEditOnRunning.class.st b/src/Pyramid/PyramidPluginEditOnRunning.class.st
index bfae5d04..0eeebad9 100644
--- a/src/Pyramid/PyramidPluginEditOnRunning.class.st
+++ b/src/Pyramid/PyramidPluginEditOnRunning.class.st
@@ -33,8 +33,37 @@ PyramidPluginEditOnRunning >> configureBuilder: aPyramidEditorBuilder [
 	"do nothing"
 ]
 
-{ #category : #'as yet unclassified' }
+{ #category : #connecting }
 PyramidPluginEditOnRunning >> connectOn: aPyramidEditor [
 
 	"do nothing"
 ]
+
+{ #category : #initialization }
+PyramidPluginEditOnRunning >> initialize [
+
+	super initialize.
+	self start.
+]
+
+{ #category : #events }
+PyramidPluginEditOnRunning >> receiveBlParallelUniverseHostSpaceCreatedSignal: anEvent [
+
+	
+]
+
+{ #category : #'start-stop' }
+PyramidPluginEditOnRunning >> start [
+	"Install BlUniverse listeners"
+	
+	BlParallelUniverse all do:[ :u |
+		u when: BlParallelUniverseHostSpaceCreatedSignal do:[ :e | self receiveBlParallelUniverseHostSpaceCreatedSignal: e ].
+	].
+]
+
+{ #category : #'start-stop' }
+PyramidPluginEditOnRunning >> stop [
+	"Remove BlUniverse listeners"
+	
+	"not necessary to remove"
+]
diff --git a/src/Pyramid/PyramidPluginSelection.class.st b/src/Pyramid/PyramidPluginSelection.class.st
index e4bc84e9..4b6ad465 100644
--- a/src/Pyramid/PyramidPluginSelection.class.st
+++ b/src/Pyramid/PyramidPluginSelection.class.st
@@ -10,12 +10,6 @@ Class {
 	#category : #'Pyramid-plugin-selection'
 }
 
-{ #category : #'as yet unclassified' }
-PyramidPluginSelection class >> initialize [
-
-	PyramidPluginManager uniqueInstance addPlugin: self
-]
-
 { #category : #adding }
 PyramidPluginSelection >> addPanelsOn: aPyramidSimpleWindow [
 
@@ -27,7 +21,7 @@ PyramidPluginSelection >> addPanelsOn: aPyramidSimpleWindow [
 			order: 1 ].
 ]
 
-{ #category : #'as yet unclassified' }
+{ #category : #connecting }
 PyramidPluginSelection >> connectOn: aPyramidEditor [
 
 	self view projectModel: aPyramidEditor projectModel
diff --git a/src/Pyramid/TPyramidPlugin.trait.st b/src/Pyramid/TPyramidPlugin.trait.st
index 99d2f4fd..9b1ec69a 100644
--- a/src/Pyramid/TPyramidPlugin.trait.st
+++ b/src/Pyramid/TPyramidPlugin.trait.st
@@ -3,6 +3,14 @@ Trait {
 	#category : #'Pyramid-core'
 }
 
+{ #category : #initialization }
+TPyramidPlugin classSide >> initialize [ 
+	<script>
+
+	self = TPyramidPlugin ifTrue:[ ^ self ].
+	PyramidPluginManager uniqueInstance addPlugin: self
+]
+
 { #category : #adding }
 TPyramidPlugin >> addPanelsOn: aPyramidSimpleWindow [
 ]
@@ -13,6 +21,6 @@ TPyramidPlugin >> configureBuilder: aPyramidEditorBuilder [
 	
 ]
 
-{ #category : #'as yet unclassified' }
+{ #category : #connecting }
 TPyramidPlugin >> connectOn: aPyramidEditor [
 ]

From a990e7c474d63cf77d9f409f170aaeb8d5e7d66a Mon Sep 17 00:00:00 2001
From: Pierre Laborde <49183340+labordep@users.noreply.github.com>
Date: Wed, 1 Nov 2023 13:55:26 +0100
Subject: [PATCH 3/6] Menu: add display panel to list loaded plugins

---
 src/Pyramid-IDE/PyramidWorld.class.st | 47 +++++++++++++++++++++++++--
 1 file changed, 44 insertions(+), 3 deletions(-)

diff --git a/src/Pyramid-IDE/PyramidWorld.class.st b/src/Pyramid-IDE/PyramidWorld.class.st
index 78188cc6..56dbec19 100644
--- a/src/Pyramid-IDE/PyramidWorld.class.st
+++ b/src/Pyramid-IDE/PyramidWorld.class.st
@@ -4,6 +4,34 @@ Class {
 	#category : #'Pyramid-IDE-Menus'
 }
 
+{ #category : #actions }
+PyramidWorld class >> displayLoadedPlugins [
+
+	| presenter stream |
+	presenter := SpTextPresenter new.
+	stream := ReadWriteStream on: String new.
+	
+	"Create loaded plugin list"
+	PyramidPluginManager uniqueInstance ifNotNil:[ :e |
+		
+		"Statistics"
+		stream 
+			nextPutAll: (e pluginClasses size) asString; 
+			nextPutAll: ' loaded plugin(s).'; 
+			cr; cr.
+		
+		"Details"
+		e pluginClasses do:[ :p |
+			stream nextPutAll: '-' ; nextPutAll: p name; cr.	
+		].
+	
+	] ifNil:[stream nextPutAll: 'No loaded plugins.'].
+	
+	presenter text: stream contents.
+	presenter open.
+	presenter withWindowDo: [ :w | w title: 'Pyramid loaded plugins' ].
+]
+
 { #category : #menu }
 PyramidWorld class >> menuBrowseSourcesOn: aBuilder [
 
@@ -30,6 +58,19 @@ PyramidWorld class >> menuGithubOn: aBuilder [
 		action: [ WebBrowser openOn: 'https://github.com/OpenSmock/Pyramid' ]
 ]
 
+{ #category : #menu }
+PyramidWorld class >> menuLoadedPluginsOn: aBuilder [
+
+	<worldMenu>
+	(aBuilder item: #New)
+		parent: #PyramidDev;
+		order: 1.0;
+		action: [ self displayLoadedPlugins ];
+		icon: (self iconNamed: #box);
+		help: 'Display all installed plugins';
+		label: 'Loaded plugins'
+]
+
 { #category : #menu }
 PyramidWorld class >> menuNewOn: aBuilder [
 
@@ -68,11 +109,11 @@ PyramidWorld class >> menuRefreshPluginOn: aBuilder [
 	<worldMenu>
 	(aBuilder item: #New)
 		parent: #PyramidDev;
-		order: 1.0;
+		order: 1.1;
 		action: [ self startRefreshPlugins ];
 		icon: (self iconNamed: #refresh);
-		help: 'Reload all Pyramid plugins, use this to install a new plugin';
-		label: 'Refresh plugins'
+		help: 'Reload all Pyramid plugins, use this for example to change installed plugin list';
+		label: 'Reload plugins'
 ]
 
 { #category : #menu }

From c067844712fac46e7ce07de878bfb961a73aab76 Mon Sep 17 00:00:00 2001
From: Pierre Laborde <49183340+labordep@users.noreply.github.com>
Date: Wed, 1 Nov 2023 14:06:55 +0100
Subject: [PATCH 4/6] Install edit on running plugin + error refactoring

---
 .../PyramidExistingOverlayError.class.st       |  2 +-
 src/Pyramid-Bloc/PyramidSaveError.class.st     |  2 +-
 .../PyramidPluginEditOnRunningTest.class.st    | 18 +++++++++++-------
 src/Pyramid/PyramidError.class.st              |  5 +++++
 .../PyramidPluginEditOnRunning.class.st        | 15 +++++++++++++++
 5 files changed, 33 insertions(+), 9 deletions(-)
 create mode 100644 src/Pyramid/PyramidError.class.st

diff --git a/src/Pyramid-Bloc/PyramidExistingOverlayError.class.st b/src/Pyramid-Bloc/PyramidExistingOverlayError.class.st
index 8b2f13d4..2a039cc1 100644
--- a/src/Pyramid-Bloc/PyramidExistingOverlayError.class.st
+++ b/src/Pyramid-Bloc/PyramidExistingOverlayError.class.st
@@ -1,5 +1,5 @@
 Class {
 	#name : #PyramidExistingOverlayError,
-	#superclass : #Error,
+	#superclass : #PyramidError,
 	#category : #'Pyramid-Bloc-plugin-space'
 }
diff --git a/src/Pyramid-Bloc/PyramidSaveError.class.st b/src/Pyramid-Bloc/PyramidSaveError.class.st
index c405f2e1..a26a5088 100644
--- a/src/Pyramid-Bloc/PyramidSaveError.class.st
+++ b/src/Pyramid-Bloc/PyramidSaveError.class.st
@@ -1,5 +1,5 @@
 Class {
 	#name : #PyramidSaveError,
-	#superclass : #Error,
+	#superclass : #PyramidError,
 	#category : #'Pyramid-Bloc-plugin-save'
 }
diff --git a/src/Pyramid-Tests/PyramidPluginEditOnRunningTest.class.st b/src/Pyramid-Tests/PyramidPluginEditOnRunningTest.class.st
index d1c40af3..7a040ce4 100644
--- a/src/Pyramid-Tests/PyramidPluginEditOnRunningTest.class.st
+++ b/src/Pyramid-Tests/PyramidPluginEditOnRunningTest.class.st
@@ -5,7 +5,8 @@ Class {
 	#name : #PyramidPluginEditOnRunningTest,
 	#superclass : #TestCase,
 	#instVars : [
-		'editOnRunning'
+		'plugin',
+		'setting'
 	],
 	#category : #'Pyramid-Tests-cases-plugin-edit-on-running'
 }
@@ -14,29 +15,32 @@ Class {
 PyramidPluginEditOnRunningTest >> setUp [ 
 
 	super setUp.
-	editOnRunning := PyramidPluginEditOnRunning editOnRunning.
+	plugin := PyramidPluginEditOnRunning new.
+	setting := PyramidPluginEditOnRunning editOnRunning.
 ]
 
 { #category : #tests }
 PyramidPluginEditOnRunningTest >> tearDown [ 
 
+	plugin := nil.
+	PyramidPluginEditOnRunning editOnRunning: setting.
 	super tearDown.
-	PyramidPluginEditOnRunning editOnRunning: editOnRunning.
 ]
 
 { #category : #tests }
 PyramidPluginEditOnRunningTest >> testEditOnRunning [
 
-	PyramidPluginEditOnRunning editOnRunning: true.
+	plugin editOnRunning: true.
+	self assert: plugin editOnRunning.
 	self assert: PyramidPluginEditOnRunning editOnRunning.
 	
-	PyramidPluginEditOnRunning editOnRunning: false.
+	plugin editOnRunning: false.
+	self deny: plugin editOnRunning.
 	self deny: PyramidPluginEditOnRunning editOnRunning.
 ]
 
 { #category : #tests }
 PyramidPluginEditOnRunningTest >> testPlugin [
 
-	| plugin |
-	plugin := PyramidPluginEditOnRunning new.
+	self assert: plugin notNil.
 ]
diff --git a/src/Pyramid/PyramidError.class.st b/src/Pyramid/PyramidError.class.st
new file mode 100644
index 00000000..e75716ca
--- /dev/null
+++ b/src/Pyramid/PyramidError.class.st
@@ -0,0 +1,5 @@
+Class {
+	#name : #PyramidError,
+	#superclass : #Error,
+	#category : #'Pyramid-core'
+}
diff --git a/src/Pyramid/PyramidPluginEditOnRunning.class.st b/src/Pyramid/PyramidPluginEditOnRunning.class.st
index 0eeebad9..d5c695d3 100644
--- a/src/Pyramid/PyramidPluginEditOnRunning.class.st
+++ b/src/Pyramid/PyramidPluginEditOnRunning.class.st
@@ -3,6 +3,9 @@ Class {
 	#superclass : #Object,
 	#traits : 'TPyramidPlugin',
 	#classTraits : 'TPyramidPlugin classTrait',
+	#instVars : [
+		'editOnRunning'
+	],
 	#classInstVars : [
 		'editOnRunning'
 	],
@@ -39,6 +42,18 @@ PyramidPluginEditOnRunning >> connectOn: aPyramidEditor [
 	"do nothing"
 ]
 
+{ #category : #accessing }
+PyramidPluginEditOnRunning >> editOnRunning [
+
+	^ self class editOnRunning
+]
+
+{ #category : #accessing }
+PyramidPluginEditOnRunning >> editOnRunning: aBoolean [
+
+	self class editOnRunning: aBoolean
+]
+
 { #category : #initialization }
 PyramidPluginEditOnRunning >> initialize [
 

From 44a5a199752c8d99af508833a35ca5868b7442dd Mon Sep 17 00:00:00 2001
From: Pierre Laborde <49183340+labordep@users.noreply.github.com>
Date: Wed, 1 Nov 2023 14:11:10 +0100
Subject: [PATCH 5/6] Add pyramid event class

---
 src/Pyramid/PyramidEvent.class.st | 5 +++++
 1 file changed, 5 insertions(+)
 create mode 100644 src/Pyramid/PyramidEvent.class.st

diff --git a/src/Pyramid/PyramidEvent.class.st b/src/Pyramid/PyramidEvent.class.st
new file mode 100644
index 00000000..c7ebff97
--- /dev/null
+++ b/src/Pyramid/PyramidEvent.class.st
@@ -0,0 +1,5 @@
+Class {
+	#name : #PyramidEvent,
+	#superclass : #Announcement,
+	#category : #'Pyramid-core'
+}

From c65fc420468f7261b2b40f8a6cb77698479c2e3f Mon Sep 17 00:00:00 2001
From: Pierre Laborde <49183340+labordep@users.noreply.github.com>
Date: Wed, 1 Nov 2023 14:26:22 +0100
Subject: [PATCH 6/6] Refactoring

---
 .../PyramidPluginEditOnRunningTest.class.st   | 15 +----
 .../PyramidPluginEditOnRunning.class.st       | 64 +++++++------------
 src/Pyramid/PyramidPluginManager.class.st     | 10 ++-
 src/Pyramid/TPyramidPlugin.trait.st           | 10 +++
 4 files changed, 43 insertions(+), 56 deletions(-)

diff --git a/src/Pyramid-Tests/PyramidPluginEditOnRunningTest.class.st b/src/Pyramid-Tests/PyramidPluginEditOnRunningTest.class.st
index 7a040ce4..0b57bcb8 100644
--- a/src/Pyramid-Tests/PyramidPluginEditOnRunningTest.class.st
+++ b/src/Pyramid-Tests/PyramidPluginEditOnRunningTest.class.st
@@ -5,7 +5,6 @@ Class {
 	#name : #PyramidPluginEditOnRunningTest,
 	#superclass : #TestCase,
 	#instVars : [
-		'plugin',
 		'setting'
 	],
 	#category : #'Pyramid-Tests-cases-plugin-edit-on-running'
@@ -15,14 +14,12 @@ Class {
 PyramidPluginEditOnRunningTest >> setUp [ 
 
 	super setUp.
-	plugin := PyramidPluginEditOnRunning new.
 	setting := PyramidPluginEditOnRunning editOnRunning.
 ]
 
 { #category : #tests }
 PyramidPluginEditOnRunningTest >> tearDown [ 
 
-	plugin := nil.
 	PyramidPluginEditOnRunning editOnRunning: setting.
 	super tearDown.
 ]
@@ -30,17 +27,9 @@ PyramidPluginEditOnRunningTest >> tearDown [
 { #category : #tests }
 PyramidPluginEditOnRunningTest >> testEditOnRunning [
 
-	plugin editOnRunning: true.
-	self assert: plugin editOnRunning.
+	PyramidPluginEditOnRunning editOnRunning: true.
 	self assert: PyramidPluginEditOnRunning editOnRunning.
 	
-	plugin editOnRunning: false.
-	self deny: plugin editOnRunning.
+	PyramidPluginEditOnRunning editOnRunning: false.
 	self deny: PyramidPluginEditOnRunning editOnRunning.
 ]
-
-{ #category : #tests }
-PyramidPluginEditOnRunningTest >> testPlugin [
-
-	self assert: plugin notNil.
-]
diff --git a/src/Pyramid/PyramidPluginEditOnRunning.class.st b/src/Pyramid/PyramidPluginEditOnRunning.class.st
index d5c695d3..1876e000 100644
--- a/src/Pyramid/PyramidPluginEditOnRunning.class.st
+++ b/src/Pyramid/PyramidPluginEditOnRunning.class.st
@@ -24,6 +24,29 @@ PyramidPluginEditOnRunning class >> editOnRunning: aBoolean [
 	editOnRunning := aBoolean
 ]
 
+{ #category : #initialization }
+PyramidPluginEditOnRunning class >> install [
+	"Do some stuff here when the plugin used class oriented behavior"
+	
+	self installBlUniverseListeners.
+]
+
+{ #category : #'universe management' }
+PyramidPluginEditOnRunning class >> installBlUniverseListeners [
+	
+	BlParallelUniverse all do:[ :universe |
+		universe 
+			when: BlParallelUniverseHostSpaceCreatedSignal 
+			do:[ :e | self receiveBlParallelUniverseHostSpaceCreatedSignal: e ].
+	].
+]
+
+{ #category : #'universe management' }
+PyramidPluginEditOnRunning class >> receiveBlParallelUniverseHostSpaceCreatedSignal: anEvent [
+
+	self editOnRunning ifFalse: [ ^ self ].
+]
+
 { #category : #adding }
 PyramidPluginEditOnRunning >> addPanelsOn: aPyramidSimpleWindow [
 
@@ -41,44 +64,3 @@ PyramidPluginEditOnRunning >> connectOn: aPyramidEditor [
 
 	"do nothing"
 ]
-
-{ #category : #accessing }
-PyramidPluginEditOnRunning >> editOnRunning [
-
-	^ self class editOnRunning
-]
-
-{ #category : #accessing }
-PyramidPluginEditOnRunning >> editOnRunning: aBoolean [
-
-	self class editOnRunning: aBoolean
-]
-
-{ #category : #initialization }
-PyramidPluginEditOnRunning >> initialize [
-
-	super initialize.
-	self start.
-]
-
-{ #category : #events }
-PyramidPluginEditOnRunning >> receiveBlParallelUniverseHostSpaceCreatedSignal: anEvent [
-
-	
-]
-
-{ #category : #'start-stop' }
-PyramidPluginEditOnRunning >> start [
-	"Install BlUniverse listeners"
-	
-	BlParallelUniverse all do:[ :u |
-		u when: BlParallelUniverseHostSpaceCreatedSignal do:[ :e | self receiveBlParallelUniverseHostSpaceCreatedSignal: e ].
-	].
-]
-
-{ #category : #'start-stop' }
-PyramidPluginEditOnRunning >> stop [
-	"Remove BlUniverse listeners"
-	
-	"not necessary to remove"
-]
diff --git a/src/Pyramid/PyramidPluginManager.class.st b/src/Pyramid/PyramidPluginManager.class.st
index f4398a38..dbfcd26f 100644
--- a/src/Pyramid/PyramidPluginManager.class.st
+++ b/src/Pyramid/PyramidPluginManager.class.st
@@ -41,7 +41,10 @@ PyramidPluginManager class >> uniqueInstance [
 { #category : #adding }
 PyramidPluginManager >> addPlugin: aPluginClass [
 
-	self pluginClasses add: aPluginClass
+	self pluginClasses add: aPluginClass.
+	
+	"Install the class of the plugin when added"
+	aPluginClass install.
 ]
 
 { #category : #initialization }
@@ -73,5 +76,8 @@ PyramidPluginManager >> pluginClasses [
 { #category : #adding }
 PyramidPluginManager >> removePlugin: aPluginClass [
 
-	self pluginClasses remove: aPluginClass ifAbsent: [  ]
+	self pluginClasses remove: aPluginClass ifAbsent: [  ].
+	
+	"Uninstall the class of the plugin when added"
+	aPluginClass uninstall.
 ]
diff --git a/src/Pyramid/TPyramidPlugin.trait.st b/src/Pyramid/TPyramidPlugin.trait.st
index 9b1ec69a..e0179712 100644
--- a/src/Pyramid/TPyramidPlugin.trait.st
+++ b/src/Pyramid/TPyramidPlugin.trait.st
@@ -11,6 +11,16 @@ TPyramidPlugin classSide >> initialize [
 	PyramidPluginManager uniqueInstance addPlugin: self
 ]
 
+{ #category : #initialization }
+TPyramidPlugin classSide >> install [
+	"Do some stuff here when the plugin used class oriented behavior"
+]
+
+{ #category : #initialization }
+TPyramidPlugin classSide >> uninstall [
+	"Undo some stuff here when the plugin used class oriented behavior"
+]
+
 { #category : #adding }
 TPyramidPlugin >> addPanelsOn: aPyramidSimpleWindow [
 ]