From 9a9ef48f7597149cafec22bc9fac84eb2a230fd8 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Mathieu=20Magu=C3=A9r=C3=A8s?= Date: Wed, 1 Apr 2026 11:08:39 +0200 Subject: [PATCH 01/11] add BlSimpleShadowEffect --- .../PyramidBackgroundBlocPlugin.class.st | 68 ++++++++++++++++++- .../PyramidSaveModelVerifier.class.st | 5 +- .../PyramidShadowColorCommand.class.st | 21 ++++++ .../PyramidShadowCommand.class.st | 17 +++++ .../PyramidShadowOffsetCommand.class.st | 24 +++++++ 5 files changed, 132 insertions(+), 3 deletions(-) create mode 100644 src/Pyramid-Bloc/PyramidShadowColorCommand.class.st create mode 100644 src/Pyramid-Bloc/PyramidShadowCommand.class.st create mode 100644 src/Pyramid-Bloc/PyramidShadowOffsetCommand.class.st diff --git a/src/Pyramid-Bloc/PyramidBackgroundBlocPlugin.class.st b/src/Pyramid-Bloc/PyramidBackgroundBlocPlugin.class.st index e2702d10..163a2f2e 100644 --- a/src/Pyramid-Bloc/PyramidBackgroundBlocPlugin.class.st +++ b/src/Pyramid-Bloc/PyramidBackgroundBlocPlugin.class.st @@ -671,6 +671,67 @@ PyramidBackgroundBlocPlugin class >> outskirts [ ^ property ] +{ #category : #accessing } +PyramidBackgroundBlocPlugin class >> shadow [ + + | property | + property := PyramidProperty new + name: 'Shadow Effect'; + command: PyramidShadowCommand new; + inputPresenterClass: PyramidMagicButtonsInputPresenter; + yourself. + property inputPresenterModel + addButtonModel: (PyramidMagicButtonModel new + icon: (Smalltalk ui icons iconNamed: #blank); + helpSelected: 'No shadow.'; + helpNotSelected: 'Remove shadow.'; + label: 'None'; + inputValue: [ BlNullEffect new]; + inputValidation: [ :value | value class = BlNullEffect]; + yourself); + addButtonModel: (PyramidMagicButtonModel new + icon: (Smalltalk ui icons iconNamed: #menuPin); + helpSelected: 'Shadow type is simple.'; + helpNotSelected: 'Set shadow type to simple.'; + label: 'Simple'; + inputValue: [ + BlSimpleShadowEffect color: Color random offset: 2 @ 2 ]; + inputValidation: [ :value | value class = BlSimpleShadowEffect ]; + yourself); + yourself. + ^ property +] + +{ #category : #accessing } +PyramidBackgroundBlocPlugin class >> shadowColor [ + + | property | + property := PyramidProperty new + name: 'Shadow Color'; + command: PyramidShadowColorCommand new; + inputPresenterClass: + PyramidColorInputSingleLineWithPickupButtonPresenter; + yourself. + ^ property + + +] + +{ #category : #accessing } +PyramidBackgroundBlocPlugin class >> shadowOffset [ + + | property | + property := PyramidProperty new + name: 'Shadow Offset'; + command: PyramidShadowOffsetCommand new; + inputPresenterClass: + PyramidPointInputPresenter; + yourself. + property inputPresenterModel help: + 'Set the position x and y for the shadow offset'. + ^ property +] + { #category : #adding } PyramidBackgroundBlocPlugin >> addPanelsOn: aPyramidSimpleWindow [ @@ -747,7 +808,12 @@ PyramidBackgroundBlocPlugin >> initialize [ propertiesManager addProperty: self class borderRadialInnerCenter. propertiesManager addProperty: self class borderRadialInnerRadius. propertiesManager addProperty: self class borderRadialOuterCenter. - propertiesManager addProperty: self class borderRadialOuterRadius + propertiesManager addProperty: self class borderRadialOuterRadius. + + "Shadow" + propertiesManager addProperty: self class shadow. + propertiesManager addProperty: self class shadowColor. + propertiesManager addProperty: self class shadowOffset ] { #category : #adding } diff --git a/src/Pyramid-Bloc/PyramidSaveModelVerifier.class.st b/src/Pyramid-Bloc/PyramidSaveModelVerifier.class.st index d8425326..6374cc47 100644 --- a/src/Pyramid-Bloc/PyramidSaveModelVerifier.class.st +++ b/src/Pyramid-Bloc/PyramidSaveModelVerifier.class.st @@ -47,9 +47,10 @@ PyramidSaveModelVerifier class >> classPackageIsEqual [ PyramidSaveModelVerifier class >> methodIsValid [ ^ self new - verifyBlock: [ :model | model savingMethodName isValidSelector ]; + verifyBlock: [ :model | + OCScanner isSelector: model savingMethodName ]; showBlock: [ :view | view showMethodIsNotValidError ]; - yourself. + yourself ] { #category : #constructor } diff --git a/src/Pyramid-Bloc/PyramidShadowColorCommand.class.st b/src/Pyramid-Bloc/PyramidShadowColorCommand.class.st new file mode 100644 index 00000000..d9c6793e --- /dev/null +++ b/src/Pyramid-Bloc/PyramidShadowColorCommand.class.st @@ -0,0 +1,21 @@ +Class { + #name : #PyramidShadowColorCommand, + #superclass : #PyramidAbstractBlocCommand, + #category : #'Pyramid-Bloc-plugin-bloc-visuals' +} + +{ #category : #testing } +PyramidShadowColorCommand >> canBeUsedFor: anObject [ + ^ (super canBeUsedFor: anObject) and: [ + anObject effect isKindOf: BlShadowEffect ] +] + +{ #category : #'as yet unclassified' } +PyramidShadowColorCommand >> getValueFor: aBlElement [ + ^ aBlElement effect color +] + +{ #category : #initialization } +PyramidShadowColorCommand >> setValueFor: aBlElement with: aColor [ + aBlElement effect: (aBlElement effect copyWithColor: aColor) +] diff --git a/src/Pyramid-Bloc/PyramidShadowCommand.class.st b/src/Pyramid-Bloc/PyramidShadowCommand.class.st new file mode 100644 index 00000000..4999233d --- /dev/null +++ b/src/Pyramid-Bloc/PyramidShadowCommand.class.st @@ -0,0 +1,17 @@ +Class { + #name : #PyramidShadowCommand, + #superclass : #PyramidAbstractBlocCommand, + #category : #'Pyramid-Bloc-plugin-bloc-visuals' +} + +{ #category : #'as yet unclassified' } +PyramidShadowCommand >> getValueFor: aBlElement [ + + ^ aBlElement effect +] + +{ #category : #'as yet unclassified' } +PyramidShadowCommand >> setValueFor: aBlElement with: anArgument [ + + aBlElement effect: anArgument +] diff --git a/src/Pyramid-Bloc/PyramidShadowOffsetCommand.class.st b/src/Pyramid-Bloc/PyramidShadowOffsetCommand.class.st new file mode 100644 index 00000000..225f9660 --- /dev/null +++ b/src/Pyramid-Bloc/PyramidShadowOffsetCommand.class.st @@ -0,0 +1,24 @@ +Class { + #name : #PyramidShadowOffsetCommand, + #superclass : #PyramidAbstractBlocCommand, + #category : #'Pyramid-Bloc-plugin-bloc-visuals' +} + +{ #category : #testing } +PyramidShadowOffsetCommand >> canBeUsedFor: anObject [ + + ^ (super canBeUsedFor: anObject) and: [ + anObject effect isKindOf: BlShadowEffect ] +] + +{ #category : #'as yet unclassified' } +PyramidShadowOffsetCommand >> getValueFor: aBlElement [ + + ^ aBlElement effect offset +] + +{ #category : #'as yet unclassified' } +PyramidShadowOffsetCommand >> setValueFor: aBlElement with: aPoint [ + + aBlElement effect: (aBlElement effect copyWithOffset: aPoint) +] From b862d3defc7660a2581e0a1a2ead1484ea28298e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Mathieu=20Magu=C3=A9r=C3=A8s?= Date: Wed, 1 Apr 2026 14:52:03 +0200 Subject: [PATCH 02/11] add BlGaussianShadow and its properties --- .../PyramidBackgroundBlocPlugin.class.st | 29 +++++++++++++++++-- ...PyramidGaussianShadowWidthCommand.class.st | 24 +++++++++++++++ 2 files changed, 50 insertions(+), 3 deletions(-) create mode 100644 src/Pyramid-Bloc/PyramidGaussianShadowWidthCommand.class.st diff --git a/src/Pyramid-Bloc/PyramidBackgroundBlocPlugin.class.st b/src/Pyramid-Bloc/PyramidBackgroundBlocPlugin.class.st index 163a2f2e..2d9ede16 100644 --- a/src/Pyramid-Bloc/PyramidBackgroundBlocPlugin.class.st +++ b/src/Pyramid-Bloc/PyramidBackgroundBlocPlugin.class.st @@ -618,6 +618,19 @@ PyramidBackgroundBlocPlugin class >> borderWidth [ ^ property ] +{ #category : #'as yet unclassified' } +PyramidBackgroundBlocPlugin class >> gaussianShadowWidth [ + + | property | + property := PyramidProperty new + name: 'Shadow Width'; + command: PyramidGaussianShadowWidthCommand new; + inputPresenterClass: PyramidNumberInputPresenter; + yourself. + property inputPresenterModel help: 'Set the width value'. + ^ property +] + { #category : #accessing } PyramidBackgroundBlocPlugin class >> opacity [ @@ -686,8 +699,8 @@ PyramidBackgroundBlocPlugin class >> shadow [ helpSelected: 'No shadow.'; helpNotSelected: 'Remove shadow.'; label: 'None'; - inputValue: [ BlNullEffect new]; - inputValidation: [ :value | value class = BlNullEffect]; + inputValue: [ BlNullEffect new ]; + inputValidation: [ :value | value class = BlNullEffect ]; yourself); addButtonModel: (PyramidMagicButtonModel new icon: (Smalltalk ui icons iconNamed: #menuPin); @@ -698,6 +711,15 @@ PyramidBackgroundBlocPlugin class >> shadow [ BlSimpleShadowEffect color: Color random offset: 2 @ 2 ]; inputValidation: [ :value | value class = BlSimpleShadowEffect ]; yourself); + addButtonModel: (PyramidMagicButtonModel new + icon: (Smalltalk ui icons iconNamed: #menuPin); + helpSelected: 'Shadow type is gaussian.'; + helpNotSelected: 'Set shadow type to gaussian.'; + label: 'Gaussian'; + inputValue: [ + BlGaussianShadowEffect color: Color random width: 2 offset: 2 @ 2 ]; + inputValidation: [ :value | value class = BlGaussianShadowEffect ]; + yourself); yourself. ^ property ] @@ -813,7 +835,8 @@ PyramidBackgroundBlocPlugin >> initialize [ "Shadow" propertiesManager addProperty: self class shadow. propertiesManager addProperty: self class shadowColor. - propertiesManager addProperty: self class shadowOffset + propertiesManager addProperty: self class shadowOffset. + propertiesManager addProperty: self class gaussianShadowWidth ] { #category : #adding } diff --git a/src/Pyramid-Bloc/PyramidGaussianShadowWidthCommand.class.st b/src/Pyramid-Bloc/PyramidGaussianShadowWidthCommand.class.st new file mode 100644 index 00000000..e71d80dc --- /dev/null +++ b/src/Pyramid-Bloc/PyramidGaussianShadowWidthCommand.class.st @@ -0,0 +1,24 @@ +Class { + #name : #PyramidGaussianShadowWidthCommand, + #superclass : #PyramidAbstractBlocCommand, + #category : #'Pyramid-Bloc-plugin-bloc-visuals' +} + +{ #category : #testing } +PyramidGaussianShadowWidthCommand >> canBeUsedFor: anObject [ + + ^ (super canBeUsedFor: anObject) and: [ + anObject effect isKindOf: BlGaussianShadowEffect ] +] + +{ #category : #'as yet unclassified' } +PyramidGaussianShadowWidthCommand >> getValueFor: aBlElement [ + + ^ aBlElement effect width +] + +{ #category : #'as yet unclassified' } +PyramidGaussianShadowWidthCommand >> setValueFor: aBlElement with: aValue [ + + aBlElement effect: (aBlElement effect copyWithWidth: aValue) +] From 0e5367d2c5cadbb9bfd27d36b4cc710255dad59c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Mathieu=20Magu=C3=A9r=C3=A8s?= Date: Mon, 13 Apr 2026 13:55:21 +0200 Subject: [PATCH 03/11] icon changes for BlShadowEffect --- src/Pyramid-Bloc/PyramidBackgroundBlocPlugin.class.st | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/src/Pyramid-Bloc/PyramidBackgroundBlocPlugin.class.st b/src/Pyramid-Bloc/PyramidBackgroundBlocPlugin.class.st index 2d9ede16..c2810361 100644 --- a/src/Pyramid-Bloc/PyramidBackgroundBlocPlugin.class.st +++ b/src/Pyramid-Bloc/PyramidBackgroundBlocPlugin.class.st @@ -703,7 +703,7 @@ PyramidBackgroundBlocPlugin class >> shadow [ inputValidation: [ :value | value class = BlNullEffect ]; yourself); addButtonModel: (PyramidMagicButtonModel new - icon: (Smalltalk ui icons iconNamed: #menuPin); + icon: (Smalltalk ui icons iconNamed: #windowMaximize); helpSelected: 'Shadow type is simple.'; helpNotSelected: 'Set shadow type to simple.'; label: 'Simple'; @@ -712,12 +712,15 @@ PyramidBackgroundBlocPlugin class >> shadow [ inputValidation: [ :value | value class = BlSimpleShadowEffect ]; yourself); addButtonModel: (PyramidMagicButtonModel new - icon: (Smalltalk ui icons iconNamed: #menuPin); + icon: (Smalltalk ui icons iconNamed: #radioButtonUnselected); helpSelected: 'Shadow type is gaussian.'; helpNotSelected: 'Set shadow type to gaussian.'; label: 'Gaussian'; inputValue: [ - BlGaussianShadowEffect color: Color random width: 2 offset: 2 @ 2 ]; + BlGaussianShadowEffect + color: Color random + width: 2 + offset: 2 @ 2 ]; inputValidation: [ :value | value class = BlGaussianShadowEffect ]; yourself); yourself. From 66d84f430541cda5311305a55dcde3dda7779099 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Mathieu=20Magu=C3=A9r=C3=A8s?= Date: Tue, 14 Apr 2026 10:59:02 +0200 Subject: [PATCH 04/11] Add support for saving the previous state of the shadow --- .../PyramidBackgroundBlocPlugin.class.st | 23 ++++++---- ...PyramidGaussianShadowWidthCommand.class.st | 5 ++- .../PyramidShadowColorCommand.class.st | 4 +- .../PyramidShadowCommand.class.st | 44 +++++++++++++++++++ .../PyramidShadowOffsetCommand.class.st | 4 +- 5 files changed, 66 insertions(+), 14 deletions(-) diff --git a/src/Pyramid-Bloc/PyramidBackgroundBlocPlugin.class.st b/src/Pyramid-Bloc/PyramidBackgroundBlocPlugin.class.st index c2810361..3f1581a5 100644 --- a/src/Pyramid-Bloc/PyramidBackgroundBlocPlugin.class.st +++ b/src/Pyramid-Bloc/PyramidBackgroundBlocPlugin.class.st @@ -6,6 +6,9 @@ Class { #instVars : [ 'propertiesManager' ], + #classInstVars : [ + 'shadowCommand' + ], #category : #'Pyramid-Bloc-plugin-bloc-visuals' } @@ -685,12 +688,18 @@ PyramidBackgroundBlocPlugin class >> outskirts [ ] { #category : #accessing } -PyramidBackgroundBlocPlugin class >> shadow [ +PyramidBackgroundBlocPlugin class >> resetShadowCommand [ + shadowCommand := nil +] +{ #category : #accessing } +PyramidBackgroundBlocPlugin class >> shadow [ | property | + shadowCommand ifNil: [ shadowCommand := PyramidShadowCommand new ]. + PyramidShadowCommand current: shadowCommand. property := PyramidProperty new name: 'Shadow Effect'; - command: PyramidShadowCommand new; + command: shadowCommand; inputPresenterClass: PyramidMagicButtonsInputPresenter; yourself. property inputPresenterModel @@ -707,8 +716,7 @@ PyramidBackgroundBlocPlugin class >> shadow [ helpSelected: 'Shadow type is simple.'; helpNotSelected: 'Set shadow type to simple.'; label: 'Simple'; - inputValue: [ - BlSimpleShadowEffect color: Color random offset: 2 @ 2 ]; + inputValue: [ shadowCommand lastSimpleShadow ]; inputValidation: [ :value | value class = BlSimpleShadowEffect ]; yourself); addButtonModel: (PyramidMagicButtonModel new @@ -716,11 +724,7 @@ PyramidBackgroundBlocPlugin class >> shadow [ helpSelected: 'Shadow type is gaussian.'; helpNotSelected: 'Set shadow type to gaussian.'; label: 'Gaussian'; - inputValue: [ - BlGaussianShadowEffect - color: Color random - width: 2 - offset: 2 @ 2 ]; + inputValue: [ shadowCommand lastGaussianShadow ]; inputValidation: [ :value | value class = BlGaussianShadowEffect ]; yourself); yourself. @@ -836,6 +840,7 @@ PyramidBackgroundBlocPlugin >> initialize [ propertiesManager addProperty: self class borderRadialOuterRadius. "Shadow" + self class resetShadowCommand. propertiesManager addProperty: self class shadow. propertiesManager addProperty: self class shadowColor. propertiesManager addProperty: self class shadowOffset. diff --git a/src/Pyramid-Bloc/PyramidGaussianShadowWidthCommand.class.st b/src/Pyramid-Bloc/PyramidGaussianShadowWidthCommand.class.st index e71d80dc..d134185b 100644 --- a/src/Pyramid-Bloc/PyramidGaussianShadowWidthCommand.class.st +++ b/src/Pyramid-Bloc/PyramidGaussianShadowWidthCommand.class.st @@ -18,7 +18,8 @@ PyramidGaussianShadowWidthCommand >> getValueFor: aBlElement [ ] { #category : #'as yet unclassified' } -PyramidGaussianShadowWidthCommand >> setValueFor: aBlElement with: aValue [ +PyramidGaussianShadowWidthCommand >> setValueFor: aBlElement with: aWidth [ - aBlElement effect: (aBlElement effect copyWithWidth: aValue) + aBlElement effect: (aBlElement effect copyWithWidth: aWidth). + PyramidShadowCommand current syncFromElement: aBlElement ] diff --git a/src/Pyramid-Bloc/PyramidShadowColorCommand.class.st b/src/Pyramid-Bloc/PyramidShadowColorCommand.class.st index d9c6793e..8faeb5cd 100644 --- a/src/Pyramid-Bloc/PyramidShadowColorCommand.class.st +++ b/src/Pyramid-Bloc/PyramidShadowColorCommand.class.st @@ -17,5 +17,7 @@ PyramidShadowColorCommand >> getValueFor: aBlElement [ { #category : #initialization } PyramidShadowColorCommand >> setValueFor: aBlElement with: aColor [ - aBlElement effect: (aBlElement effect copyWithColor: aColor) + + aBlElement effect: (aBlElement effect copyWithColor: aColor). + PyramidShadowCommand current syncFromElement: aBlElement ] diff --git a/src/Pyramid-Bloc/PyramidShadowCommand.class.st b/src/Pyramid-Bloc/PyramidShadowCommand.class.st index 4999233d..b873244e 100644 --- a/src/Pyramid-Bloc/PyramidShadowCommand.class.st +++ b/src/Pyramid-Bloc/PyramidShadowCommand.class.st @@ -1,17 +1,61 @@ Class { #name : #PyramidShadowCommand, #superclass : #PyramidAbstractBlocCommand, + #instVars : [ + 'lastSimpleShadow', + 'lastGaussianShadow' + ], + #classInstVars : [ + 'current' + ], #category : #'Pyramid-Bloc-plugin-bloc-visuals' } +{ #category : #accessing } +PyramidShadowCommand class >> current [ + ^ current + + +] + +{ #category : #accessing } +PyramidShadowCommand class >> current: anInstance [ + current := anInstance +] + { #category : #'as yet unclassified' } PyramidShadowCommand >> getValueFor: aBlElement [ ^ aBlElement effect ] +{ #category : #accessing } +PyramidShadowCommand >> lastGaussianShadow [ + ^ lastGaussianShadow ifNil: [ BlGaussianShadowEffect color: Color black width: 2 offset: 2 @ 2 ] +] + +{ #category : #accessing } +PyramidShadowCommand >> lastSimpleShadow [ + + ^ lastSimpleShadow ifNil: [ + BlSimpleShadowEffect color: Color black offset: 2 @ 2 ] +] + { #category : #'as yet unclassified' } PyramidShadowCommand >> setValueFor: aBlElement with: anArgument [ + anArgument class = BlSimpleShadowEffect ifTrue: [ + lastSimpleShadow := anArgument ]. + anArgument class = BlGaussianShadowEffect ifTrue: [ + lastGaussianShadow := anArgument ]. aBlElement effect: anArgument ] + +{ #category : #'as yet unclassified' } +PyramidShadowCommand >> syncFromElement: aBlElement [ + + aBlElement effect class = BlSimpleShadowEffect ifTrue: [ + lastSimpleShadow := aBlElement effect ]. + aBlElement effect class = BlGaussianShadowEffect ifTrue: [ + lastGaussianShadow := aBlElement effect ] +] diff --git a/src/Pyramid-Bloc/PyramidShadowOffsetCommand.class.st b/src/Pyramid-Bloc/PyramidShadowOffsetCommand.class.st index 225f9660..0448d0ee 100644 --- a/src/Pyramid-Bloc/PyramidShadowOffsetCommand.class.st +++ b/src/Pyramid-Bloc/PyramidShadowOffsetCommand.class.st @@ -19,6 +19,6 @@ PyramidShadowOffsetCommand >> getValueFor: aBlElement [ { #category : #'as yet unclassified' } PyramidShadowOffsetCommand >> setValueFor: aBlElement with: aPoint [ - - aBlElement effect: (aBlElement effect copyWithOffset: aPoint) + aBlElement effect: (aBlElement effect copyWithOffset: aPoint). + PyramidShadowCommand current syncFromElement: aBlElement ] From c9a7df289659b4ab25465250a6dbc4dc56a2f8d3 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Mathieu=20Magu=C3=A9r=C3=A8s?= Date: Tue, 14 Apr 2026 14:16:34 +0200 Subject: [PATCH 05/11] Remove the shadowCommand class variable --- .../PyramidBackgroundBlocPlugin.class.st | 19 +++++-------------- .../PyramidShadowCommand.class.st | 10 +++++----- 2 files changed, 10 insertions(+), 19 deletions(-) diff --git a/src/Pyramid-Bloc/PyramidBackgroundBlocPlugin.class.st b/src/Pyramid-Bloc/PyramidBackgroundBlocPlugin.class.st index 3f1581a5..c89c96ac 100644 --- a/src/Pyramid-Bloc/PyramidBackgroundBlocPlugin.class.st +++ b/src/Pyramid-Bloc/PyramidBackgroundBlocPlugin.class.st @@ -6,9 +6,6 @@ Class { #instVars : [ 'propertiesManager' ], - #classInstVars : [ - 'shadowCommand' - ], #category : #'Pyramid-Bloc-plugin-bloc-visuals' } @@ -687,19 +684,13 @@ PyramidBackgroundBlocPlugin class >> outskirts [ ^ property ] -{ #category : #accessing } -PyramidBackgroundBlocPlugin class >> resetShadowCommand [ - shadowCommand := nil -] - { #category : #accessing } PyramidBackgroundBlocPlugin class >> shadow [ + | property | - shadowCommand ifNil: [ shadowCommand := PyramidShadowCommand new ]. - PyramidShadowCommand current: shadowCommand. property := PyramidProperty new name: 'Shadow Effect'; - command: shadowCommand; + command: PyramidShadowCommand current; inputPresenterClass: PyramidMagicButtonsInputPresenter; yourself. property inputPresenterModel @@ -716,7 +707,7 @@ PyramidBackgroundBlocPlugin class >> shadow [ helpSelected: 'Shadow type is simple.'; helpNotSelected: 'Set shadow type to simple.'; label: 'Simple'; - inputValue: [ shadowCommand lastSimpleShadow ]; + inputValue: [ PyramidShadowCommand current lastSimpleShadow ]; inputValidation: [ :value | value class = BlSimpleShadowEffect ]; yourself); addButtonModel: (PyramidMagicButtonModel new @@ -724,7 +715,7 @@ PyramidBackgroundBlocPlugin class >> shadow [ helpSelected: 'Shadow type is gaussian.'; helpNotSelected: 'Set shadow type to gaussian.'; label: 'Gaussian'; - inputValue: [ shadowCommand lastGaussianShadow ]; + inputValue: [ PyramidShadowCommand current lastGaussianShadow ]; inputValidation: [ :value | value class = BlGaussianShadowEffect ]; yourself); yourself. @@ -840,7 +831,7 @@ PyramidBackgroundBlocPlugin >> initialize [ propertiesManager addProperty: self class borderRadialOuterRadius. "Shadow" - self class resetShadowCommand. + PyramidShadowCommand resetShadowCommand. propertiesManager addProperty: self class shadow. propertiesManager addProperty: self class shadowColor. propertiesManager addProperty: self class shadowOffset. diff --git a/src/Pyramid-Bloc/PyramidShadowCommand.class.st b/src/Pyramid-Bloc/PyramidShadowCommand.class.st index b873244e..8c407cec 100644 --- a/src/Pyramid-Bloc/PyramidShadowCommand.class.st +++ b/src/Pyramid-Bloc/PyramidShadowCommand.class.st @@ -13,14 +13,14 @@ Class { { #category : #accessing } PyramidShadowCommand class >> current [ - ^ current - - + current ifNil: [ current := self new ]. + ^ current ] { #category : #accessing } -PyramidShadowCommand class >> current: anInstance [ - current := anInstance +PyramidShadowCommand class >> resetShadowCommand [ + + current := nil ] { #category : #'as yet unclassified' } From 83d157c4c42217c3b0583f9141f530cefacc0148 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Mathieu=20Magu=C3=A9r=C3=A8s?= Date: Tue, 14 Apr 2026 15:50:28 +0200 Subject: [PATCH 06/11] fix problem with move index child --- .../PyramidMoveChildInParentPlugin.class.st | 31 +++++++++---------- 1 file changed, 15 insertions(+), 16 deletions(-) diff --git a/src/Pyramid-Bloc/PyramidMoveChildInParentPlugin.class.st b/src/Pyramid-Bloc/PyramidMoveChildInParentPlugin.class.st index 74b2a560..2b1489c1 100644 --- a/src/Pyramid-Bloc/PyramidMoveChildInParentPlugin.class.st +++ b/src/Pyramid-Bloc/PyramidMoveChildInParentPlugin.class.st @@ -46,22 +46,21 @@ PyramidMoveChildInParentPlugin >> contextMenuMoveChildInParent: aBuilder [ aBuilder addGroupSingleSelection: [ :group :single | - group - addItem: [ :item | - item - icon: (Smalltalk ui icons iconNamed: #up); - name: 'Move index child up'; - action: [ self moveChildIndexUpInParent ]; - yourself ]; - - addItem: [ :item | - item - icon: (Smalltalk ui icons iconNamed: #down); - name: 'Move index child down'; - action: [ self moveChildIndexDownInParent ]; - yourself ]; - yourself ] - order: 10. + group + addItem: [ :item | + item + icon: (Smalltalk ui icons iconNamed: #up); + name: 'Move child up'; + action: [ self moveChildIndexDownInParent ]; + yourself ]; + addItem: [ :item | + item + icon: (Smalltalk ui icons iconNamed: #down); + name: 'Move child down'; + action: [self moveChildIndexUpInParent]; + yourself ]; + yourself ] + order: 10 ] { #category : #accessing } From 649bd552218b152367260be676a46c3e9b7997e3 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Mathieu=20Magu=C3=A9r=C3=A8s?= Date: Tue, 14 Apr 2026 17:30:12 +0200 Subject: [PATCH 07/11] fix error messages for moving a child --- .../PyramidMoveChildInParentPlugin.class.st | 60 ++++++++----------- 1 file changed, 26 insertions(+), 34 deletions(-) diff --git a/src/Pyramid-Bloc/PyramidMoveChildInParentPlugin.class.st b/src/Pyramid-Bloc/PyramidMoveChildInParentPlugin.class.st index 2b1489c1..5205f082 100644 --- a/src/Pyramid-Bloc/PyramidMoveChildInParentPlugin.class.st +++ b/src/Pyramid-Bloc/PyramidMoveChildInParentPlugin.class.st @@ -90,28 +90,24 @@ PyramidMoveChildInParentPlugin >> moveChildIndexDownCommand: aBlElementParent wi PyramidMoveChildInParentPlugin >> moveChildIndexDownInParent [ | childToMoveCollection childToMove childIndexToMove parentChild navigationSelectionPanel | - childToMoveCollection := projectModel selection collection. - navigationSelectionPanel := navigationPlugin navigation selectionPanel. - - childToMoveCollection size = 1 - ifFalse: [ ^ self ]. + navigationSelectionPanel := navigationPlugin navigation + selectionPanel. + + childToMoveCollection size = 1 ifFalse: [ ^ self ]. childToMove := childToMoveCollection first. - - childToMove hasParent - ifFalse: [ ^ self ]. + + childToMove hasParent ifFalse: [ ^ self ]. parentChild := childToMove parent. - - childIndexToMove := (parentChild childIndexOf: childToMove). - - childIndexToMove > 1 - ifTrue: [ self moveChildIndexDownCommand: parentChild with: childToMove. - self refreshTreeTable ] - ifFalse: [ self inform: 'Cannot move down' ]. - - + childIndexToMove := parentChild childIndexOf: childToMove. + childIndexToMove > 1 + ifTrue: [ + self moveChildIndexDownCommand: parentChild with: childToMove. + self refreshTreeTable ] + ifFalse: [ + self inform: 'Cannot move up' ] "cannot move the child up and the index down" ] { #category : #'as yet unclassified' } @@ -128,27 +124,23 @@ PyramidMoveChildInParentPlugin >> moveChildIndexUpCommand: aBlElementParent with PyramidMoveChildInParentPlugin >> moveChildIndexUpInParent [ | childToMoveCollection childToMove childIndexToMove parentChild navigationSelectionPanel | - childToMoveCollection := projectModel selection collection. - navigationSelectionPanel := navigationPlugin navigation selectionPanel. - - childToMoveCollection size = 1 - ifFalse: [ ^ self ]. + navigationSelectionPanel := navigationPlugin navigation + selectionPanel. + + childToMoveCollection size = 1 ifFalse: [ ^ self ]. childToMove := childToMoveCollection first. - - childToMove hasParent - ifFalse: [ ^ self ]. + + childToMove hasParent ifFalse: [ ^ self ]. parentChild := childToMove parent. - - childIndexToMove := (parentChild childIndexOf: childToMove). - - childIndexToMove < (parentChild children size) - ifTrue: [ self moveChildIndexUpCommand: parentChild with: childToMove. - self refreshTreeTable ] - ifFalse: [ self inform: 'Cannot move up' ]. - - + childIndexToMove := parentChild childIndexOf: childToMove. + + childIndexToMove < parentChild children size + ifTrue: [ + self moveChildIndexUpCommand: parentChild with: childToMove. + self refreshTreeTable ] + ifFalse: [ self inform: 'Cannot move down' ] "cannot move the child down and the index up" ] { #category : #accessing } From 1888659367a30c3d8cbce287d44a2a7a207170db Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Mathieu=20Magu=C3=A9r=C3=A8s?= Date: Wed, 15 Apr 2026 10:01:34 +0200 Subject: [PATCH 08/11] fix error OCScanner --- src/Pyramid-Bloc/PyramidSaveModelVerifier.class.st | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/Pyramid-Bloc/PyramidSaveModelVerifier.class.st b/src/Pyramid-Bloc/PyramidSaveModelVerifier.class.st index 6374cc47..d8425326 100644 --- a/src/Pyramid-Bloc/PyramidSaveModelVerifier.class.st +++ b/src/Pyramid-Bloc/PyramidSaveModelVerifier.class.st @@ -47,10 +47,9 @@ PyramidSaveModelVerifier class >> classPackageIsEqual [ PyramidSaveModelVerifier class >> methodIsValid [ ^ self new - verifyBlock: [ :model | - OCScanner isSelector: model savingMethodName ]; + verifyBlock: [ :model | model savingMethodName isValidSelector ]; showBlock: [ :view | view showMethodIsNotValidError ]; - yourself + yourself. ] { #category : #constructor } From 53f2c19cc434ac62113aeb3c5fd613d46ae4666e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Mathieu=20Magu=C3=A9r=C3=A8s?= Date: Thu, 16 Apr 2026 15:22:28 +0200 Subject: [PATCH 09/11] add tests and update devShadow --- .../PyramidBackgroundBlocPlugin.class.st | 31 +++-- ...PyramidGaussianShadowWidthCommand.class.st | 25 ---- .../PyramidMoveChildInParentPlugin.class.st | 13 +- .../PyramidShadowColorCommand.class.st | 14 ++- .../PyramidShadowCommand.class.st | 8 +- ...PyramidShadowGaussianWidthCommand.class.st | 28 +++++ .../PyramidShadowOffsetCommand.class.st | 12 +- .../PyramidShadowColorCommandTest.class.st | 35 ++++++ .../PyramidShadowCommandTest.class.st | 114 ++++++++++++++++++ .../PyramidShadowGaussianWidthTest.class.st | 36 ++++++ .../PyramidShadowOffsetCommandTest.class.st | 35 ++++++ 11 files changed, 290 insertions(+), 61 deletions(-) delete mode 100644 src/Pyramid-Bloc/PyramidGaussianShadowWidthCommand.class.st create mode 100644 src/Pyramid-Bloc/PyramidShadowGaussianWidthCommand.class.st create mode 100644 src/Pyramid-Tests/PyramidShadowColorCommandTest.class.st create mode 100644 src/Pyramid-Tests/PyramidShadowCommandTest.class.st create mode 100644 src/Pyramid-Tests/PyramidShadowGaussianWidthTest.class.st create mode 100644 src/Pyramid-Tests/PyramidShadowOffsetCommandTest.class.st diff --git a/src/Pyramid-Bloc/PyramidBackgroundBlocPlugin.class.st b/src/Pyramid-Bloc/PyramidBackgroundBlocPlugin.class.st index c89c96ac..1f36a867 100644 --- a/src/Pyramid-Bloc/PyramidBackgroundBlocPlugin.class.st +++ b/src/Pyramid-Bloc/PyramidBackgroundBlocPlugin.class.st @@ -618,19 +618,6 @@ PyramidBackgroundBlocPlugin class >> borderWidth [ ^ property ] -{ #category : #'as yet unclassified' } -PyramidBackgroundBlocPlugin class >> gaussianShadowWidth [ - - | property | - property := PyramidProperty new - name: 'Shadow Width'; - command: PyramidGaussianShadowWidthCommand new; - inputPresenterClass: PyramidNumberInputPresenter; - yourself. - property inputPresenterModel help: 'Set the width value'. - ^ property -] - { #category : #accessing } PyramidBackgroundBlocPlugin class >> opacity [ @@ -717,8 +704,7 @@ PyramidBackgroundBlocPlugin class >> shadow [ label: 'Gaussian'; inputValue: [ PyramidShadowCommand current lastGaussianShadow ]; inputValidation: [ :value | value class = BlGaussianShadowEffect ]; - yourself); - yourself. + yourself). ^ property ] @@ -752,6 +738,19 @@ PyramidBackgroundBlocPlugin class >> shadowOffset [ ^ property ] +{ #category : #accessing } +PyramidBackgroundBlocPlugin class >> shadowWidthGaussian [ + + | property | + property := PyramidProperty new + name: 'Shadow Width'; + command: PyramidShadowGaussianWidthCommand new; + inputPresenterClass: PyramidNumberInputPresenter; + yourself. + property inputPresenterModel help: 'Set the width value'. + ^ property +] + { #category : #adding } PyramidBackgroundBlocPlugin >> addPanelsOn: aPyramidSimpleWindow [ @@ -835,7 +834,7 @@ PyramidBackgroundBlocPlugin >> initialize [ propertiesManager addProperty: self class shadow. propertiesManager addProperty: self class shadowColor. propertiesManager addProperty: self class shadowOffset. - propertiesManager addProperty: self class gaussianShadowWidth + propertiesManager addProperty: self class shadowWidthGaussian ] { #category : #adding } diff --git a/src/Pyramid-Bloc/PyramidGaussianShadowWidthCommand.class.st b/src/Pyramid-Bloc/PyramidGaussianShadowWidthCommand.class.st deleted file mode 100644 index d134185b..00000000 --- a/src/Pyramid-Bloc/PyramidGaussianShadowWidthCommand.class.st +++ /dev/null @@ -1,25 +0,0 @@ -Class { - #name : #PyramidGaussianShadowWidthCommand, - #superclass : #PyramidAbstractBlocCommand, - #category : #'Pyramid-Bloc-plugin-bloc-visuals' -} - -{ #category : #testing } -PyramidGaussianShadowWidthCommand >> canBeUsedFor: anObject [ - - ^ (super canBeUsedFor: anObject) and: [ - anObject effect isKindOf: BlGaussianShadowEffect ] -] - -{ #category : #'as yet unclassified' } -PyramidGaussianShadowWidthCommand >> getValueFor: aBlElement [ - - ^ aBlElement effect width -] - -{ #category : #'as yet unclassified' } -PyramidGaussianShadowWidthCommand >> setValueFor: aBlElement with: aWidth [ - - aBlElement effect: (aBlElement effect copyWithWidth: aWidth). - PyramidShadowCommand current syncFromElement: aBlElement -] diff --git a/src/Pyramid-Bloc/PyramidMoveChildInParentPlugin.class.st b/src/Pyramid-Bloc/PyramidMoveChildInParentPlugin.class.st index 5205f082..4fe6a43b 100644 --- a/src/Pyramid-Bloc/PyramidMoveChildInParentPlugin.class.st +++ b/src/Pyramid-Bloc/PyramidMoveChildInParentPlugin.class.st @@ -91,8 +91,7 @@ PyramidMoveChildInParentPlugin >> moveChildIndexDownInParent [ | childToMoveCollection childToMove childIndexToMove parentChild navigationSelectionPanel | childToMoveCollection := projectModel selection collection. - navigationSelectionPanel := navigationPlugin navigation - selectionPanel. + navigationSelectionPanel := navigationPlugin navigation selectionPanel. childToMoveCollection size = 1 ifFalse: [ ^ self ]. childToMove := childToMoveCollection first. @@ -106,8 +105,8 @@ PyramidMoveChildInParentPlugin >> moveChildIndexDownInParent [ ifTrue: [ self moveChildIndexDownCommand: parentChild with: childToMove. self refreshTreeTable ] - ifFalse: [ - self inform: 'Cannot move up' ] "cannot move the child up and the index down" + ifFalse: [ "cannot move the child up and the index down" + self inform: 'Cannot move up' ] ] { #category : #'as yet unclassified' } @@ -125,8 +124,7 @@ PyramidMoveChildInParentPlugin >> moveChildIndexUpInParent [ | childToMoveCollection childToMove childIndexToMove parentChild navigationSelectionPanel | childToMoveCollection := projectModel selection collection. - navigationSelectionPanel := navigationPlugin navigation - selectionPanel. + navigationSelectionPanel := navigationPlugin navigation selectionPanel. childToMoveCollection size = 1 ifFalse: [ ^ self ]. childToMove := childToMoveCollection first. @@ -140,7 +138,8 @@ PyramidMoveChildInParentPlugin >> moveChildIndexUpInParent [ ifTrue: [ self moveChildIndexUpCommand: parentChild with: childToMove. self refreshTreeTable ] - ifFalse: [ self inform: 'Cannot move down' ] "cannot move the child down and the index up" + ifFalse: [ "cannot move the child down and the index up" + self inform: 'Cannot move down' ] ] { #category : #accessing } diff --git a/src/Pyramid-Bloc/PyramidShadowColorCommand.class.st b/src/Pyramid-Bloc/PyramidShadowColorCommand.class.st index 8faeb5cd..550930a1 100644 --- a/src/Pyramid-Bloc/PyramidShadowColorCommand.class.st +++ b/src/Pyramid-Bloc/PyramidShadowColorCommand.class.st @@ -10,14 +10,20 @@ PyramidShadowColorCommand >> canBeUsedFor: anObject [ anObject effect isKindOf: BlShadowEffect ] ] -{ #category : #'as yet unclassified' } +{ #category : #accessing } PyramidShadowColorCommand >> getValueFor: aBlElement [ - ^ aBlElement effect color + + (aBlElement effect isKindOf: BlShadowEffect) + ifTrue: [ ^ aBlElement effect color ] + ifFalse: [ ^ self ] ] -{ #category : #initialization } +{ #category : #accessing } PyramidShadowColorCommand >> setValueFor: aBlElement with: aColor [ - aBlElement effect: (aBlElement effect copyWithColor: aColor). + (aBlElement effect isKindOf: BlShadowEffect) + ifTrue: [ + aBlElement effect: (aBlElement effect copyWithColor: aColor) ] + ifFalse: [ ^ self ]. PyramidShadowCommand current syncFromElement: aBlElement ] diff --git a/src/Pyramid-Bloc/PyramidShadowCommand.class.st b/src/Pyramid-Bloc/PyramidShadowCommand.class.st index 8c407cec..6734091f 100644 --- a/src/Pyramid-Bloc/PyramidShadowCommand.class.st +++ b/src/Pyramid-Bloc/PyramidShadowCommand.class.st @@ -23,10 +23,10 @@ PyramidShadowCommand class >> resetShadowCommand [ current := nil ] -{ #category : #'as yet unclassified' } +{ #category : #accessing } PyramidShadowCommand >> getValueFor: aBlElement [ - ^ aBlElement effect + ^ aBlElement effect ] { #category : #accessing } @@ -41,7 +41,7 @@ PyramidShadowCommand >> lastSimpleShadow [ BlSimpleShadowEffect color: Color black offset: 2 @ 2 ] ] -{ #category : #'as yet unclassified' } +{ #category : #accessing } PyramidShadowCommand >> setValueFor: aBlElement with: anArgument [ anArgument class = BlSimpleShadowEffect ifTrue: [ @@ -51,7 +51,7 @@ PyramidShadowCommand >> setValueFor: aBlElement with: anArgument [ aBlElement effect: anArgument ] -{ #category : #'as yet unclassified' } +{ #category : #updating } PyramidShadowCommand >> syncFromElement: aBlElement [ aBlElement effect class = BlSimpleShadowEffect ifTrue: [ diff --git a/src/Pyramid-Bloc/PyramidShadowGaussianWidthCommand.class.st b/src/Pyramid-Bloc/PyramidShadowGaussianWidthCommand.class.st new file mode 100644 index 00000000..9b0108f1 --- /dev/null +++ b/src/Pyramid-Bloc/PyramidShadowGaussianWidthCommand.class.st @@ -0,0 +1,28 @@ +Class { + #name : #PyramidShadowGaussianWidthCommand, + #superclass : #PyramidAbstractBlocCommand, + #category : #'Pyramid-Bloc-plugin-bloc-visuals' +} + +{ #category : #testing } +PyramidShadowGaussianWidthCommand >> canBeUsedFor: anObject [ + + ^ (super canBeUsedFor: anObject) and: [ + anObject effect isKindOf: BlGaussianShadowEffect ] +] + +{ #category : #accessing } +PyramidShadowGaussianWidthCommand >> getValueFor: aBlElement [ + + ^ (aBlElement effect isKindOf: BlGaussianShadowEffect) ifTrue: [aBlElement effect width] ifFalse: [ ^ self ] +] + +{ #category : #accessing } +PyramidShadowGaussianWidthCommand >> setValueFor: aBlElement with: aWidth [ + + (aBlElement effect isKindOf: BlGaussianShadowEffect) + ifTrue: [ + aBlElement effect: (aBlElement effect copyWithWidth: aWidth) ] + ifFalse: [ ^ self ]. + PyramidShadowCommand current syncFromElement: aBlElement +] diff --git a/src/Pyramid-Bloc/PyramidShadowOffsetCommand.class.st b/src/Pyramid-Bloc/PyramidShadowOffsetCommand.class.st index 0448d0ee..76ef190e 100644 --- a/src/Pyramid-Bloc/PyramidShadowOffsetCommand.class.st +++ b/src/Pyramid-Bloc/PyramidShadowOffsetCommand.class.st @@ -11,14 +11,16 @@ PyramidShadowOffsetCommand >> canBeUsedFor: anObject [ anObject effect isKindOf: BlShadowEffect ] ] -{ #category : #'as yet unclassified' } +{ #category : #accessing } PyramidShadowOffsetCommand >> getValueFor: aBlElement [ - ^ aBlElement effect offset + ^ (aBlElement effect isKindOf: BlShadowEffect) ifTrue: [aBlElement effect offset] ifFalse: [ ^ self ] ] -{ #category : #'as yet unclassified' } +{ #category : #accessing } PyramidShadowOffsetCommand >> setValueFor: aBlElement with: aPoint [ - aBlElement effect: (aBlElement effect copyWithOffset: aPoint). - PyramidShadowCommand current syncFromElement: aBlElement + + (aBlElement effect isKindOf: BlShadowEffect) + ifTrue: [aBlElement effect: (aBlElement effect copyWithOffset: aPoint)] ifFalse: [^ self] . + PyramidShadowCommand current syncFromElement: aBlElement ] diff --git a/src/Pyramid-Tests/PyramidShadowColorCommandTest.class.st b/src/Pyramid-Tests/PyramidShadowColorCommandTest.class.st new file mode 100644 index 00000000..e5f446a1 --- /dev/null +++ b/src/Pyramid-Tests/PyramidShadowColorCommandTest.class.st @@ -0,0 +1,35 @@ +Class { + #name : #PyramidShadowColorCommandTest, + #superclass : #TestCase, + #traits : 'TPyramidCommandTest', + #classTraits : 'TPyramidCommandTest classTrait', + #category : #'Pyramid-Tests-cases-plugin-bloc-visuals' +} + +{ #category : #accessing } +PyramidShadowColorCommandTest >> command [ + + ^ PyramidShadowColorCommand new +] + +{ #category : #'as yet unclassified' } +PyramidShadowColorCommandTest >> targetContainers [ + + ^ { + (PyramidCommandTestContainer + no: (BlElement new effect: BlSimpleShadowEffect new) + with: (BlElement new + effect: (BlSimpleShadowEffect color: Color red offset: 2 @ 2); + yourself) + prop: Color red). + (PyramidCommandTestContainer + no: (BlElement new effect: BlGaussianShadowEffect new) + with: (BlElement new + effect: + (BlGaussianShadowEffect + color: Color blue + width: 10 + offset: 4 @ 4); + yourself) + prop: Color blue) } +] diff --git a/src/Pyramid-Tests/PyramidShadowCommandTest.class.st b/src/Pyramid-Tests/PyramidShadowCommandTest.class.st new file mode 100644 index 00000000..2dcdb309 --- /dev/null +++ b/src/Pyramid-Tests/PyramidShadowCommandTest.class.st @@ -0,0 +1,114 @@ +Class { + #name : #PyramidShadowCommandTest, + #superclass : #TestCase, + #traits : 'TPyramidCommandTest', + #classTraits : 'TPyramidCommandTest classTrait', + #category : #'Pyramid-Tests-cases-plugin-bloc-visuals' +} + +{ #category : #tests } +PyramidShadowCommandTest >> assert: anObject hasSamePropertiesAs: anotherObject [ + + self assert: anObject color equals: anotherObject color. + self assert: anObject offset equals: anotherObject offset. + (anObject isKindOf: BlGaussianShadowEffect) ifTrue: [ + self assert: anObject width equals: anotherObject width ] +] + +{ #category : #accessing } +PyramidShadowCommandTest >> command [ + + ^ PyramidShadowCommand new +] + +{ #category : #'as yet unclassified' } +PyramidShadowCommandTest >> targetContainers [ + + ^ { + (PyramidCommandTestContainer + no: BlElement new + with: (BlElement new + effect: (BlSimpleShadowEffect color: Color red offset: 2 @ 2); + yourself) + prop: (BlSimpleShadowEffect color: Color red offset: 2 @ 2)). + (PyramidCommandTestContainer + no: BlElement new + with: (BlElement new + effect: + (BlGaussianShadowEffect + color: Color blue + width: 10 + offset: 4 @ 4); + yourself) + prop: + (BlGaussianShadowEffect + color: Color blue + width: 10 + offset: 4 @ 4)). + (PyramidCommandTestContainer + no: (BlElement new effect: BlOverlayEffect new) + with: (BlElement new + effect: + (BlGaussianShadowEffect + color: Color blue + width: 10 + offset: 4 @ 4); + yourself) + prop: + (BlGaussianShadowEffect + color: Color blue + width: 10 + offset: 4 @ 4)) } +] + +{ #category : #tests } +PyramidShadowCommandTest >> testGetValueFor [ + + self targetsWithValuesAndValues do: [ :each | + self assert: (self command getValueFor: each key) hasSamePropertiesAs: each value ] +] + +{ #category : #tests } +PyramidShadowCommandTest >> testHistory [ + "Do once. + undo + redo + undo + redo" + + | history commandExecutor targets | + targets := self targetsCanBeUsedFor. + history := PyramidHistory new. + commandExecutor := PyramidHistoryCommandExecutor new + history: history; + wrappee: PyramidMainCommandExecutor new; + yourself. + + "Do once" + self argumentsForHistory do: [ :each | + commandExecutor use: self command on: targets with: each ]. + + "Undo all" + self argumentsForHistory reverseDo: [ :argument | + targets do: [ :target | + self assert: (self command getValueFor: target) hasSamePropertiesAs: argument ]. + history canUndo ifTrue: [ history undo ] ]. + + "Redo all" + self argumentsForHistory do: [ :argument | + history canRedo ifTrue: [ history redo ]. + targets do: [ :target | + self assert: (self command getValueFor: target) hasSamePropertiesAs: argument ] ]. + + "Undo all" + self argumentsForHistory reverseDo: [ :argument | + targets do: [ :target | + self assert: (self command getValueFor: target) hasSamePropertiesAs: argument ]. + history canUndo ifTrue: [ history undo ] ]. + + "Redo all" + self argumentsForHistory do: [ :argument | + history canRedo ifTrue: [ history redo ]. + targets do: [ :target | + self assert: (self command getValueFor: target) hasSamePropertiesAs: argument ] ] +] diff --git a/src/Pyramid-Tests/PyramidShadowGaussianWidthTest.class.st b/src/Pyramid-Tests/PyramidShadowGaussianWidthTest.class.st new file mode 100644 index 00000000..a417f5fc --- /dev/null +++ b/src/Pyramid-Tests/PyramidShadowGaussianWidthTest.class.st @@ -0,0 +1,36 @@ +Class { + #name : #PyramidShadowGaussianWidthTest, + #superclass : #TestCase, + #traits : 'TPyramidCommandTest', + #classTraits : 'TPyramidCommandTest classTrait', + #category : #'Pyramid-Tests-cases-plugin-bloc-visuals' +} + +{ #category : #accessing } +PyramidShadowGaussianWidthTest >> command [ + + ^ PyramidShadowGaussianWidthCommand new + +] + +{ #category : #'as yet unclassified' } +PyramidShadowGaussianWidthTest >> targetContainers [ + + ^ { + (PyramidCommandTestContainer + no: (BlElement new effect: BlGaussianShadowEffect new) + with: (BlElement new + effect: (BlGaussianShadowEffect color: Color red width: 5 offset: 2 @ 2); + yourself) + prop: 5). + (PyramidCommandTestContainer + no: (BlElement new effect: BlGaussianShadowEffect new) + with: (BlElement new + effect: + (BlGaussianShadowEffect + color: Color blue + width: 10 + offset: 4 @ 4); + yourself) + prop: 10) } +] diff --git a/src/Pyramid-Tests/PyramidShadowOffsetCommandTest.class.st b/src/Pyramid-Tests/PyramidShadowOffsetCommandTest.class.st new file mode 100644 index 00000000..a68c8424 --- /dev/null +++ b/src/Pyramid-Tests/PyramidShadowOffsetCommandTest.class.st @@ -0,0 +1,35 @@ +Class { + #name : #PyramidShadowOffsetCommandTest, + #superclass : #TestCase, + #traits : 'TPyramidCommandTest', + #classTraits : 'TPyramidCommandTest classTrait', + #category : #'Pyramid-Tests-cases-plugin-bloc-visuals' +} + +{ #category : #accessing } +PyramidShadowOffsetCommandTest >> command [ + + ^ PyramidShadowOffsetCommand new +] + +{ #category : #'as yet unclassified' } +PyramidShadowOffsetCommandTest >> targetContainers [ + + ^ { + (PyramidCommandTestContainer + no: (BlElement new effect: BlSimpleShadowEffect new) + with: (BlElement new + effect: (BlSimpleShadowEffect color: Color red offset: 2 @ 2); + yourself) + prop: 2@2). + (PyramidCommandTestContainer + no: (BlElement new effect: BlGaussianShadowEffect new) + with: (BlElement new + effect: + (BlGaussianShadowEffect + color: Color blue + width: 10 + offset: 4 @ 4); + yourself) + prop: 4@4) } +] From 29092943da14af147a8c805290eab178d7bb93f7 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Mathieu=20Magu=C3=A9r=C3=A8s?= Date: Thu, 16 Apr 2026 16:17:43 +0200 Subject: [PATCH 10/11] update devShadow --- .../PyramidShadowColorCommand.class.st | 14 ++++++++------ .../PyramidShadowGaussianWidthCommand.class.st | 11 +++++++---- .../PyramidShadowOffsetCommand.class.st | 12 ++++++++---- .../PyramidAddChildCommandTest.class.st | 2 +- .../PyramidBackgroundImageCommandTest.class.st | 4 ++-- .../PyramidBackgroundOpacityCommandTest.class.st | 2 +- ...PyramidBackgroundPaintColorCommandTest.class.st | 4 ++-- .../PyramidBackgroundPaintCommandTest.class.st | 2 +- ...midBackgroundPaintLinearEndCommandTest.class.st | 4 ++-- ...dBackgroundPaintLinearStartCommandTest.class.st | 4 ++-- ...roundPaintRadialInnerCenterCommandTest.class.st | 4 ++-- ...roundPaintRadialInnerRadiusCommandTest.class.st | 4 ++-- ...roundPaintRadialOuterCenterCommandTest.class.st | 4 ++-- ...roundPaintRadialOuterRadiusCommandTest.class.st | 4 ++-- ...PyramidBackgroundPaintStopsCommandTest.class.st | 4 ++-- .../PyramidBackgroundTypeCommandTest.class.st | 2 +- ...ctHorizontalConstraintsBlocCommandTest.class.st | 4 ++-- ...xactVerticalConstraintsBlocCommandTest.class.st | 4 ++-- ...icHorizontalConstraintsBlocCommandTest.class.st | 4 ++-- ...asicVerticalConstraintsBlocCommandTest.class.st | 4 ++-- .../PyramidBorderDashArrayCommandTest.class.st | 2 +- .../PyramidBorderDashOffsetCommandTest.class.st | 2 +- .../PyramidBorderLineCapCommandTest.class.st | 2 +- .../PyramidBorderLineJoinCommandTest.class.st | 2 +- .../PyramidBorderMiterLimitCommandTest.class.st | 2 +- .../PyramidBorderOpacityCommandTest.class.st | 2 +- .../PyramidBorderTypeCommandTest.class.st | 2 +- ...PyramidChangeOrderWithIndexCommandTest.class.st | 4 ++-- .../PyramidChangeTextCommandTest.class.st | 2 +- .../PyramidClipChildrenCommandTest.class.st | 2 +- .../PyramidElementIdCommandTest.class.st | 2 +- .../PyramidFontSizeCommandTest.class.st | 2 +- .../PyramidFontWeightCommandTest.class.st | 2 +- .../PyramidGeometryCommandTest.class.st | 2 +- .../PyramidLayoutBlocCommandTest.class.st | 4 ++-- ...amidLayoutChangeOrientationCommandTest.class.st | 4 ++-- .../PyramidMarginCommandTest.class.st | 2 +- .../PyramidMoveBackwardOrderCommandTest.class.st | 8 ++++---- .../PyramidMoveForwardOrderCommandTest.class.st | 8 ++++---- .../PyramidOnBackgroundOrderCommandTest.class.st | 4 ++-- .../PyramidOnForegroundOrderCommandTest.class.st | 4 ++-- .../PyramidOpacityCommandTest.class.st | 2 +- .../PyramidPaddingCommandTest.class.st | 2 +- .../PyramidPositionCommandTest.class.st | 2 +- .../PyramidPositionOffsetCommandTest.class.st | 2 +- ...ionnalHorizontalConstraintsCommandTest.class.st | 4 ++-- ...rtionnalVerticalConstraintsCommandTest.class.st | 4 ++-- .../PyramidRemoveChildCommandTest.class.st | 2 +- .../PyramidRemoveSelectionCommandTest.class.st | 2 +- ...RoundedRectangleCornerRadiiCommandTest.class.st | 4 ++-- .../PyramidShadowColorCommandTest.class.st | 2 +- .../PyramidShadowCommandTest.class.st | 2 +- .../PyramidShadowGaussianWidthTest.class.st | 2 +- .../PyramidShadowOffsetCommandTest.class.st | 2 +- .../PyramidTextForegroundCommandTest.class.st | 2 +- .../PyramidVisibilityCommandTest.class.st | 2 +- .../PyramidWeightConstraintsCommandTest.class.st | 4 ++-- .../PyramidZIndexCommandTest.class.st | 2 +- src/Pyramid-Tests/TPyramidCommandTest.trait.st | 8 ++++---- .../PyramidStampCommandTest.class.st | 2 +- 60 files changed, 111 insertions(+), 102 deletions(-) diff --git a/src/Pyramid-Bloc/PyramidShadowColorCommand.class.st b/src/Pyramid-Bloc/PyramidShadowColorCommand.class.st index 550930a1..ec8cae3b 100644 --- a/src/Pyramid-Bloc/PyramidShadowColorCommand.class.st +++ b/src/Pyramid-Bloc/PyramidShadowColorCommand.class.st @@ -6,24 +6,26 @@ Class { { #category : #testing } PyramidShadowColorCommand >> canBeUsedFor: anObject [ - ^ (super canBeUsedFor: anObject) and: [ - anObject effect isKindOf: BlShadowEffect ] + + ^ (super canBeUsedFor: anObject) and: [ + anObject effect class = BlSimpleShadowEffect or: [ + anObject effect class = BlGaussianShadowEffect ] ] ] { #category : #accessing } PyramidShadowColorCommand >> getValueFor: aBlElement [ - (aBlElement effect isKindOf: BlShadowEffect) + (aBlElement effect class = BlSimpleShadowEffect or: [aBlElement effect class = BlGaussianShadowEffect]) ifTrue: [ ^ aBlElement effect color ] - ifFalse: [ ^ self ] + ifFalse: [ ^ nil ] ] { #category : #accessing } PyramidShadowColorCommand >> setValueFor: aBlElement with: aColor [ - (aBlElement effect isKindOf: BlShadowEffect) + (aBlElement effect class = BlSimpleShadowEffect or: [aBlElement effect class= BlGaussianShadowEffect]) ifTrue: [ aBlElement effect: (aBlElement effect copyWithColor: aColor) ] - ifFalse: [ ^ self ]. + ifFalse: [ ^ nil ]. PyramidShadowCommand current syncFromElement: aBlElement ] diff --git a/src/Pyramid-Bloc/PyramidShadowGaussianWidthCommand.class.st b/src/Pyramid-Bloc/PyramidShadowGaussianWidthCommand.class.st index 9b0108f1..08272272 100644 --- a/src/Pyramid-Bloc/PyramidShadowGaussianWidthCommand.class.st +++ b/src/Pyramid-Bloc/PyramidShadowGaussianWidthCommand.class.st @@ -8,21 +8,24 @@ Class { PyramidShadowGaussianWidthCommand >> canBeUsedFor: anObject [ ^ (super canBeUsedFor: anObject) and: [ - anObject effect isKindOf: BlGaussianShadowEffect ] + anObject effect class = BlGaussianShadowEffect ] ] { #category : #accessing } PyramidShadowGaussianWidthCommand >> getValueFor: aBlElement [ - ^ (aBlElement effect isKindOf: BlGaussianShadowEffect) ifTrue: [aBlElement effect width] ifFalse: [ ^ self ] + (aBlElement effect class = BlSimpleShadowEffect or: [ + aBlElement effect class = BlGaussianShadowEffect ]) + ifTrue: [ ^ aBlElement effect width ] + ifFalse: [ ^ nil ] ] { #category : #accessing } PyramidShadowGaussianWidthCommand >> setValueFor: aBlElement with: aWidth [ - (aBlElement effect isKindOf: BlGaussianShadowEffect) + (aBlElement effect class = BlSimpleShadowEffect or: [aBlElement effect class = BlGaussianShadowEffect]) ifTrue: [ aBlElement effect: (aBlElement effect copyWithWidth: aWidth) ] - ifFalse: [ ^ self ]. + ifFalse: [ ^ nil ]. PyramidShadowCommand current syncFromElement: aBlElement ] diff --git a/src/Pyramid-Bloc/PyramidShadowOffsetCommand.class.st b/src/Pyramid-Bloc/PyramidShadowOffsetCommand.class.st index 76ef190e..a4388e2b 100644 --- a/src/Pyramid-Bloc/PyramidShadowOffsetCommand.class.st +++ b/src/Pyramid-Bloc/PyramidShadowOffsetCommand.class.st @@ -8,19 +8,23 @@ Class { PyramidShadowOffsetCommand >> canBeUsedFor: anObject [ ^ (super canBeUsedFor: anObject) and: [ - anObject effect isKindOf: BlShadowEffect ] + anObject effect class = BlSimpleShadowEffect or: [anObject effect class = BlGaussianShadowEffect] ] ] { #category : #accessing } PyramidShadowOffsetCommand >> getValueFor: aBlElement [ - ^ (aBlElement effect isKindOf: BlShadowEffect) ifTrue: [aBlElement effect offset] ifFalse: [ ^ self ] + (aBlElement effect class = BlSimpleShadowEffect or: [aBlElement effect class = BlGaussianShadowEffect]) + ifTrue: [ ^ aBlElement effect offset ] + ifFalse: [ ^ nil ] ] { #category : #accessing } PyramidShadowOffsetCommand >> setValueFor: aBlElement with: aPoint [ - (aBlElement effect isKindOf: BlShadowEffect) - ifTrue: [aBlElement effect: (aBlElement effect copyWithOffset: aPoint)] ifFalse: [^ self] . + (aBlElement effect class = BlSimpleShadowEffect or: [aBlElement effect class = BlGaussianShadowEffect]) + ifTrue: [ + aBlElement effect: (aBlElement effect copyWithOffset: aPoint) ] + ifFalse: [ ^ nil ]. PyramidShadowCommand current syncFromElement: aBlElement ] diff --git a/src/Pyramid-Tests/PyramidAddChildCommandTest.class.st b/src/Pyramid-Tests/PyramidAddChildCommandTest.class.st index ad54c577..39710d5d 100644 --- a/src/Pyramid-Tests/PyramidAddChildCommandTest.class.st +++ b/src/Pyramid-Tests/PyramidAddChildCommandTest.class.st @@ -12,7 +12,7 @@ PyramidAddChildCommandTest >> command [ ^ PyramidAddChildCommand new ] -{ #category : #'as yet unclassified' } +{ #category : #accessing } PyramidAddChildCommandTest >> targetsCanBeUsedFor [ ^ { BlElement new . BlElement new addChild: BlElement new; yourself } diff --git a/src/Pyramid-Tests/PyramidBackgroundImageCommandTest.class.st b/src/Pyramid-Tests/PyramidBackgroundImageCommandTest.class.st index f5308c6b..d1c49058 100644 --- a/src/Pyramid-Tests/PyramidBackgroundImageCommandTest.class.st +++ b/src/Pyramid-Tests/PyramidBackgroundImageCommandTest.class.st @@ -12,7 +12,7 @@ PyramidBackgroundImageCommandTest >> command [ ^ PyramidBackgroundImageCommand new ] -{ #category : #'as yet unclassified' } +{ #category : #accessing } PyramidBackgroundImageCommandTest >> targetContainers [ ^ { @@ -34,7 +34,7 @@ PyramidBackgroundImageCommandTest >> targetContainers [ prop: (Smalltalk ui icons iconNamed: #pharoBig)) } ] -{ #category : #'as yet unclassified' } +{ #category : #accessing } PyramidBackgroundImageCommandTest >> targetsCannotBeUsedFor [ "override if needed" diff --git a/src/Pyramid-Tests/PyramidBackgroundOpacityCommandTest.class.st b/src/Pyramid-Tests/PyramidBackgroundOpacityCommandTest.class.st index 6f01df3d..32d70ba5 100644 --- a/src/Pyramid-Tests/PyramidBackgroundOpacityCommandTest.class.st +++ b/src/Pyramid-Tests/PyramidBackgroundOpacityCommandTest.class.st @@ -26,7 +26,7 @@ PyramidBackgroundOpacityCommandTest >> isBlBackgroundEqualityFix [ ^ e background == b2 ] -{ #category : #'as yet unclassified' } +{ #category : #accessing } PyramidBackgroundOpacityCommandTest >> targetContainers [ ^ { diff --git a/src/Pyramid-Tests/PyramidBackgroundPaintColorCommandTest.class.st b/src/Pyramid-Tests/PyramidBackgroundPaintColorCommandTest.class.st index ea72a86d..8312b04b 100644 --- a/src/Pyramid-Tests/PyramidBackgroundPaintColorCommandTest.class.st +++ b/src/Pyramid-Tests/PyramidBackgroundPaintColorCommandTest.class.st @@ -12,7 +12,7 @@ PyramidBackgroundPaintColorCommandTest >> command [ ^ PyramidBackgroundPaintColorCommand new ] -{ #category : #'as yet unclassified' } +{ #category : #accessing } PyramidBackgroundPaintColorCommandTest >> targetContainers [ ^ { @@ -35,7 +35,7 @@ PyramidBackgroundPaintColorCommandTest >> targetContainers [ } ] -{ #category : #'as yet unclassified' } +{ #category : #accessing } PyramidBackgroundPaintColorCommandTest >> targetsCannotBeUsedFor [ "override if needed" diff --git a/src/Pyramid-Tests/PyramidBackgroundPaintCommandTest.class.st b/src/Pyramid-Tests/PyramidBackgroundPaintCommandTest.class.st index 949a9ab7..fcbb4cbc 100644 --- a/src/Pyramid-Tests/PyramidBackgroundPaintCommandTest.class.st +++ b/src/Pyramid-Tests/PyramidBackgroundPaintCommandTest.class.st @@ -12,7 +12,7 @@ PyramidBackgroundPaintCommandTest >> command [ ^ PyramidBackgroundPaintCommand new ] -{ #category : #'as yet unclassified' } +{ #category : #accessing } PyramidBackgroundPaintCommandTest >> targetContainers [ ^ {(PyramidCommandTestContainer diff --git a/src/Pyramid-Tests/PyramidBackgroundPaintLinearEndCommandTest.class.st b/src/Pyramid-Tests/PyramidBackgroundPaintLinearEndCommandTest.class.st index 116912ab..f2a1768b 100644 --- a/src/Pyramid-Tests/PyramidBackgroundPaintLinearEndCommandTest.class.st +++ b/src/Pyramid-Tests/PyramidBackgroundPaintLinearEndCommandTest.class.st @@ -12,7 +12,7 @@ PyramidBackgroundPaintLinearEndCommandTest >> command [ ^ PyramidBackgroundPaintLinearEndCommand new ] -{ #category : #'as yet unclassified' } +{ #category : #accessing } PyramidBackgroundPaintLinearEndCommandTest >> targetContainers [ ^ { @@ -58,7 +58,7 @@ PyramidBackgroundPaintLinearEndCommandTest >> targetContainers [ prop: 0 @ 0) } ] -{ #category : #'as yet unclassified' } +{ #category : #accessing } PyramidBackgroundPaintLinearEndCommandTest >> targetsCannotBeUsedFor [ "override if needed" diff --git a/src/Pyramid-Tests/PyramidBackgroundPaintLinearStartCommandTest.class.st b/src/Pyramid-Tests/PyramidBackgroundPaintLinearStartCommandTest.class.st index 31caf284..b6f99ab7 100644 --- a/src/Pyramid-Tests/PyramidBackgroundPaintLinearStartCommandTest.class.st +++ b/src/Pyramid-Tests/PyramidBackgroundPaintLinearStartCommandTest.class.st @@ -12,7 +12,7 @@ PyramidBackgroundPaintLinearStartCommandTest >> command [ ^ PyramidBackgroundPaintLinearStartCommand new ] -{ #category : #'as yet unclassified' } +{ #category : #accessing } PyramidBackgroundPaintLinearStartCommandTest >> targetContainers [ ^ { @@ -58,7 +58,7 @@ PyramidBackgroundPaintLinearStartCommandTest >> targetContainers [ prop: 0 @ 10) } ] -{ #category : #'as yet unclassified' } +{ #category : #accessing } PyramidBackgroundPaintLinearStartCommandTest >> targetsCannotBeUsedFor [ "override if needed" diff --git a/src/Pyramid-Tests/PyramidBackgroundPaintRadialInnerCenterCommandTest.class.st b/src/Pyramid-Tests/PyramidBackgroundPaintRadialInnerCenterCommandTest.class.st index aac47749..402c74b6 100644 --- a/src/Pyramid-Tests/PyramidBackgroundPaintRadialInnerCenterCommandTest.class.st +++ b/src/Pyramid-Tests/PyramidBackgroundPaintRadialInnerCenterCommandTest.class.st @@ -12,7 +12,7 @@ PyramidBackgroundPaintRadialInnerCenterCommandTest >> command [ ^ PyramidBackgroundPaintRadialInnerCenterCommand new ] -{ #category : #'as yet unclassified' } +{ #category : #accessing } PyramidBackgroundPaintRadialInnerCenterCommandTest >> targetContainers [ ^ { @@ -66,7 +66,7 @@ PyramidBackgroundPaintRadialInnerCenterCommandTest >> targetContainers [ prop: 500 asPoint) } ] -{ #category : #'as yet unclassified' } +{ #category : #accessing } PyramidBackgroundPaintRadialInnerCenterCommandTest >> targetsCannotBeUsedFor [ "override if needed" diff --git a/src/Pyramid-Tests/PyramidBackgroundPaintRadialInnerRadiusCommandTest.class.st b/src/Pyramid-Tests/PyramidBackgroundPaintRadialInnerRadiusCommandTest.class.st index b9bfbd44..63231a90 100644 --- a/src/Pyramid-Tests/PyramidBackgroundPaintRadialInnerRadiusCommandTest.class.st +++ b/src/Pyramid-Tests/PyramidBackgroundPaintRadialInnerRadiusCommandTest.class.st @@ -12,7 +12,7 @@ PyramidBackgroundPaintRadialInnerRadiusCommandTest >> command [ ^ PyramidBackgroundPaintRadialInnerRadiusCommand new ] -{ #category : #'as yet unclassified' } +{ #category : #accessing } PyramidBackgroundPaintRadialInnerRadiusCommandTest >> targetContainers [ ^ { @@ -66,7 +66,7 @@ PyramidBackgroundPaintRadialInnerRadiusCommandTest >> targetContainers [ prop: 600) } ] -{ #category : #'as yet unclassified' } +{ #category : #accessing } PyramidBackgroundPaintRadialInnerRadiusCommandTest >> targetsCannotBeUsedFor [ "override if needed" diff --git a/src/Pyramid-Tests/PyramidBackgroundPaintRadialOuterCenterCommandTest.class.st b/src/Pyramid-Tests/PyramidBackgroundPaintRadialOuterCenterCommandTest.class.st index ba329f0d..2d8175df 100644 --- a/src/Pyramid-Tests/PyramidBackgroundPaintRadialOuterCenterCommandTest.class.st +++ b/src/Pyramid-Tests/PyramidBackgroundPaintRadialOuterCenterCommandTest.class.st @@ -12,7 +12,7 @@ PyramidBackgroundPaintRadialOuterCenterCommandTest >> command [ ^ PyramidBackgroundPaintRadialOuterCenterCommand new ] -{ #category : #'as yet unclassified' } +{ #category : #accessing } PyramidBackgroundPaintRadialOuterCenterCommandTest >> targetContainers [ ^ { @@ -66,7 +66,7 @@ PyramidBackgroundPaintRadialOuterCenterCommandTest >> targetContainers [ prop: 500 asPoint) } ] -{ #category : #'as yet unclassified' } +{ #category : #accessing } PyramidBackgroundPaintRadialOuterCenterCommandTest >> targetsCannotBeUsedFor [ "override if needed" diff --git a/src/Pyramid-Tests/PyramidBackgroundPaintRadialOuterRadiusCommandTest.class.st b/src/Pyramid-Tests/PyramidBackgroundPaintRadialOuterRadiusCommandTest.class.st index 742ef40e..179e1144 100644 --- a/src/Pyramid-Tests/PyramidBackgroundPaintRadialOuterRadiusCommandTest.class.st +++ b/src/Pyramid-Tests/PyramidBackgroundPaintRadialOuterRadiusCommandTest.class.st @@ -12,7 +12,7 @@ PyramidBackgroundPaintRadialOuterRadiusCommandTest >> command [ ^ PyramidBackgroundPaintRadialOuterRadiusCommand new ] -{ #category : #'as yet unclassified' } +{ #category : #accessing } PyramidBackgroundPaintRadialOuterRadiusCommandTest >> targetContainers [ ^ { @@ -58,7 +58,7 @@ PyramidBackgroundPaintRadialOuterRadiusCommandTest >> targetContainers [ prop: 600) } ] -{ #category : #'as yet unclassified' } +{ #category : #accessing } PyramidBackgroundPaintRadialOuterRadiusCommandTest >> targetsCannotBeUsedFor [ "override if needed" diff --git a/src/Pyramid-Tests/PyramidBackgroundPaintStopsCommandTest.class.st b/src/Pyramid-Tests/PyramidBackgroundPaintStopsCommandTest.class.st index 284afe89..d8ed51e3 100644 --- a/src/Pyramid-Tests/PyramidBackgroundPaintStopsCommandTest.class.st +++ b/src/Pyramid-Tests/PyramidBackgroundPaintStopsCommandTest.class.st @@ -12,7 +12,7 @@ PyramidBackgroundPaintStopsCommandTest >> command [ ^ PyramidBackgroundPaintStopsCommand new ] -{ #category : #'as yet unclassified' } +{ #category : #accessing } PyramidBackgroundPaintStopsCommandTest >> targetContainers [ ^ { @@ -87,7 +87,7 @@ PyramidBackgroundPaintStopsCommandTest >> targetContainers [ } ] -{ #category : #'as yet unclassified' } +{ #category : #accessing } PyramidBackgroundPaintStopsCommandTest >> targetsCannotBeUsedFor [ "override if needed" diff --git a/src/Pyramid-Tests/PyramidBackgroundTypeCommandTest.class.st b/src/Pyramid-Tests/PyramidBackgroundTypeCommandTest.class.st index b3c75e7b..b8f703c7 100644 --- a/src/Pyramid-Tests/PyramidBackgroundTypeCommandTest.class.st +++ b/src/Pyramid-Tests/PyramidBackgroundTypeCommandTest.class.st @@ -12,7 +12,7 @@ PyramidBackgroundTypeCommandTest >> command [ ^ PyramidBackgroundTypeCommand new ] -{ #category : #'as yet unclassified' } +{ #category : #accessing } PyramidBackgroundTypeCommandTest >> targetContainers [ ^ { diff --git a/src/Pyramid-Tests/PyramidBasicExactHorizontalConstraintsBlocCommandTest.class.st b/src/Pyramid-Tests/PyramidBasicExactHorizontalConstraintsBlocCommandTest.class.st index ddb32c3c..c5252455 100644 --- a/src/Pyramid-Tests/PyramidBasicExactHorizontalConstraintsBlocCommandTest.class.st +++ b/src/Pyramid-Tests/PyramidBasicExactHorizontalConstraintsBlocCommandTest.class.st @@ -12,7 +12,7 @@ PyramidBasicExactHorizontalConstraintsBlocCommandTest >> command [ ^ PyramidBasicExactHorizontalConstraintsBlocCommand new ] -{ #category : #'as yet unclassified' } +{ #category : #accessing } PyramidBasicExactHorizontalConstraintsBlocCommandTest >> targetContainers [ | p1 a1 b1 p2 a2 b2 | @@ -42,7 +42,7 @@ PyramidBasicExactHorizontalConstraintsBlocCommandTest >> targetContainers [ (PyramidCommandTestContainer no: a2 with: b2 prop: 600) } ] -{ #category : #'as yet unclassified' } +{ #category : #accessing } PyramidBasicExactHorizontalConstraintsBlocCommandTest >> targetsCannotBeUsedFor [ "override if needed" diff --git a/src/Pyramid-Tests/PyramidBasicExactVerticalConstraintsBlocCommandTest.class.st b/src/Pyramid-Tests/PyramidBasicExactVerticalConstraintsBlocCommandTest.class.st index a1165f8e..db990f7f 100644 --- a/src/Pyramid-Tests/PyramidBasicExactVerticalConstraintsBlocCommandTest.class.st +++ b/src/Pyramid-Tests/PyramidBasicExactVerticalConstraintsBlocCommandTest.class.st @@ -12,7 +12,7 @@ PyramidBasicExactVerticalConstraintsBlocCommandTest >> command [ ^ PyramidBasicExactVerticalConstraintsBlocCommand new ] -{ #category : #'as yet unclassified' } +{ #category : #accessing } PyramidBasicExactVerticalConstraintsBlocCommandTest >> targetContainers [ | p1 a1 b1 p2 a2 b2 | @@ -44,7 +44,7 @@ PyramidBasicExactVerticalConstraintsBlocCommandTest >> targetContainers [ (PyramidCommandTestContainer no: a2 with: b2 prop: 100) } ] -{ #category : #'as yet unclassified' } +{ #category : #accessing } PyramidBasicExactVerticalConstraintsBlocCommandTest >> targetsCannotBeUsedFor [ "override if needed" diff --git a/src/Pyramid-Tests/PyramidBasicHorizontalConstraintsBlocCommandTest.class.st b/src/Pyramid-Tests/PyramidBasicHorizontalConstraintsBlocCommandTest.class.st index 0c34c59c..1acbfbab 100644 --- a/src/Pyramid-Tests/PyramidBasicHorizontalConstraintsBlocCommandTest.class.st +++ b/src/Pyramid-Tests/PyramidBasicHorizontalConstraintsBlocCommandTest.class.st @@ -12,7 +12,7 @@ PyramidBasicHorizontalConstraintsBlocCommandTest >> command [ ^ PyramidBasicHorizontalConstraintsBlocCommand new ] -{ #category : #'as yet unclassified' } +{ #category : #accessing } PyramidBasicHorizontalConstraintsBlocCommandTest >> targetContainers [ | p1 a1 b1 c1 d1 p2 a2 b2 c2 d2 | @@ -56,7 +56,7 @@ PyramidBasicHorizontalConstraintsBlocCommandTest >> targetContainers [ (PyramidCommandTestContainer no: a2 with: d2 prop: #matchParent) } ] -{ #category : #'as yet unclassified' } +{ #category : #accessing } PyramidBasicHorizontalConstraintsBlocCommandTest >> targetsCannotBeUsedFor [ "override if needed" diff --git a/src/Pyramid-Tests/PyramidBasicVerticalConstraintsBlocCommandTest.class.st b/src/Pyramid-Tests/PyramidBasicVerticalConstraintsBlocCommandTest.class.st index 6bd1493e..aca41fd1 100644 --- a/src/Pyramid-Tests/PyramidBasicVerticalConstraintsBlocCommandTest.class.st +++ b/src/Pyramid-Tests/PyramidBasicVerticalConstraintsBlocCommandTest.class.st @@ -12,7 +12,7 @@ PyramidBasicVerticalConstraintsBlocCommandTest >> command [ ^ PyramidBasicVerticalConstraintsBlocCommand new ] -{ #category : #'as yet unclassified' } +{ #category : #accessing } PyramidBasicVerticalConstraintsBlocCommandTest >> targetContainers [ | p1 a1 b1 c1 d1 p2 a2 b2 c2 d2 | @@ -56,7 +56,7 @@ PyramidBasicVerticalConstraintsBlocCommandTest >> targetContainers [ (PyramidCommandTestContainer no: a2 with: d2 prop: #matchParent) } ] -{ #category : #'as yet unclassified' } +{ #category : #accessing } PyramidBasicVerticalConstraintsBlocCommandTest >> targetsCannotBeUsedFor [ "override if needed" diff --git a/src/Pyramid-Tests/PyramidBorderDashArrayCommandTest.class.st b/src/Pyramid-Tests/PyramidBorderDashArrayCommandTest.class.st index 618ef42f..64e5d04c 100644 --- a/src/Pyramid-Tests/PyramidBorderDashArrayCommandTest.class.st +++ b/src/Pyramid-Tests/PyramidBorderDashArrayCommandTest.class.st @@ -12,7 +12,7 @@ PyramidBorderDashArrayCommandTest >> command [ ^ PyramidBorderDashArrayCommand new ] -{ #category : #'as yet unclassified' } +{ #category : #accessing } PyramidBorderDashArrayCommandTest >> targetContainers [ ^ { diff --git a/src/Pyramid-Tests/PyramidBorderDashOffsetCommandTest.class.st b/src/Pyramid-Tests/PyramidBorderDashOffsetCommandTest.class.st index a7d65f33..ce8b116c 100644 --- a/src/Pyramid-Tests/PyramidBorderDashOffsetCommandTest.class.st +++ b/src/Pyramid-Tests/PyramidBorderDashOffsetCommandTest.class.st @@ -12,7 +12,7 @@ PyramidBorderDashOffsetCommandTest >> command [ ^ PyramidBorderDashOffsetCommand new ] -{ #category : #'as yet unclassified' } +{ #category : #accessing } PyramidBorderDashOffsetCommandTest >> targetContainers [ ^ { diff --git a/src/Pyramid-Tests/PyramidBorderLineCapCommandTest.class.st b/src/Pyramid-Tests/PyramidBorderLineCapCommandTest.class.st index dce90ad7..9567d36d 100644 --- a/src/Pyramid-Tests/PyramidBorderLineCapCommandTest.class.st +++ b/src/Pyramid-Tests/PyramidBorderLineCapCommandTest.class.st @@ -12,7 +12,7 @@ PyramidBorderLineCapCommandTest >> command [ ^ PyramidBorderLineCapCommand new ] -{ #category : #'as yet unclassified' } +{ #category : #accessing } PyramidBorderLineCapCommandTest >> targetContainers [ ^ { diff --git a/src/Pyramid-Tests/PyramidBorderLineJoinCommandTest.class.st b/src/Pyramid-Tests/PyramidBorderLineJoinCommandTest.class.st index fef84f1f..8b25b0e1 100644 --- a/src/Pyramid-Tests/PyramidBorderLineJoinCommandTest.class.st +++ b/src/Pyramid-Tests/PyramidBorderLineJoinCommandTest.class.st @@ -12,7 +12,7 @@ PyramidBorderLineJoinCommandTest >> command [ ^ PyramidBorderLineJoinCommand new ] -{ #category : #'as yet unclassified' } +{ #category : #accessing } PyramidBorderLineJoinCommandTest >> targetContainers [ ^ { diff --git a/src/Pyramid-Tests/PyramidBorderMiterLimitCommandTest.class.st b/src/Pyramid-Tests/PyramidBorderMiterLimitCommandTest.class.st index f4ddb511..c97c1afa 100644 --- a/src/Pyramid-Tests/PyramidBorderMiterLimitCommandTest.class.st +++ b/src/Pyramid-Tests/PyramidBorderMiterLimitCommandTest.class.st @@ -12,7 +12,7 @@ PyramidBorderMiterLimitCommandTest >> command [ ^ PyramidBorderMiterLimitCommand new ] -{ #category : #'as yet unclassified' } +{ #category : #accessing } PyramidBorderMiterLimitCommandTest >> targetContainers [ ^ { diff --git a/src/Pyramid-Tests/PyramidBorderOpacityCommandTest.class.st b/src/Pyramid-Tests/PyramidBorderOpacityCommandTest.class.st index 77ba3328..e6cdffb0 100644 --- a/src/Pyramid-Tests/PyramidBorderOpacityCommandTest.class.st +++ b/src/Pyramid-Tests/PyramidBorderOpacityCommandTest.class.st @@ -12,7 +12,7 @@ PyramidBorderOpacityCommandTest >> command [ ^ PyramidBorderOpacityCommand new ] -{ #category : #'as yet unclassified' } +{ #category : #accessing } PyramidBorderOpacityCommandTest >> targetContainers [ ^ { diff --git a/src/Pyramid-Tests/PyramidBorderTypeCommandTest.class.st b/src/Pyramid-Tests/PyramidBorderTypeCommandTest.class.st index cc091120..72f3111e 100644 --- a/src/Pyramid-Tests/PyramidBorderTypeCommandTest.class.st +++ b/src/Pyramid-Tests/PyramidBorderTypeCommandTest.class.st @@ -12,7 +12,7 @@ PyramidBorderTypeCommandTest >> command [ ^ PyramidBorderPaintCommand new ] -{ #category : #'as yet unclassified' } +{ #category : #accessing } PyramidBorderTypeCommandTest >> targetContainers [ ^ { diff --git a/src/Pyramid-Tests/PyramidChangeOrderWithIndexCommandTest.class.st b/src/Pyramid-Tests/PyramidChangeOrderWithIndexCommandTest.class.st index 3f304800..046812b1 100644 --- a/src/Pyramid-Tests/PyramidChangeOrderWithIndexCommandTest.class.st +++ b/src/Pyramid-Tests/PyramidChangeOrderWithIndexCommandTest.class.st @@ -35,7 +35,7 @@ PyramidChangeOrderWithIndexCommandTest >> makeElementWithChildren [ ^ parent ] -{ #category : #'as yet unclassified' } +{ #category : #accessing } PyramidChangeOrderWithIndexCommandTest >> targetContainers [ | test1 test2 test3 test4 test5 test6 | @@ -73,7 +73,7 @@ PyramidChangeOrderWithIndexCommandTest >> targetContainers [ prop: 1) } ] -{ #category : #'as yet unclassified' } +{ #category : #accessing } PyramidChangeOrderWithIndexCommandTest >> targetsCanBeUsedFor [ ^ self targetContainers flatCollect: [ :each | diff --git a/src/Pyramid-Tests/PyramidChangeTextCommandTest.class.st b/src/Pyramid-Tests/PyramidChangeTextCommandTest.class.st index 18dd1eb5..bb1b4974 100644 --- a/src/Pyramid-Tests/PyramidChangeTextCommandTest.class.st +++ b/src/Pyramid-Tests/PyramidChangeTextCommandTest.class.st @@ -12,7 +12,7 @@ PyramidChangeTextCommandTest >> command [ ^ PyramidChangeTextCommand new ] -{ #category : #'as yet unclassified' } +{ #category : #accessing } PyramidChangeTextCommandTest >> targetContainers [ ^ { diff --git a/src/Pyramid-Tests/PyramidClipChildrenCommandTest.class.st b/src/Pyramid-Tests/PyramidClipChildrenCommandTest.class.st index 07f02a09..c3ddf1e5 100644 --- a/src/Pyramid-Tests/PyramidClipChildrenCommandTest.class.st +++ b/src/Pyramid-Tests/PyramidClipChildrenCommandTest.class.st @@ -12,7 +12,7 @@ PyramidClipChildrenCommandTest >> command [ ^ PyramidClipChildrenCommand new ] -{ #category : #'as yet unclassified' } +{ #category : #accessing } PyramidClipChildrenCommandTest >> targetContainers [ ^ { diff --git a/src/Pyramid-Tests/PyramidElementIdCommandTest.class.st b/src/Pyramid-Tests/PyramidElementIdCommandTest.class.st index b235dc3b..4b3d132a 100644 --- a/src/Pyramid-Tests/PyramidElementIdCommandTest.class.st +++ b/src/Pyramid-Tests/PyramidElementIdCommandTest.class.st @@ -12,7 +12,7 @@ PyramidElementIdCommandTest >> command [ ^ PyramidElementIdCommand new ] -{ #category : #'as yet unclassified' } +{ #category : #accessing } PyramidElementIdCommandTest >> targetContainers [ diff --git a/src/Pyramid-Tests/PyramidFontSizeCommandTest.class.st b/src/Pyramid-Tests/PyramidFontSizeCommandTest.class.st index effab2f4..343ce6e3 100644 --- a/src/Pyramid-Tests/PyramidFontSizeCommandTest.class.st +++ b/src/Pyramid-Tests/PyramidFontSizeCommandTest.class.st @@ -18,7 +18,7 @@ PyramidFontSizeCommandTest >> command [ ^ PyramidFontSizeCommand new ] -{ #category : #'as yet unclassified' } +{ #category : #accessing } PyramidFontSizeCommandTest >> targetContainers [ ^ { diff --git a/src/Pyramid-Tests/PyramidFontWeightCommandTest.class.st b/src/Pyramid-Tests/PyramidFontWeightCommandTest.class.st index ca2f6b2e..1b5bfb98 100644 --- a/src/Pyramid-Tests/PyramidFontWeightCommandTest.class.st +++ b/src/Pyramid-Tests/PyramidFontWeightCommandTest.class.st @@ -18,7 +18,7 @@ PyramidFontWeightCommandTest >> command [ ^ PyramidFontWeightCommand new ] -{ #category : #'as yet unclassified' } +{ #category : #accessing } PyramidFontWeightCommandTest >> targetContainers [ ^ { diff --git a/src/Pyramid-Tests/PyramidGeometryCommandTest.class.st b/src/Pyramid-Tests/PyramidGeometryCommandTest.class.st index 070c4ad8..1cefa683 100644 --- a/src/Pyramid-Tests/PyramidGeometryCommandTest.class.st +++ b/src/Pyramid-Tests/PyramidGeometryCommandTest.class.st @@ -12,7 +12,7 @@ PyramidGeometryCommandTest >> command [ ^ PyramidGeometryCommand new ] -{ #category : #'as yet unclassified' } +{ #category : #accessing } PyramidGeometryCommandTest >> targetContainers [ ^ { diff --git a/src/Pyramid-Tests/PyramidLayoutBlocCommandTest.class.st b/src/Pyramid-Tests/PyramidLayoutBlocCommandTest.class.st index 9da98d0b..a1c5f317 100644 --- a/src/Pyramid-Tests/PyramidLayoutBlocCommandTest.class.st +++ b/src/Pyramid-Tests/PyramidLayoutBlocCommandTest.class.st @@ -12,7 +12,7 @@ PyramidLayoutBlocCommandTest >> command [ ^ PyramidLayoutBlocCommand new ] -{ #category : #'as yet unclassified' } +{ #category : #accessing } PyramidLayoutBlocCommandTest >> targetContainers [ | flowLayoutVertical basicLayout proportionalLayout | @@ -43,7 +43,7 @@ PyramidLayoutBlocCommandTest >> targetContainers [ prop: proportionalLayout) } ] -{ #category : #'as yet unclassified' } +{ #category : #accessing } PyramidLayoutBlocCommandTest >> targetsCanBeUsedFor [ ^ self targetContainers collect: [ :each | each targetNoProp ]. diff --git a/src/Pyramid-Tests/PyramidLayoutChangeOrientationCommandTest.class.st b/src/Pyramid-Tests/PyramidLayoutChangeOrientationCommandTest.class.st index b0e2e9e5..20cc4bcf 100644 --- a/src/Pyramid-Tests/PyramidLayoutChangeOrientationCommandTest.class.st +++ b/src/Pyramid-Tests/PyramidLayoutChangeOrientationCommandTest.class.st @@ -12,7 +12,7 @@ PyramidLayoutChangeOrientationCommandTest >> command [ ^ PyramidLayoutChangeOrientationCommand new ] -{ #category : #'as yet unclassified' } +{ #category : #accessing } PyramidLayoutChangeOrientationCommandTest >> targetContainers [ ^ { (PyramidCommandTestContainer @@ -49,7 +49,7 @@ PyramidLayoutChangeOrientationCommandTest >> targetContainers [ prop: BlLayoutOrientation horizontal) } ] -{ #category : #'as yet unclassified' } +{ #category : #accessing } PyramidLayoutChangeOrientationCommandTest >> targetsCannotBeUsedFor [ "override if needed" diff --git a/src/Pyramid-Tests/PyramidMarginCommandTest.class.st b/src/Pyramid-Tests/PyramidMarginCommandTest.class.st index 1ff7ea4b..5f6771c5 100644 --- a/src/Pyramid-Tests/PyramidMarginCommandTest.class.st +++ b/src/Pyramid-Tests/PyramidMarginCommandTest.class.st @@ -12,7 +12,7 @@ PyramidMarginCommandTest >> command [ ^ PyramidMarginCommand new ] -{ #category : #'as yet unclassified' } +{ #category : #accessing } PyramidMarginCommandTest >> targetContainers [ ^ { diff --git a/src/Pyramid-Tests/PyramidMoveBackwardOrderCommandTest.class.st b/src/Pyramid-Tests/PyramidMoveBackwardOrderCommandTest.class.st index beae1f5e..9c0a4d77 100644 --- a/src/Pyramid-Tests/PyramidMoveBackwardOrderCommandTest.class.st +++ b/src/Pyramid-Tests/PyramidMoveBackwardOrderCommandTest.class.st @@ -6,7 +6,7 @@ Class { #category : #'Pyramid-Tests-cases-plugin-bloc-order' } -{ #category : #'as yet unclassified' } +{ #category : #accessing } PyramidMoveBackwardOrderCommandTest >> argumentsForHistory [ ^ { 3. 2. 1 } @@ -30,7 +30,7 @@ PyramidMoveBackwardOrderCommandTest >> makeElementWithChildren [ ^ parent ] -{ #category : #'as yet unclassified' } +{ #category : #accessing } PyramidMoveBackwardOrderCommandTest >> targetContainers [ | test1 test2 test3 | @@ -53,7 +53,7 @@ PyramidMoveBackwardOrderCommandTest >> targetContainers [ prop: 3) } ] -{ #category : #'as yet unclassified' } +{ #category : #accessing } PyramidMoveBackwardOrderCommandTest >> targetsCanBeUsedFor [ ^ self targetContainers flatCollect: [ :each | @@ -61,7 +61,7 @@ PyramidMoveBackwardOrderCommandTest >> targetsCanBeUsedFor [ each targetNoProp } ] ] -{ #category : #'as yet unclassified' } +{ #category : #accessing } PyramidMoveBackwardOrderCommandTest >> targetsCannotBeUsedFor [ "override if needed" diff --git a/src/Pyramid-Tests/PyramidMoveForwardOrderCommandTest.class.st b/src/Pyramid-Tests/PyramidMoveForwardOrderCommandTest.class.st index 876ebefa..0cbc4141 100644 --- a/src/Pyramid-Tests/PyramidMoveForwardOrderCommandTest.class.st +++ b/src/Pyramid-Tests/PyramidMoveForwardOrderCommandTest.class.st @@ -6,7 +6,7 @@ Class { #category : #'Pyramid-Tests-cases-plugin-bloc-order' } -{ #category : #'as yet unclassified' } +{ #category : #accessing } PyramidMoveForwardOrderCommandTest >> argumentsForHistory [ ^ { 1 . 2 . 3 } @@ -30,7 +30,7 @@ PyramidMoveForwardOrderCommandTest >> makeElementWithChildren [ ^ parent ] -{ #category : #'as yet unclassified' } +{ #category : #accessing } PyramidMoveForwardOrderCommandTest >> targetContainers [ | test1 test2 test3 | @@ -53,7 +53,7 @@ PyramidMoveForwardOrderCommandTest >> targetContainers [ prop: 3) } ] -{ #category : #'as yet unclassified' } +{ #category : #accessing } PyramidMoveForwardOrderCommandTest >> targetsCanBeUsedFor [ ^ self targetContainers flatCollect: [ :each | @@ -61,7 +61,7 @@ PyramidMoveForwardOrderCommandTest >> targetsCanBeUsedFor [ each targetNoProp } ] ] -{ #category : #'as yet unclassified' } +{ #category : #accessing } PyramidMoveForwardOrderCommandTest >> targetsCannotBeUsedFor [ "override if needed" diff --git a/src/Pyramid-Tests/PyramidOnBackgroundOrderCommandTest.class.st b/src/Pyramid-Tests/PyramidOnBackgroundOrderCommandTest.class.st index 0e57fc9e..5af89655 100644 --- a/src/Pyramid-Tests/PyramidOnBackgroundOrderCommandTest.class.st +++ b/src/Pyramid-Tests/PyramidOnBackgroundOrderCommandTest.class.st @@ -35,7 +35,7 @@ PyramidOnBackgroundOrderCommandTest >> makeElementWithChildren [ ^ parent ] -{ #category : #'as yet unclassified' } +{ #category : #accessing } PyramidOnBackgroundOrderCommandTest >> targetContainers [ | test1 test2 test3 | @@ -58,7 +58,7 @@ PyramidOnBackgroundOrderCommandTest >> targetContainers [ prop: 1) } ] -{ #category : #'as yet unclassified' } +{ #category : #accessing } PyramidOnBackgroundOrderCommandTest >> targetsCanBeUsedFor [ ^ self targetContainers flatCollect: [ :each | diff --git a/src/Pyramid-Tests/PyramidOnForegroundOrderCommandTest.class.st b/src/Pyramid-Tests/PyramidOnForegroundOrderCommandTest.class.st index dfd10ec8..329c9857 100644 --- a/src/Pyramid-Tests/PyramidOnForegroundOrderCommandTest.class.st +++ b/src/Pyramid-Tests/PyramidOnForegroundOrderCommandTest.class.st @@ -35,7 +35,7 @@ PyramidOnForegroundOrderCommandTest >> makeElementWithChildren [ ^ parent ] -{ #category : #'as yet unclassified' } +{ #category : #accessing } PyramidOnForegroundOrderCommandTest >> targetContainers [ | test1 test2 test3 | @@ -58,7 +58,7 @@ PyramidOnForegroundOrderCommandTest >> targetContainers [ prop: 3) } ] -{ #category : #'as yet unclassified' } +{ #category : #accessing } PyramidOnForegroundOrderCommandTest >> targetsCanBeUsedFor [ ^ self targetContainers flatCollect: [ :each | diff --git a/src/Pyramid-Tests/PyramidOpacityCommandTest.class.st b/src/Pyramid-Tests/PyramidOpacityCommandTest.class.st index 15abba92..90043941 100644 --- a/src/Pyramid-Tests/PyramidOpacityCommandTest.class.st +++ b/src/Pyramid-Tests/PyramidOpacityCommandTest.class.st @@ -12,7 +12,7 @@ PyramidOpacityCommandTest >> command [ ^ PyramidOpacityCommand new ] -{ #category : #'as yet unclassified' } +{ #category : #accessing } PyramidOpacityCommandTest >> targetContainers [ | e1 e2 | diff --git a/src/Pyramid-Tests/PyramidPaddingCommandTest.class.st b/src/Pyramid-Tests/PyramidPaddingCommandTest.class.st index 842a6e73..25058fe6 100644 --- a/src/Pyramid-Tests/PyramidPaddingCommandTest.class.st +++ b/src/Pyramid-Tests/PyramidPaddingCommandTest.class.st @@ -12,7 +12,7 @@ PyramidPaddingCommandTest >> command [ ^ PyramidPaddingCommand new ] -{ #category : #'as yet unclassified' } +{ #category : #accessing } PyramidPaddingCommandTest >> targetContainers [ ^ { diff --git a/src/Pyramid-Tests/PyramidPositionCommandTest.class.st b/src/Pyramid-Tests/PyramidPositionCommandTest.class.st index 596e92eb..0d5784d3 100644 --- a/src/Pyramid-Tests/PyramidPositionCommandTest.class.st +++ b/src/Pyramid-Tests/PyramidPositionCommandTest.class.st @@ -12,7 +12,7 @@ PyramidPositionCommandTest >> command [ ^ PyramidPositionCommand new ] -{ #category : #'as yet unclassified' } +{ #category : #accessing } PyramidPositionCommandTest >> targetContainers [ ^ { diff --git a/src/Pyramid-Tests/PyramidPositionOffsetCommandTest.class.st b/src/Pyramid-Tests/PyramidPositionOffsetCommandTest.class.st index 34285057..bf3c08a8 100644 --- a/src/Pyramid-Tests/PyramidPositionOffsetCommandTest.class.st +++ b/src/Pyramid-Tests/PyramidPositionOffsetCommandTest.class.st @@ -12,7 +12,7 @@ PyramidPositionOffsetCommandTest >> command [ ^ PyramidPositionOffsetCommand new ] -{ #category : #'as yet unclassified' } +{ #category : #accessing } PyramidPositionOffsetCommandTest >> targetContainers [ ^ { diff --git a/src/Pyramid-Tests/PyramidProportionnalHorizontalConstraintsCommandTest.class.st b/src/Pyramid-Tests/PyramidProportionnalHorizontalConstraintsCommandTest.class.st index 40e93624..1da847b8 100644 --- a/src/Pyramid-Tests/PyramidProportionnalHorizontalConstraintsCommandTest.class.st +++ b/src/Pyramid-Tests/PyramidProportionnalHorizontalConstraintsCommandTest.class.st @@ -12,7 +12,7 @@ PyramidProportionnalHorizontalConstraintsCommandTest >> command [ ^ PyramidProportionalHorizontalConstraintsCommand new ] -{ #category : #'as yet unclassified' } +{ #category : #accessing } PyramidProportionnalHorizontalConstraintsCommandTest >> targetContainers [ | parent e1 e2 | @@ -31,7 +31,7 @@ PyramidProportionnalHorizontalConstraintsCommandTest >> targetContainers [ prop: 0.2 @ 0.4)} ] -{ #category : #'as yet unclassified' } +{ #category : #accessing } PyramidProportionnalHorizontalConstraintsCommandTest >> targetsCannotBeUsedFor [ "override if needed" diff --git a/src/Pyramid-Tests/PyramidProportionnalVerticalConstraintsCommandTest.class.st b/src/Pyramid-Tests/PyramidProportionnalVerticalConstraintsCommandTest.class.st index 81496cc8..7797a248 100644 --- a/src/Pyramid-Tests/PyramidProportionnalVerticalConstraintsCommandTest.class.st +++ b/src/Pyramid-Tests/PyramidProportionnalVerticalConstraintsCommandTest.class.st @@ -12,7 +12,7 @@ PyramidProportionnalVerticalConstraintsCommandTest >> command [ ^ PyramidProportionalVerticalConstraintsCommand new ] -{ #category : #'as yet unclassified' } +{ #category : #accessing } PyramidProportionnalVerticalConstraintsCommandTest >> targetContainers [ | parent e1 e2 | @@ -35,7 +35,7 @@ PyramidProportionnalVerticalConstraintsCommandTest >> targetContainers [ ^ { (PyramidCommandTestContainer no: e1 with: e2 prop: 0.3 @ 0.6) } ] -{ #category : #'as yet unclassified' } +{ #category : #accessing } PyramidProportionnalVerticalConstraintsCommandTest >> targetsCannotBeUsedFor [ "override if needed" diff --git a/src/Pyramid-Tests/PyramidRemoveChildCommandTest.class.st b/src/Pyramid-Tests/PyramidRemoveChildCommandTest.class.st index 30f24257..923c5ca1 100644 --- a/src/Pyramid-Tests/PyramidRemoveChildCommandTest.class.st +++ b/src/Pyramid-Tests/PyramidRemoveChildCommandTest.class.st @@ -12,7 +12,7 @@ PyramidRemoveChildCommandTest >> command [ ^ PyramidRemoveChildCommand new ] -{ #category : #'as yet unclassified' } +{ #category : #accessing } PyramidRemoveChildCommandTest >> targetsCanBeUsedFor [ ^ { BlElement new . BlElement new addChild: BlElement new; yourself } diff --git a/src/Pyramid-Tests/PyramidRemoveSelectionCommandTest.class.st b/src/Pyramid-Tests/PyramidRemoveSelectionCommandTest.class.st index 18aa0bb1..c2e6a27b 100644 --- a/src/Pyramid-Tests/PyramidRemoveSelectionCommandTest.class.st +++ b/src/Pyramid-Tests/PyramidRemoveSelectionCommandTest.class.st @@ -116,7 +116,7 @@ PyramidRemoveSelectionCommandTest >> parentsAndElements [ ^ parents -> elements ] -{ #category : #'as yet unclassified' } +{ #category : #accessing } PyramidRemoveSelectionCommandTest >> targetsCanBeUsedFor [ ^ { diff --git a/src/Pyramid-Tests/PyramidRoundedRectangleCornerRadiiCommandTest.class.st b/src/Pyramid-Tests/PyramidRoundedRectangleCornerRadiiCommandTest.class.st index 68db7048..38d349a6 100644 --- a/src/Pyramid-Tests/PyramidRoundedRectangleCornerRadiiCommandTest.class.st +++ b/src/Pyramid-Tests/PyramidRoundedRectangleCornerRadiiCommandTest.class.st @@ -12,7 +12,7 @@ PyramidRoundedRectangleCornerRadiiCommandTest >> command [ ^ PyramidRoundedRectangleCornerRadiiCommand new ] -{ #category : #'as yet unclassified' } +{ #category : #accessing } PyramidRoundedRectangleCornerRadiiCommandTest >> targetContainers [ ^ { @@ -30,7 +30,7 @@ PyramidRoundedRectangleCornerRadiiCommandTest >> targetContainers [ prop: (BlCornerRadii radius: 20)) } ] -{ #category : #'as yet unclassified' } +{ #category : #accessing } PyramidRoundedRectangleCornerRadiiCommandTest >> targetsCannotBeUsedFor [ "override if needed" diff --git a/src/Pyramid-Tests/PyramidShadowColorCommandTest.class.st b/src/Pyramid-Tests/PyramidShadowColorCommandTest.class.st index e5f446a1..fcd6eddd 100644 --- a/src/Pyramid-Tests/PyramidShadowColorCommandTest.class.st +++ b/src/Pyramid-Tests/PyramidShadowColorCommandTest.class.st @@ -12,7 +12,7 @@ PyramidShadowColorCommandTest >> command [ ^ PyramidShadowColorCommand new ] -{ #category : #'as yet unclassified' } +{ #category : #accessing } PyramidShadowColorCommandTest >> targetContainers [ ^ { diff --git a/src/Pyramid-Tests/PyramidShadowCommandTest.class.st b/src/Pyramid-Tests/PyramidShadowCommandTest.class.st index 2dcdb309..0e96a6e3 100644 --- a/src/Pyramid-Tests/PyramidShadowCommandTest.class.st +++ b/src/Pyramid-Tests/PyramidShadowCommandTest.class.st @@ -21,7 +21,7 @@ PyramidShadowCommandTest >> command [ ^ PyramidShadowCommand new ] -{ #category : #'as yet unclassified' } +{ #category : #accessing } PyramidShadowCommandTest >> targetContainers [ ^ { diff --git a/src/Pyramid-Tests/PyramidShadowGaussianWidthTest.class.st b/src/Pyramid-Tests/PyramidShadowGaussianWidthTest.class.st index a417f5fc..bf2b5df0 100644 --- a/src/Pyramid-Tests/PyramidShadowGaussianWidthTest.class.st +++ b/src/Pyramid-Tests/PyramidShadowGaussianWidthTest.class.st @@ -13,7 +13,7 @@ PyramidShadowGaussianWidthTest >> command [ ] -{ #category : #'as yet unclassified' } +{ #category : #accessing } PyramidShadowGaussianWidthTest >> targetContainers [ ^ { diff --git a/src/Pyramid-Tests/PyramidShadowOffsetCommandTest.class.st b/src/Pyramid-Tests/PyramidShadowOffsetCommandTest.class.st index a68c8424..2825bb4d 100644 --- a/src/Pyramid-Tests/PyramidShadowOffsetCommandTest.class.st +++ b/src/Pyramid-Tests/PyramidShadowOffsetCommandTest.class.st @@ -12,7 +12,7 @@ PyramidShadowOffsetCommandTest >> command [ ^ PyramidShadowOffsetCommand new ] -{ #category : #'as yet unclassified' } +{ #category : #accessing } PyramidShadowOffsetCommandTest >> targetContainers [ ^ { diff --git a/src/Pyramid-Tests/PyramidTextForegroundCommandTest.class.st b/src/Pyramid-Tests/PyramidTextForegroundCommandTest.class.st index 36b77372..457a78b1 100644 --- a/src/Pyramid-Tests/PyramidTextForegroundCommandTest.class.st +++ b/src/Pyramid-Tests/PyramidTextForegroundCommandTest.class.st @@ -18,7 +18,7 @@ PyramidTextForegroundCommandTest >> command [ ^ PyramidTextForegroundCommand new ] -{ #category : #'as yet unclassified' } +{ #category : #accessing } PyramidTextForegroundCommandTest >> targetContainers [ ^ { diff --git a/src/Pyramid-Tests/PyramidVisibilityCommandTest.class.st b/src/Pyramid-Tests/PyramidVisibilityCommandTest.class.st index abca3c83..028dad1c 100644 --- a/src/Pyramid-Tests/PyramidVisibilityCommandTest.class.st +++ b/src/Pyramid-Tests/PyramidVisibilityCommandTest.class.st @@ -12,7 +12,7 @@ PyramidVisibilityCommandTest >> command [ ^ PyramidVisibilityCommand new. ] -{ #category : #'as yet unclassified' } +{ #category : #accessing } PyramidVisibilityCommandTest >> targetContainers [ ^ { diff --git a/src/Pyramid-Tests/PyramidWeightConstraintsCommandTest.class.st b/src/Pyramid-Tests/PyramidWeightConstraintsCommandTest.class.st index 3af4cf20..7680fbde 100644 --- a/src/Pyramid-Tests/PyramidWeightConstraintsCommandTest.class.st +++ b/src/Pyramid-Tests/PyramidWeightConstraintsCommandTest.class.st @@ -12,7 +12,7 @@ PyramidWeightConstraintsCommandTest >> command [ ^ PyramidWeightConstraintsCommand new ] -{ #category : #'as yet unclassified' } +{ #category : #accessing } PyramidWeightConstraintsCommandTest >> targetContainers [ | parentLinear e1Linear e2Linear parentFlow e1Flow e2Flow | @@ -41,7 +41,7 @@ PyramidWeightConstraintsCommandTest >> targetContainers [ ^ { (PyramidCommandTestContainer no: e1Linear with: e2Linear prop: 0.5) . (PyramidCommandTestContainer no: e1Flow with: e2Flow prop: 0.5) } ] -{ #category : #'as yet unclassified' } +{ #category : #accessing } PyramidWeightConstraintsCommandTest >> targetsCannotBeUsedFor [ "override if needed" | parent child | diff --git a/src/Pyramid-Tests/PyramidZIndexCommandTest.class.st b/src/Pyramid-Tests/PyramidZIndexCommandTest.class.st index ccb5fe23..13a1594a 100644 --- a/src/Pyramid-Tests/PyramidZIndexCommandTest.class.st +++ b/src/Pyramid-Tests/PyramidZIndexCommandTest.class.st @@ -12,7 +12,7 @@ PyramidZIndexCommandTest >> command [ ^ PyramidZIndexCommand new. ] -{ #category : #'as yet unclassified' } +{ #category : #accessing } PyramidZIndexCommandTest >> targetContainers [ ^ { diff --git a/src/Pyramid-Tests/TPyramidCommandTest.trait.st b/src/Pyramid-Tests/TPyramidCommandTest.trait.st index fb408590..c7f62f97 100644 --- a/src/Pyramid-Tests/TPyramidCommandTest.trait.st +++ b/src/Pyramid-Tests/TPyramidCommandTest.trait.st @@ -3,7 +3,7 @@ Trait { #category : #'Pyramid-Tests-cases-command' } -{ #category : #'as yet unclassified' } +{ #category : #accessing } TPyramidCommandTest >> argumentsForHistory [ @@ -16,19 +16,19 @@ TPyramidCommandTest >> command [ ^ self shouldBeImplemented ] -{ #category : #'as yet unclassified' } +{ #category : #accessing } TPyramidCommandTest >> targetContainers [ ^ self shouldBeImplemented ] -{ #category : #'as yet unclassified' } +{ #category : #accessing } TPyramidCommandTest >> targetsCanBeUsedFor [ ^ self targetContainers flatCollect: [ :each | { each targetNoProp . each targetWithProp } ]. ] -{ #category : #'as yet unclassified' } +{ #category : #accessing } TPyramidCommandTest >> targetsCannotBeUsedFor [ "override if needed" ^ { nil . false . 0 . $a } diff --git a/src/Pyramid-Toplo-Tests/PyramidStampCommandTest.class.st b/src/Pyramid-Toplo-Tests/PyramidStampCommandTest.class.st index b27c592e..f7143ce0 100644 --- a/src/Pyramid-Toplo-Tests/PyramidStampCommandTest.class.st +++ b/src/Pyramid-Toplo-Tests/PyramidStampCommandTest.class.st @@ -12,7 +12,7 @@ PyramidStampCommandTest >> command [ ^ PyramidStampCommand new stamp: #test; yourself ] -{ #category : #'as yet unclassified' } +{ #category : #accessing } PyramidStampCommandTest >> targetContainers [ ^ { From 1ea94f5ea541c05aaf0a8402178a677d4e2810f3 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Mathieu=20Magu=C3=A9r=C3=A8s?= Date: Thu, 16 Apr 2026 16:39:45 +0200 Subject: [PATCH 11/11] update devStage_shadow --- src/Pyramid-Bloc/PyramidShadowColorCommand.class.st | 13 ++++++------- .../PyramidShadowGaussianWidthCommand.class.st | 12 +++++------- .../PyramidShadowOffsetCommand.class.st | 13 ++++++------- 3 files changed, 17 insertions(+), 21 deletions(-) diff --git a/src/Pyramid-Bloc/PyramidShadowColorCommand.class.st b/src/Pyramid-Bloc/PyramidShadowColorCommand.class.st index ec8cae3b..52bfd00c 100644 --- a/src/Pyramid-Bloc/PyramidShadowColorCommand.class.st +++ b/src/Pyramid-Bloc/PyramidShadowColorCommand.class.st @@ -15,17 +15,16 @@ PyramidShadowColorCommand >> canBeUsedFor: anObject [ { #category : #accessing } PyramidShadowColorCommand >> getValueFor: aBlElement [ - (aBlElement effect class = BlSimpleShadowEffect or: [aBlElement effect class = BlGaussianShadowEffect]) - ifTrue: [ ^ aBlElement effect color ] - ifFalse: [ ^ nil ] + (aBlElement effect class = BlSimpleShadowEffect or: [ + aBlElement effect class = BlGaussianShadowEffect ]) ifFalse: [ ^ nil ]. + ^ aBlElement effect color ] { #category : #accessing } PyramidShadowColorCommand >> setValueFor: aBlElement with: aColor [ - (aBlElement effect class = BlSimpleShadowEffect or: [aBlElement effect class= BlGaussianShadowEffect]) - ifTrue: [ - aBlElement effect: (aBlElement effect copyWithColor: aColor) ] - ifFalse: [ ^ nil ]. + (aBlElement effect class = BlSimpleShadowEffect or: [ + aBlElement effect class = BlGaussianShadowEffect ]) ifFalse: [ ^ nil ]. + aBlElement effect: (aBlElement effect copyWithColor: aColor). PyramidShadowCommand current syncFromElement: aBlElement ] diff --git a/src/Pyramid-Bloc/PyramidShadowGaussianWidthCommand.class.st b/src/Pyramid-Bloc/PyramidShadowGaussianWidthCommand.class.st index 08272272..c9e8984b 100644 --- a/src/Pyramid-Bloc/PyramidShadowGaussianWidthCommand.class.st +++ b/src/Pyramid-Bloc/PyramidShadowGaussianWidthCommand.class.st @@ -15,17 +15,15 @@ PyramidShadowGaussianWidthCommand >> canBeUsedFor: anObject [ PyramidShadowGaussianWidthCommand >> getValueFor: aBlElement [ (aBlElement effect class = BlSimpleShadowEffect or: [ - aBlElement effect class = BlGaussianShadowEffect ]) - ifTrue: [ ^ aBlElement effect width ] - ifFalse: [ ^ nil ] + aBlElement effect class = BlGaussianShadowEffect ]) ifFalse: [ ^ nil ]. + ^ aBlElement effect width ] { #category : #accessing } PyramidShadowGaussianWidthCommand >> setValueFor: aBlElement with: aWidth [ - (aBlElement effect class = BlSimpleShadowEffect or: [aBlElement effect class = BlGaussianShadowEffect]) - ifTrue: [ - aBlElement effect: (aBlElement effect copyWithWidth: aWidth) ] - ifFalse: [ ^ nil ]. + (aBlElement effect class = BlSimpleShadowEffect or: [ + aBlElement effect class = BlGaussianShadowEffect ]) ifFalse: [ ^ nil ]. + aBlElement effect: (aBlElement effect copyWithWidth: aWidth). PyramidShadowCommand current syncFromElement: aBlElement ] diff --git a/src/Pyramid-Bloc/PyramidShadowOffsetCommand.class.st b/src/Pyramid-Bloc/PyramidShadowOffsetCommand.class.st index a4388e2b..73737e5e 100644 --- a/src/Pyramid-Bloc/PyramidShadowOffsetCommand.class.st +++ b/src/Pyramid-Bloc/PyramidShadowOffsetCommand.class.st @@ -14,17 +14,16 @@ PyramidShadowOffsetCommand >> canBeUsedFor: anObject [ { #category : #accessing } PyramidShadowOffsetCommand >> getValueFor: aBlElement [ - (aBlElement effect class = BlSimpleShadowEffect or: [aBlElement effect class = BlGaussianShadowEffect]) - ifTrue: [ ^ aBlElement effect offset ] - ifFalse: [ ^ nil ] + (aBlElement effect class = BlSimpleShadowEffect or: [ + aBlElement effect class = BlGaussianShadowEffect ]) ifFalse: [ ^ nil ]. + ^ aBlElement effect offset ] { #category : #accessing } PyramidShadowOffsetCommand >> setValueFor: aBlElement with: aPoint [ - (aBlElement effect class = BlSimpleShadowEffect or: [aBlElement effect class = BlGaussianShadowEffect]) - ifTrue: [ - aBlElement effect: (aBlElement effect copyWithOffset: aPoint) ] - ifFalse: [ ^ nil ]. + (aBlElement effect class = BlSimpleShadowEffect or: [ + aBlElement effect class = BlGaussianShadowEffect ]) ifFalse: [ ^ nil ]. + aBlElement effect: (aBlElement effect copyWithOffset: aPoint). PyramidShadowCommand current syncFromElement: aBlElement ]