From d7d4d437eea25c9d092fac969fb2c1192e434188 Mon Sep 17 00:00:00 2001 From: Pierre Laborde Date: Thu, 18 Jul 2024 16:43:39 +0200 Subject: [PATCH 1/2] Update toplo branch --- .../BaselineOfToploSerialization.class.st | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/BaselineOfToploSerialization/BaselineOfToploSerialization.class.st b/src/BaselineOfToploSerialization/BaselineOfToploSerialization.class.st index 6dcab74..2bc8a88 100644 --- a/src/BaselineOfToploSerialization/BaselineOfToploSerialization.class.st +++ b/src/BaselineOfToploSerialization/BaselineOfToploSerialization.class.st @@ -29,7 +29,7 @@ BaselineOfToploSerialization >> dependency: spec [ with: [ spec repository: 'github://OpenSmock/Bloc-Serialization:main/src' ]. - spec baseline: 'Toplo' with: [ spec repository: 'github://pharo-graphics/Toplo:master/src' ]. + spec baseline: 'Toplo' with: [ spec repository: 'github://pharo-graphics/Toplo:dev/src' ]. ] From f40b8f1b6e88313f4f68f866ba3a1f3f3bd7e94b Mon Sep 17 00:00:00 2001 From: Yann Le Goff Date: Fri, 19 Jul 2024 11:56:07 +0200 Subject: [PATCH 2/2] remove useless tests --- .../ToCheckbox.extension.st | 2 +- .../ToSerializerTest.class.st | 59 +++++-------------- 2 files changed, 16 insertions(+), 45 deletions(-) diff --git a/src/Toplo-Serialization/ToCheckbox.extension.st b/src/Toplo-Serialization/ToCheckbox.extension.st index 814a0e8..b70acb8 100644 --- a/src/Toplo-Serialization/ToCheckbox.extension.st +++ b/src/Toplo-Serialization/ToCheckbox.extension.st @@ -8,7 +8,7 @@ ToCheckbox >> stonPostReferenceResolution [ self checked: aCheckValue. self userData removeKey: #stonChecked ]. self userData at: #stonGroup ifPresent: [ :aGroup | - aGroup add: self. + aGroup register: self. self userData removeKey: #stonGroup ] ] diff --git a/src/Toplo-Serialization/ToSerializerTest.class.st b/src/Toplo-Serialization/ToSerializerTest.class.st index ed5c15f..4bf2775 100644 --- a/src/Toplo-Serialization/ToSerializerTest.class.st +++ b/src/Toplo-Serialization/ToSerializerTest.class.st @@ -260,17 +260,17 @@ ToSerializerTest >> testToCheckbox4 [ button1 := ToCheckbox new id: #button1; labelText: 'button1'; - addToGroup: group; + registerInGroup: group; yourself. button2 := ToCheckbox new id: #button2; labelText: 'button2'; - addToGroup: group; + registerInGroup: group; yourself. button3 := ToCheckbox new id: #button3; labelText: 'button3'; - addToGroup: group; + registerInGroup: group; yourself. pane addChildren: { button1. @@ -294,13 +294,17 @@ ToSerializerTest >> testToCheckbox4 [ assert: (element childAt: 2) group equals: (element childAt: 3) group. self - assert: (element childAt: 1) group buttons size equals: 3. - self - assert: ((element childAt: 1) group buttons includes: (element childAt: 1)). - self - assert: ((element childAt: 1) group buttons includes: (element childAt: 2)). - self - assert: ((element childAt: 1) group buttons includes: (element childAt: 3)). ] + assert: (element childAt: 1) group registeredCheckables size + equals: 3. + self assert: + ((element childAt: 1) group registeredCheckables includes: + (element childAt: 1)). + self assert: + ((element childAt: 1) group registeredCheckables includes: + (element childAt: 2)). + self assert: + ((element childAt: 1) group registeredCheckables includes: + (element childAt: 3)) ] ] { #category : #tests } @@ -344,39 +348,6 @@ ToSerializerTest >> testTooltip1 [ { #category : #tests } ToSerializerTest >> testTooltip2 [ - | origin tooltip | - tooltip := BlElement new id: #tooltip; yourself. - origin := ToElement new tooltipContent: tooltip; yourself. - - self - test: origin - on: [ :element | self assert: element hasTooltip. - element newTooltipWindowEvent: nil. - self assert: element hasOpenedTooltip. - self assert: ((element currentTooltipWindow childAt: 1 ) childAt: 1) id equals: #tooltip - ] -] - -{ #category : #tests } -ToSerializerTest >> testTooltip3 [ - - | origin | - origin := ToElement new - tooltipText: 'hello tooltip'; - yourself. - - self test: origin on: [ :element | - self assert: element hasTooltip. - element newTooltipWindowEvent: nil. - self assert: element hasOpenedTooltip. - self - assert: ((element currentTooltipWindow childAt: 1) childAt: 1) text asString - equals: 'hello tooltip' ] -] - -{ #category : #tests } -ToSerializerTest >> testTooltip4 [ - | origin | origin := ToElement new tooltipText: 'hello tooltip'; @@ -389,7 +360,7 @@ ToSerializerTest >> testTooltip4 [ ] { #category : #tests } -ToSerializerTest >> testTooltip5 [ +ToSerializerTest >> testTooltip3 [ | origin | origin := ToElement new