Remove dynamic check failure test for check_range_doesnt_cross_app_sbx_boundary

Author: shravanrn

code/include/rlbox_range.hpp

@@ -24,9 +24,11 @@ inline void check_range_doesnt_cross_app_sbx_boundary(const void* ptr,
   auto ptr_start = reinterpret_cast<void*>(ptr_start_val);
   auto ptr_end = reinterpret_cast<void*>(ptr_end_val);
 
-  detail::dynamic_check(
-    rlbox_sandbox<T_Sbx>::is_in_same_sandbox(ptr_start, ptr_end),
-    "range has overflowed sandbox bounds");
+  bool safe = rlbox_sandbox<T_Sbx>::is_in_same_sandbox(ptr_start, ptr_end);
+  if (!safe) {
+    printf("range has overflowed sandbox bounds: %p, %p\n", ptr_start, ptr_end);
+    abort();
+  }
 }
 
 }

code/tests/rlbox/test_verification.cpp

@@ -108,21 +108,3 @@ TEST_CASE("RLBox test unverified value", "[verification]")
   REQUIRE(result3 == testVal);
 }
 
-// NOLINTNEXTLINE
-TEST_CASE("RLBox test unverified pointer", "[verification]")
-{
-  rlbox::rlbox_sandbox<TestSandbox> sandbox;
-  sandbox.create_sandbox();
-  tainted<int*, TestSandbox> pa = sandbox.malloc_in_sandbox<int>();
-
-  const auto elementCountSafe = 1;
-  REQUIRE_NOTHROW(pa.unverified_safe_pointer_because(elementCountSafe,
-                                                     "Reading within range"));
-
-  const auto elementCountUnsafe =
-    (TestSandbox::SandboxMemorySize / sizeof(int)) + 1;
-  REQUIRE_THROWS(pa.unverified_safe_pointer_because(
-    elementCountUnsafe, "Definitely out of sandbox memory. Unsafe!"));
-
-  sandbox.destroy_sandbox();
-}