From 4f21b8918585bf1031bf56d5e277b38e0b1c28ab Mon Sep 17 00:00:00 2001 From: Marius Storhaug Date: Sat, 25 Dec 2021 22:57:31 +0100 Subject: [PATCH 1/5] test --- README.md | 1 + 1 file changed, 1 insertion(+) diff --git a/README.md b/README.md index 848bff9..72b8983 100644 --- a/README.md +++ b/README.md @@ -7,3 +7,4 @@ https://github.com/joelparkerhenderson/github-special-files-and-paths#changelog https://github.com/segraef/Template https://github.com/Azure/Aks-Construction + From e740a205de1d9e4085c5aeb915c99e94c54f8613 Mon Sep 17 00:00:00 2001 From: Marius Storhaug Date: Sat, 25 Dec 2021 22:59:00 +0100 Subject: [PATCH 2/5] update --- .github/PULL_REQUEST_TEMPLATE/PULL_REQUEST_TEMPLATE2.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/PULL_REQUEST_TEMPLATE/PULL_REQUEST_TEMPLATE2.md b/.github/PULL_REQUEST_TEMPLATE/PULL_REQUEST_TEMPLATE2.md index 28fcf56..af795df 100644 --- a/.github/PULL_REQUEST_TEMPLATE/PULL_REQUEST_TEMPLATE2.md +++ b/.github/PULL_REQUEST_TEMPLATE/PULL_REQUEST_TEMPLATE2.md @@ -2,4 +2,4 @@ https://docs.github.com/en/communities/using-templates-to-encourage-useful-issues-and-pull-requests/creating-a-pull-request-template-for-your-repository --> -This is a test template +This is a test template2 From a1725c0eb42a0e23fd2318b05a42bb2d4b7ce505 Mon Sep 17 00:00:00 2001 From: Marius Storhaug Date: Sat, 25 Dec 2021 23:03:14 +0100 Subject: [PATCH 3/5] test --- .../{PULL_REQUEST_TEMPLATE2.md => ccc.md} | 4 +++- .../{PULL_REQUEST_TEMPLATE.md => pull_request_t.md} | 0 README.md | 1 + 3 files changed, 4 insertions(+), 1 deletion(-) rename .github/PULL_REQUEST_TEMPLATE/{PULL_REQUEST_TEMPLATE2.md => ccc.md} (84%) rename .github/PULL_REQUEST_TEMPLATE/{PULL_REQUEST_TEMPLATE.md => pull_request_t.md} (100%) diff --git a/.github/PULL_REQUEST_TEMPLATE/PULL_REQUEST_TEMPLATE2.md b/.github/PULL_REQUEST_TEMPLATE/ccc.md similarity index 84% rename from .github/PULL_REQUEST_TEMPLATE/PULL_REQUEST_TEMPLATE2.md rename to .github/PULL_REQUEST_TEMPLATE/ccc.md index af795df..6206c63 100644 --- a/.github/PULL_REQUEST_TEMPLATE/PULL_REQUEST_TEMPLATE2.md +++ b/.github/PULL_REQUEST_TEMPLATE/ccc.md @@ -2,4 +2,6 @@ https://docs.github.com/en/communities/using-templates-to-encourage-useful-issues-and-pull-requests/creating-a-pull-request-template-for-your-repository --> -This is a test template2 +# CCC + +This is a test template diff --git a/.github/PULL_REQUEST_TEMPLATE/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE/pull_request_t.md similarity index 100% rename from .github/PULL_REQUEST_TEMPLATE/PULL_REQUEST_TEMPLATE.md rename to .github/PULL_REQUEST_TEMPLATE/pull_request_t.md diff --git a/README.md b/README.md index 72b8983..b1d092d 100644 --- a/README.md +++ b/README.md @@ -8,3 +8,4 @@ https://github.com/segraef/Template https://github.com/Azure/Aks-Construction +https://github.com/embeddedartistry From f67f4bbc5a55be9a93ed735232183c53c537a15d Mon Sep 17 00:00:00 2001 From: Marius Storhaug Date: Sat, 25 Dec 2021 23:05:51 +0100 Subject: [PATCH 4/5] test --- .github/PULL_REQUEST_TEMPLATE/ccc.md | 50 ++++++++++++++++++- .../PULL_REQUEST_TEMPLATE/pull_request_t.md | 5 -- .../pull_request_template.md | 46 +++++++++++++++++ 3 files changed, 94 insertions(+), 7 deletions(-) delete mode 100644 .github/PULL_REQUEST_TEMPLATE/pull_request_t.md create mode 100644 .github/PULL_REQUEST_TEMPLATE/pull_request_template.md diff --git a/.github/PULL_REQUEST_TEMPLATE/ccc.md b/.github/PULL_REQUEST_TEMPLATE/ccc.md index 6206c63..13f5039 100644 --- a/.github/PULL_REQUEST_TEMPLATE/ccc.md +++ b/.github/PULL_REQUEST_TEMPLATE/ccc.md @@ -2,6 +2,52 @@ https://docs.github.com/en/communities/using-templates-to-encourage-useful-issues-and-pull-requests/creating-a-pull-request-template-for-your-repository --> -# CCC +# Code Change Control -This is a test template +## Description + +Please include a summary of the change and which issue is fixed. Please provide the motivation for why this change is necessary at this stage of the product development cycle. + +Fixes # (issue) + +## Customer Impact + +Please describe any customer facing impact of this change. This can be positive or negative impact. + +## Performance Impact + +Please describe any relevant performance impact of this change. This can be positive or negative impact. How did you characterize/test the performance impact? + +## How Has This Been Tested? + +Please describe the tests that you ran to verify your changes. Provide instructions so others can reproduce. Please also list any relevant details for your test configuration. + +- [ ] Test A +- [ ] Test B + +**Hardware Configuration(s) Tested**: + +**Software Configuration(s) Tested**: + +* Operating System: +* Software version: +* Branch: +* Toolchain version: +* SDK version: + +## Reviews + +Please identify two developers to review this change + +- [ ] @personA +- [ ] @personB + +## Checklist: + +- [ ] I have performed a self-review of my own code +- [ ] I have commented my code, particularly in hard-to-understand areas +- [ ] I have made corresponding changes to the documentation +- [ ] My changes generate no new warnings +- [ ] I have added tests that prove my fix is effective or that my feature works +- [ ] New and existing unit tests pass locally with my changes +- [ ] Any dependent changes have been merged and published in downstream modules diff --git a/.github/PULL_REQUEST_TEMPLATE/pull_request_t.md b/.github/PULL_REQUEST_TEMPLATE/pull_request_t.md deleted file mode 100644 index 28fcf56..0000000 --- a/.github/PULL_REQUEST_TEMPLATE/pull_request_t.md +++ /dev/null @@ -1,5 +0,0 @@ - - -This is a test template diff --git a/.github/PULL_REQUEST_TEMPLATE/pull_request_template.md b/.github/PULL_REQUEST_TEMPLATE/pull_request_template.md new file mode 100644 index 0000000..3a8567d --- /dev/null +++ b/.github/PULL_REQUEST_TEMPLATE/pull_request_template.md @@ -0,0 +1,46 @@ + + +# Pull Request + +## Description + +Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change. + +Fixes # (issue) + +## Type of change + +Please delete options that are not relevant. + +- [ ] Bug fix (non-breaking change which fixes an issue) +- [ ] New feature (non-breaking change which adds functionality) +- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) +- [ ] This change requires a documentation update + +## How Has This Been Tested? + +Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration + +- [ ] Test A +- [ ] Test B + +**Test Configuration(s)**: + +* Firmware version: +* Hardware: +* Toolchain: +* SDK: + +## Checklist: + +- [ ] My code follows the style guidelines of this project +- [ ] I have performed a self-review of my own code +- [ ] I have commented my code, particularly in hard-to-understand areas +- [ ] I have made corresponding changes to the documentation +- [ ] My changes generate no new warnings +- [ ] I have added tests that prove my fix is effective or that my feature works +- [ ] New and existing unit tests pass locally with my changes +- [ ] Any dependent changes have been merged and published in downstream modules +- [ ] I have checked my code and corrected any misspellings From 4bd62f57b69301de56ba0f4c8a119fa5b2cc776e Mon Sep 17 00:00:00 2001 From: Marius Storhaug Date: Sun, 26 Dec 2021 16:14:50 +0100 Subject: [PATCH 5/5] fix --- .github/ISSUE_TEMPLATE/bug_report_inputs.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/ISSUE_TEMPLATE/bug_report_inputs.yml b/.github/ISSUE_TEMPLATE/bug_report_inputs.yml index b330b3a..55bee89 100644 --- a/.github/ISSUE_TEMPLATE/bug_report_inputs.yml +++ b/.github/ISSUE_TEMPLATE/bug_report_inputs.yml @@ -1,6 +1,6 @@ # https://docs.github.com/en/communities/using-templates-to-encourage-useful-issues-and-pull-requests/syntax-for-issue-forms # https://docs.github.com/en/communities/using-templates-to-encourage-useful-issues-and-pull-requests/syntax-for-githubs-form-schema -name: Bug Report +name: Bug report (inputs) description: File a bug report title: "[Bug]: " labels: ["bug", "triage"]