Merge pull request #2476 from Particular/urlacl-fixes

Adding aclurl for all hostnames for the maintenance mode

Author: danielmarbach

src/ServiceControlInstaller.Engine/Instances/ServiceControlBaseService.cs

@@ -70,7 +70,7 @@ public string AclMaintenanceUrl
         {
             get
             {
-                var baseUrl = $"http://{HostName}:{DatabaseMaintenancePort}/";
+                var baseUrl = $"http://+:{DatabaseMaintenancePort}/";
                 return baseUrl;
             }
         }
@@ -208,8 +208,17 @@ protected string DefaultLogPath()
 
         public void RemoveUrlAcl()
         {
-            foreach (var urlReservation in UrlReservation.GetAll().Where(p => p.Url.StartsWith(AclUrl, StringComparison.OrdinalIgnoreCase) ||
-                                                                              p.Url.StartsWith(AclMaintenanceUrl, StringComparison.OrdinalIgnoreCase)))
+            //This is an old aclurl registration for embedded RavenDB instance that includes the hostname.
+            //We need that to make sure we can clean-up old registration when removing instances created
+            //using pre 4.17 versions of ServiceControl.
+            var legacyAclMaintenanceUrl = $"http://{HostName}:{DatabaseMaintenancePort}/";
+
+            bool IsServiceControlAclUrl(UrlReservation r) =>
+                r.Url.StartsWith(AclUrl, StringComparison.OrdinalIgnoreCase) ||
+                r.Url.StartsWith(AclMaintenanceUrl, StringComparison.OrdinalIgnoreCase) ||
+                r.Url.StartsWith(legacyAclMaintenanceUrl, StringComparison.OrdinalIgnoreCase);
+
+            foreach (var urlReservation in UrlReservation.GetAll().Where(IsServiceControlAclUrl))
             {
                 try
                 {

src/ServiceControlInstaller.Engine/Instances/ServiceControlNewInstance.cs

@@ -225,7 +225,7 @@ public string AclMaintenanceUrl
         {
             get
             {
-                var baseUrl = $"http://{HostName}:{DatabaseMaintenancePort}/";
+                var baseUrl = $"http://+:{DatabaseMaintenancePort}/";
                 return baseUrl;
             }
         }

src/ServiceControlInstaller.PowerShell/Cmdlets/AuditInstances/NewServiceControlAuditInstance.cs

@@ -1,7 +1,6 @@
 namespace ServiceControlInstaller.PowerShell
 {
     using System;
-    using System.IO;
     using System.Linq;
     using System.Management.Automation;
     using Engine.Instances;