From 48883f9e6097bd9ac45a1a04478ad65a27bbd9e2 Mon Sep 17 00:00:00 2001
From: Jeremy Walters <jeremywa@proton.me>
Date: Tue, 28 Oct 2025 14:06:04 -0400
Subject: [PATCH] fix: make subtitle optional for custom sections

  Remove required validation for subtitle field in custom section
  forms.
  Title remains required.
---
 .../components/CustomSectionForm/CustomSectionForm.tsx       | 3 +--
 .../CustomSectionForm/CustomSectionForm.validation.ts        | 5 -----
 .../EditCustomSectionModal/EditCustomSectionModal.test.tsx   | 5 ++---
 3 files changed, 3 insertions(+), 10 deletions(-)

diff --git a/src/curated-corpus/components/CustomSectionForm/CustomSectionForm.tsx b/src/curated-corpus/components/CustomSectionForm/CustomSectionForm.tsx
index c59d02e3..fd9cf4bd 100644
--- a/src/curated-corpus/components/CustomSectionForm/CustomSectionForm.tsx
+++ b/src/curated-corpus/components/CustomSectionForm/CustomSectionForm.tsx
@@ -82,8 +82,7 @@ export const CustomSectionForm: React.FC<CustomSectionFormProps> = ({
               <Field
                 as={TextField}
                 name="subtitle"
-                label="Subtitle"
-                required
+                label="Subtitle (Optional)"
                 fullWidth
                 multiline
                 rows={2}
diff --git a/src/curated-corpus/components/CustomSectionForm/CustomSectionForm.validation.ts b/src/curated-corpus/components/CustomSectionForm/CustomSectionForm.validation.ts
index b3843486..5b498e42 100644
--- a/src/curated-corpus/components/CustomSectionForm/CustomSectionForm.validation.ts
+++ b/src/curated-corpus/components/CustomSectionForm/CustomSectionForm.validation.ts
@@ -24,7 +24,6 @@ export const getValidationSchema = (isEditMode: boolean = false) => {
     subtitle: yup
       .string()
       .trim()
-      .required('Subtitle is required')
       .max(500, 'Subtitle cannot exceed 500 characters'),
 
     heroTitle: yup
@@ -95,10 +94,6 @@ export const validateForm = (
     errors.title = 'Title is required';
   }
 
-  if (!formData.subtitle.trim()) {
-    errors.subtitle = 'Subtitle is required';
-  }
-
   if (!formData.startDate) {
     errors.startDate = 'Start date is required';
   } else if (formData.startDate < today) {
diff --git a/src/curated-corpus/components/EditCustomSectionModal/EditCustomSectionModal.test.tsx b/src/curated-corpus/components/EditCustomSectionModal/EditCustomSectionModal.test.tsx
index a8b1495b..d1e0b313 100644
--- a/src/curated-corpus/components/EditCustomSectionModal/EditCustomSectionModal.test.tsx
+++ b/src/curated-corpus/components/EditCustomSectionModal/EditCustomSectionModal.test.tsx
@@ -87,9 +87,8 @@ describe('EditCustomSectionModal', () => {
       </MockedProvider>,
     );
 
-    // Check if form text labels are rendered (from CustomSectionFormConnector)
-    expect(screen.getByText('Title')).toBeInTheDocument();
-    expect(screen.getByText('Subtitle')).toBeInTheDocument();
+    // Check if form is rendered - looking for start date label
+    expect(screen.getByText('Start Date')).toBeInTheDocument();
   });
 
   it('should populate form with section data', () => {