From ad4bc83589d7b4e343a23a7b10a2c381cc896d34 Mon Sep 17 00:00:00 2001 From: Maxime Labelle Date: Wed, 10 Apr 2019 16:29:39 +0200 Subject: [PATCH 1/2] Added missing [SkippableFact] attribute to prevent test from failing instead of being skipped. --- test/MovementTest.VI.Multiline.cs | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/test/MovementTest.VI.Multiline.cs b/test/MovementTest.VI.Multiline.cs index 9de3b17b4..6f2d275d1 100644 --- a/test/MovementTest.VI.Multiline.cs +++ b/test/MovementTest.VI.Multiline.cs @@ -58,7 +58,7 @@ public void ViMoveToFirstLogicalLine_MustDing_ForSingleLine() ViJumpMustDing(buffer, keys); } - [Fact] + [SkippableFact] public void ViMoveToFirstNonBlankOfLogicalLineThenJumpToEndOfLogicalLine() { TestSetup(KeyMode.Vi); @@ -77,7 +77,7 @@ public void ViMoveToFirstNonBlankOfLogicalLineThenJumpToEndOfLogicalLine() )); } - [Fact] + [SkippableFact] public void ViMoveToFirstNonBlankOfLogicalLine_NoOp_OnEmptyLine() { TestSetup(KeyMode.Vi); @@ -93,7 +93,7 @@ public void ViMoveToFirstNonBlankOfLogicalLine_NoOp_OnEmptyLine() )); } - [Fact] + [SkippableFact] public void ViMoveToEndOfLine_NoOp_OnEmptyLine() { TestSetup(KeyMode.Vi); From 74291a52b8d39975f480bf9f9f6771d4a4ad6f0b Mon Sep 17 00:00:00 2001 From: Maxime Labelle Date: Wed, 10 Apr 2019 17:39:58 +0200 Subject: [PATCH 2/2] Fix - failing unit-tests that used an aliased member which defaults to handling upper case/lower case keys differently. Previously, sequence of keys were interpreted using a language hack at the top of the file. The "using _ = Keys;" statement defaulted to a class that contained both "K" and "ucK" for lower-case 'K' and upper-case 'K' respectively. Now, "_" is a member of the class that points to a "KbdLayout" class with members "k" and "K" respectively. Therefore, the unit-test was broken when the definition of "_" changed. --- test/MovementTest.VI.Multiline.cs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/test/MovementTest.VI.Multiline.cs b/test/MovementTest.VI.Multiline.cs index 6f2d275d1..d5290b065 100644 --- a/test/MovementTest.VI.Multiline.cs +++ b/test/MovementTest.VI.Multiline.cs @@ -87,7 +87,7 @@ public void ViMoveToFirstNonBlankOfLogicalLine_NoOp_OnEmptyLine() const string buffer = "\"\n\n\""; Test(buffer, Keys( - _.DQuote, _.Enter, _.Enter, _.DQuote, _.Escape, _.K, + _.DQuote, _.Enter, _.Enter, _.DQuote, _.Escape, _.k, CheckThat(() => AssertCursorLeftTopIs(continuationPrefixLength + 0, 1)), _.Underbar, CheckThat(() => AssertCursorLeftTopIs(continuationPrefixLength + 0, 1)) )); @@ -103,7 +103,7 @@ public void ViMoveToEndOfLine_NoOp_OnEmptyLine() const string buffer = "\"\n\n\""; Test(buffer, Keys( - _.DQuote, _.Enter, _.Enter, _.DQuote, _.Escape, _.K, + _.DQuote, _.Enter, _.Enter, _.DQuote, _.Escape, _.k, CheckThat(() => AssertCursorLeftTopIs(continuationPrefixLength + 0, 1)), _.Dollar, CheckThat(() => AssertCursorLeftTopIs(continuationPrefixLength + 0, 1)) ));