From 71e46fbc4719191c3265751c0aa3b48068cbf2a7 Mon Sep 17 00:00:00 2001 From: CarliPinell Date: Mon, 4 Dec 2023 14:50:28 +0000 Subject: [PATCH 1/7] Ready for PR --- resources/img/launchpad-images/frame.png | Bin 0 -> 876 bytes .../components/ProcessInfo.vue | 7 ++- .../components/ProcessTab.vue | 44 ++++++++++++++++++ .../components/ProcessesCarousel.vue | 1 + 4 files changed, 50 insertions(+), 2 deletions(-) create mode 100644 resources/img/launchpad-images/frame.png create mode 100644 resources/js/processes-catalogue/components/ProcessTab.vue diff --git a/resources/img/launchpad-images/frame.png b/resources/img/launchpad-images/frame.png new file mode 100644 index 0000000000000000000000000000000000000000..2a85412a06d58d0fc8086905047d7d9b69d5159e GIT binary patch literal 876 zcmeAS@N?(olHy`uVBq!ia0vp^B|sd+!3HE-^FQzaDb50q$YKTtZeb8+WSBKa0w~B> z9OUlAuJ6f3E_MFTUW6EpE3O^`!m=4iu#t`*xj;!9`Y;hyt45|&91yMu6J%vXYO4) z<7b%3j^}mXn%J(ZdfYp^b2U>-SJR}x0Hfy$D|guNPnq7p9sIvtH^!!V*5vyKwzGYB zC~!~2gta`Z=`?T88Q=YT*-h$P`&UQi9Xi(ga!2^5XHo{XqPFXr)K0KQ>}`wKv0`=j z;^V;=SYl_||D9*~?R|8IoV#PO%jP?rOBSSvOliON6lj?nmzSI4NevB2R@KEoQ4>e? z+$DaF!cWZnj!Rxmci!Hlmb1PsLWW&>yM0}!oPV{B%A32(6SPnMEO7q5g0H_J{QcqB zphX%PT=%XWx|v#Ocq72}v3c+8(CxP#=Bcy0e^|Ca)AFBW+@x#O{BO$+i|(FO-&!Be z<>lnP6X=8SoH!eyHu;uj*}b z8ti3|g_2ndGjdrY;;d}fT=gq+{k`FiXVY@q^Ga{~R>?h+7XNg>`o*WDn&{|Fhiolx zHf2roR^!PkVKMLiryb(xnK8}#nDvY6ZWU(QYVVc=ej@>sJ7d@M`u_ETKLFr}r zfXY1YWzFszG!i4yS~4dYb|3U@WGgNCC~3I);bi-{;tibdj=SBvURQeejq{H`tk*xx WaGIj!JRO)h7(8A5T-G@yGywpr@`>#L literal 0 HcmV?d00001 diff --git a/resources/js/processes-catalogue/components/ProcessInfo.vue b/resources/js/processes-catalogue/components/ProcessInfo.vue index 674563e1b7..0b5dd67604 100644 --- a/resources/js/processes-catalogue/components/ProcessInfo.vue +++ b/resources/js/processes-catalogue/components/ProcessInfo.vue @@ -30,7 +30,9 @@ - Process Tab + + + @@ -41,9 +43,10 @@ import ProcessesCarousel from "../components/ProcessesCarousel.vue"; import ProcessMap from "./ProcessMap.vue"; import ProcessOptions from "./ProcessOptions.vue"; import Breadcrumbs from "./Breadcrumbs.vue"; +import ProcessTab from './ProcessTab.vue'; export default { - components: { ProcessOptions, Breadcrumbs, ProcessMap, ProcessesCarousel }, + components: { ProcessOptions, Breadcrumbs, ProcessMap, ProcessesCarousel, ProcessTab }, props: ["process", "permission", "isDocumenterInstalled", "currentUserId"], data() { return { diff --git a/resources/js/processes-catalogue/components/ProcessTab.vue b/resources/js/processes-catalogue/components/ProcessTab.vue new file mode 100644 index 0000000000..d21a9ba182 --- /dev/null +++ b/resources/js/processes-catalogue/components/ProcessTab.vue @@ -0,0 +1,44 @@ + + + + diff --git a/resources/js/processes-catalogue/components/ProcessesCarousel.vue b/resources/js/processes-catalogue/components/ProcessesCarousel.vue index c86f824b05..241a01df1d 100644 --- a/resources/js/processes-catalogue/components/ProcessesCarousel.vue +++ b/resources/js/processes-catalogue/components/ProcessesCarousel.vue @@ -5,6 +5,7 @@ v-model="slide" :interval="interval" indicators + img-height="400px" @sliding-start="onSlideStart" @sliding-end="onSlideEnd" > From d31894faa24e2fce7a0c04ffacf8ceef66926201 Mon Sep 17 00:00:00 2001 From: CarliPinell Date: Mon, 4 Dec 2023 15:02:07 +0000 Subject: [PATCH 2/7] Solving SonarQube observation --- resources/js/processes-catalogue/components/ProcessTab.vue | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/resources/js/processes-catalogue/components/ProcessTab.vue b/resources/js/processes-catalogue/components/ProcessTab.vue index d21a9ba182..dd29388c7e 100644 --- a/resources/js/processes-catalogue/components/ProcessTab.vue +++ b/resources/js/processes-catalogue/components/ProcessTab.vue @@ -3,7 +3,7 @@
- +
{{ $t('You have made no requests of this process') }}
@@ -14,7 +14,7 @@
- +
{{ $t('You have no tasks from this process') }}
From 370a07f94b0531b30a946f7d780cf81976f7d189 Mon Sep 17 00:00:00 2001 From: CarliPinell Date: Tue, 5 Dec 2023 16:42:26 +0000 Subject: [PATCH 3/7] Observations solved --- .../components/DefaultTab.vue | 37 ++++++++++++ .../components/ProcessTab.vue | 60 +++++++++---------- 2 files changed, 64 insertions(+), 33 deletions(-) create mode 100644 resources/js/processes-catalogue/components/DefaultTab.vue diff --git a/resources/js/processes-catalogue/components/DefaultTab.vue b/resources/js/processes-catalogue/components/DefaultTab.vue new file mode 100644 index 0000000000..28f253d637 --- /dev/null +++ b/resources/js/processes-catalogue/components/DefaultTab.vue @@ -0,0 +1,37 @@ + + + diff --git a/resources/js/processes-catalogue/components/ProcessTab.vue b/resources/js/processes-catalogue/components/ProcessTab.vue index dd29388c7e..8661e12e5f 100644 --- a/resources/js/processes-catalogue/components/ProcessTab.vue +++ b/resources/js/processes-catalogue/components/ProcessTab.vue @@ -1,44 +1,38 @@ From 91419e545d536846961928cead3f4392e8ddcf44 Mon Sep 17 00:00:00 2001 From: CarliPinell Date: Tue, 5 Dec 2023 18:29:32 +0000 Subject: [PATCH 4/7] Solving observations about images --- resources/js/processes-catalogue/components/DefaultTab.vue | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/resources/js/processes-catalogue/components/DefaultTab.vue b/resources/js/processes-catalogue/components/DefaultTab.vue index 28f253d637..8b5c1d2bc5 100644 --- a/resources/js/processes-catalogue/components/DefaultTab.vue +++ b/resources/js/processes-catalogue/components/DefaultTab.vue @@ -18,7 +18,7 @@ export default { props: { imageSrc: { type: String, - default: "/img/launchpad-images/frame.png", + default: "/img/launchpad-images/tasks-loading.svg", }, altText: { type: String, From 30d158c59379c76b158904380feda56bdf7d7ae7 Mon Sep 17 00:00:00 2001 From: CarliPinell Date: Tue, 5 Dec 2023 18:31:13 +0000 Subject: [PATCH 5/7] Deleting frame.png --- resources/img/launchpad-images/frame.png | Bin 876 -> 0 bytes 1 file changed, 0 insertions(+), 0 deletions(-) delete mode 100644 resources/img/launchpad-images/frame.png diff --git a/resources/img/launchpad-images/frame.png b/resources/img/launchpad-images/frame.png deleted file mode 100644 index 2a85412a06d58d0fc8086905047d7d9b69d5159e..0000000000000000000000000000000000000000 GIT binary patch literal 0 HcmV?d00001 literal 876 zcmeAS@N?(olHy`uVBq!ia0vp^B|sd+!3HE-^FQzaDb50q$YKTtZeb8+WSBKa0w~B> z9OUlAuJ6f3E_MFTUW6EpE3O^`!m=4iu#t`*xj;!9`Y;hyt45|&91yMu6J%vXYO4) z<7b%3j^}mXn%J(ZdfYp^b2U>-SJR}x0Hfy$D|guNPnq7p9sIvtH^!!V*5vyKwzGYB zC~!~2gta`Z=`?T88Q=YT*-h$P`&UQi9Xi(ga!2^5XHo{XqPFXr)K0KQ>}`wKv0`=j z;^V;=SYl_||D9*~?R|8IoV#PO%jP?rOBSSvOliON6lj?nmzSI4NevB2R@KEoQ4>e? z+$DaF!cWZnj!Rxmci!Hlmb1PsLWW&>yM0}!oPV{B%A32(6SPnMEO7q5g0H_J{QcqB zphX%PT=%XWx|v#Ocq72}v3c+8(CxP#=Bcy0e^|Ca)AFBW+@x#O{BO$+i|(FO-&!Be z<>lnP6X=8SoH!eyHu;uj*}b z8ti3|g_2ndGjdrY;;d}fT=gq+{k`FiXVY@q^Ga{~R>?h+7XNg>`o*WDn&{|Fhiolx zHf2roR^!PkVKMLiryb(xnK8}#nDvY6ZWU(QYVVc=ej@>sJ7d@M`u_ETKLFr}r zfXY1YWzFszG!i4yS~4dYb|3U@WGgNCC~3I);bi-{;tibdj=SBvURQeejq{H`tk*xx WaGIj!JRO)h7(8A5T-G@yGywpr@`>#L From fb9e9f1c692ff35fa2b850a2b69b23ec321613f3 Mon Sep 17 00:00:00 2001 From: CarliPinell Date: Tue, 5 Dec 2023 18:35:58 +0000 Subject: [PATCH 6/7] Replacing frame.png for tasks-loading.svg --- resources/js/processes-catalogue/components/DefaultTab.vue | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/resources/js/processes-catalogue/components/DefaultTab.vue b/resources/js/processes-catalogue/components/DefaultTab.vue index 8b5c1d2bc5..a08d2e0451 100644 --- a/resources/js/processes-catalogue/components/DefaultTab.vue +++ b/resources/js/processes-catalogue/components/DefaultTab.vue @@ -18,7 +18,7 @@ export default { props: { imageSrc: { type: String, - default: "/img/launchpad-images/tasks-loading.svg", + default: "/img/tasks-loading.svg", }, altText: { type: String, From 0fcca223b250b4756e6dfc2b59904acf016e506b Mon Sep 17 00:00:00 2001 From: CarliPinell Date: Tue, 5 Dec 2023 19:48:24 +0000 Subject: [PATCH 7/7] Adding css style to tabs --- .../js/processes-catalogue/components/DefaultTab.vue | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/resources/js/processes-catalogue/components/DefaultTab.vue b/resources/js/processes-catalogue/components/DefaultTab.vue index a08d2e0451..eb054091d4 100644 --- a/resources/js/processes-catalogue/components/DefaultTab.vue +++ b/resources/js/processes-catalogue/components/DefaultTab.vue @@ -1,5 +1,5 @@