From f181e8d3e2460038a303c752c3b188ba13a41f2f Mon Sep 17 00:00:00 2001
From: Nolan Ehrstrom <github@nolanpro.com>
Date: Thu, 8 Feb 2024 19:41:26 -0800
Subject: [PATCH 1/4] Allow for empty PMQL in saved searches

---
 resources/js/requests/components/RequestsListing.vue | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/resources/js/requests/components/RequestsListing.vue b/resources/js/requests/components/RequestsListing.vue
index 0e7d0c7544..c4c14f244b 100644
--- a/resources/js/requests/components/RequestsListing.vue
+++ b/resources/js/requests/components/RequestsListing.vue
@@ -409,7 +409,7 @@ export default {
 
         if (filter && filter.length) {
           if (filter.isPMQL()) {
-            pmql = `(${pmql}) and (${filter})`;
+            pmql = (pmql ? `${pmql} and ` : '') + `(${filter})`;
             filter = '';
           }
         }

From 7ab87382555f0082550645c8c56fbcf4e23e05e2 Mon Sep 17 00:00:00 2001
From: Nolan Ehrstrom <github@nolanpro.com>
Date: Thu, 8 Feb 2024 19:41:40 -0800
Subject: [PATCH 2/4] Fix due date

---
 resources/js/tasks/components/TasksList.vue | 22 ++++++++++++---------
 1 file changed, 13 insertions(+), 9 deletions(-)

diff --git a/resources/js/tasks/components/TasksList.vue b/resources/js/tasks/components/TasksList.vue
index 6ddd97645e..8ed0487904 100644
--- a/resources/js/tasks/components/TasksList.vue
+++ b/resources/js/tasks/components/TasksList.vue
@@ -71,9 +71,9 @@
               <template v-else>
                 <template v-if="header.field === 'due_at'">
                   <span :class="['badge', 'badge-'+row['color_badge'], 'due-'+row['color_badge']]">
-                    {{ formatRemainingTime(getNestedPropertyValue(row, header)) }}
+                    {{ formatRemainingTime(row.due_at) }}
                   </span>
-                  <span>{{ row["due_date"] }}</span>
+                  <span>{{ getNestedPropertyValue(row, header) }}</span>
                 </template>
                 <template v-else>
                   <div
@@ -158,6 +158,7 @@ import TaskTooltip from "./TaskTooltip.vue";
 import PMColumnFilterIconAsc from "../../components/PMColumnFilterPopover/PMColumnFilterIconAsc.vue";
 import PMColumnFilterIconDesc from "../../components/PMColumnFilterPopover/PMColumnFilterIconDesc.vue";
 import FilterTableBodyMixin from "../../components/shared/FilterTableBodyMixin";
+import { get } from "lodash";
 
 const uniqIdsMixin = createUniqIdsMixin();
 
@@ -227,6 +228,13 @@ export default {
     };
   },
   computed: {
+    now() {
+      const tz = get(window, 'ProcessMaker.user.timezone');
+      if (tz) {
+        return moment().tz(tz);
+      }
+      return moment();
+    },
     endpoint() {
       if (this.savedSearch !== false) {
         return `saved-searches/${this.savedSearch}/results`;
@@ -249,7 +257,6 @@ export default {
           record["status"] = this.formatStatus(record);
           record["assignee"] = this.formatAvatar(record["user"]);
           record["request"] = this.formatRequest(record);
-          record["due_date"] = this.formatDueDate(record["due_at"]);
           record["color_badge"] = this.formatColorBadge(record["due_at"]);
           record["process"] = this.formatProcess(record);
           record["task_name"] = this.formatActiveTask(record);
@@ -438,14 +445,11 @@ export default {
       return `${daysRemaining}D`;
     },
     remainingTime(date) {
-      if (date === "-" || date === null) {
+      date = moment(date);
+      if (!date.isValid()) {
         return 0;
       }
-
-      const currentDate = new Date();
-      const formatDate = moment(date).format("YYYY-MM-DD");
-      const endDate = new Date(formatDate);
-      return endDate - currentDate;
+      return date.diff(this.now);
     },
     formatProcess(request) {
       return request.process.name;

From 3d6a32f6e24db43a639278b027cdc27e9b389c1c Mon Sep 17 00:00:00 2001
From: Nolan Ehrstrom <github@nolanpro.com>
Date: Thu, 8 Feb 2024 20:18:29 -0800
Subject: [PATCH 3/4] Refactor for sonar qube

---
 .../requests/components/RequestsListing.vue   | 58 ++++++++++---------
 1 file changed, 32 insertions(+), 26 deletions(-)

diff --git a/resources/js/requests/components/RequestsListing.vue b/resources/js/requests/components/RequestsListing.vue
index c4c14f244b..418c8b5351 100644
--- a/resources/js/requests/components/RequestsListing.vue
+++ b/resources/js/requests/components/RequestsListing.vue
@@ -399,32 +399,7 @@ export default {
 
         const CancelToken = ProcessMaker.apiClient.CancelToken;
 
-        let pmql = '';
-
-        if (this.pmql !== undefined) {
-          pmql = this.pmql;
-        }
-
-        let filter = this.filter;
-
-        if (filter && filter.length) {
-          if (filter.isPMQL()) {
-            pmql = (pmql ? `${pmql} and ` : '') + `(${filter})`;
-            filter = '';
-          }
-        }
-
-        if (this.previousFilter !== filter) {
-          this.page = 1;
-        }
-
-        this.previousFilter = filter;
-
-        if (this.previousPmql !== pmql) {
-          this.page = 1;
-        }
-
-        this.previousPmql = pmql;
+        const { pmql, filter } = this.buildPmqlAndFilter();
 
         // Load from our api client
         ProcessMaker.apiClient
@@ -467,6 +442,37 @@ export default {
           });
       });
     },
+    buildPmqlAndFilter() {
+      let pmql = '';
+
+      if (this.pmql !== undefined) {
+        pmql = this.pmql;
+      }
+
+      let filter = this.filter;
+
+      if (filter && filter.length) {
+        if (filter.isPMQL()) {
+          pmql = (pmql ? `${pmql} and ` : '') + `(${filter})`;
+          filter = '';
+        }
+      }
+
+      if (this.previousFilter !== filter) {
+        this.page = 1;
+      }
+
+      this.previousFilter = filter;
+
+      if (this.previousPmql !== pmql) {
+        this.page = 1;
+      }
+
+      this.previousPmql = pmql;
+
+      return { pmql, filter };
+
+    },
     handleRowClick(row) {
       window.location.href = this.openRequest(row, 1);
     },

From c3ea012de270747cea06b624a62f1f45f5d9630d Mon Sep 17 00:00:00 2001
From: Nolan Ehrstrom <github@nolanpro.com>
Date: Thu, 8 Feb 2024 20:47:35 -0800
Subject: [PATCH 4/4] Sonar qube

---
 resources/js/requests/components/RequestsListing.vue | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/resources/js/requests/components/RequestsListing.vue b/resources/js/requests/components/RequestsListing.vue
index 418c8b5351..6cedd7dbda 100644
--- a/resources/js/requests/components/RequestsListing.vue
+++ b/resources/js/requests/components/RequestsListing.vue
@@ -451,7 +451,7 @@ export default {
 
       let filter = this.filter;
 
-      if (filter && filter.length) {
+      if (filter?.length) {
         if (filter.isPMQL()) {
           pmql = (pmql ? `${pmql} and ` : '') + `(${filter})`;
           filter = '';