From d1605dbf098a8f2fe04d06c460b6c5dd6188fca0 Mon Sep 17 00:00:00 2001 From: Sanja Date: Tue, 13 Feb 2024 11:03:20 -0800 Subject: [PATCH 1/2] Update testNoMatchingUser to assert admin user is set --- tests/Feature/ImportExport/Exporters/ScriptExporterTest.php | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tests/Feature/ImportExport/Exporters/ScriptExporterTest.php b/tests/Feature/ImportExport/Exporters/ScriptExporterTest.php index b78922e4d4..c607a1a96e 100644 --- a/tests/Feature/ImportExport/Exporters/ScriptExporterTest.php +++ b/tests/Feature/ImportExport/Exporters/ScriptExporterTest.php @@ -114,6 +114,7 @@ public function testHiddenUsesParentMode() public function testNoMatchingRunAsUser() { + $admin_user = User::factory()->create(['is_administrator' => true]); DB::beginTransaction(); $user = User::factory()->create(['username' => 'test']); $script = Script::factory()->create(['title' => 'test', 'run_as_user_id' => $user->id]); @@ -124,7 +125,7 @@ public function testNoMatchingRunAsUser() $this->import($payload); $script = Script::where('title', 'test')->firstOrFail(); - $this->assertNull($script->run_as_user_id); + $this->assertEquals($script->run_as_user_id, $admin_user->id); } public function testRunAsUserIdNull() From 5d63f593e7d3fd3567a19c738f1738a44c695bda Mon Sep 17 00:00:00 2001 From: Sanja Date: Tue, 13 Feb 2024 11:16:24 -0800 Subject: [PATCH 2/2] delete test admin user --- tests/Feature/ImportExport/Exporters/ScriptExporterTest.php | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/Feature/ImportExport/Exporters/ScriptExporterTest.php b/tests/Feature/ImportExport/Exporters/ScriptExporterTest.php index c607a1a96e..d692a300fd 100644 --- a/tests/Feature/ImportExport/Exporters/ScriptExporterTest.php +++ b/tests/Feature/ImportExport/Exporters/ScriptExporterTest.php @@ -126,6 +126,7 @@ public function testNoMatchingRunAsUser() $script = Script::where('title', 'test')->firstOrFail(); $this->assertEquals($script->run_as_user_id, $admin_user->id); + $admin_user->delete(); } public function testRunAsUserIdNull()