From 01dd406323ac5db5e20497a4d1c1417620087c09 Mon Sep 17 00:00:00 2001 From: Nolan Ehrstrom Date: Fri, 27 Sep 2024 13:26:44 -0700 Subject: [PATCH] Fix call to missing method --- ProcessMaker/Models/Process.php | 2 +- .../unit/ProcessMaker/Models/ProcessTest.php | 33 +++++++++++++++++++ 2 files changed, 34 insertions(+), 1 deletion(-) create mode 100644 tests/unit/ProcessMaker/Models/ProcessTest.php diff --git a/ProcessMaker/Models/Process.php b/ProcessMaker/Models/Process.php index 34f1fb6b81..5890d05815 100644 --- a/ProcessMaker/Models/Process.php +++ b/ProcessMaker/Models/Process.php @@ -1077,7 +1077,7 @@ public function getConsolidatedUsers($groupOrGroups, array &$users) ->where('groups.status', 'ACTIVE') ->chunk(1000, function ($members) use (&$users) { $groupIds = $members->pluck('member_id')->toArray(); - $users = $this->addActiveAssignedGroupMembers($groupIds, $users); + $users = $this->getConsolidatedUsers($groupIds, $users); }); return $users; diff --git a/tests/unit/ProcessMaker/Models/ProcessTest.php b/tests/unit/ProcessMaker/Models/ProcessTest.php new file mode 100644 index 0000000000..e74cec820c --- /dev/null +++ b/tests/unit/ProcessMaker/Models/ProcessTest.php @@ -0,0 +1,33 @@ +create(); + + $groupA = Group::factory()->create(['name' => 'Group A', 'status' => 'ACTIVE']); + $groupB = Group::factory()->create(['name' => 'Group B', 'status' => 'ACTIVE']); + + $groupAUser = User::factory()->create(['status' => 'ACTIVE']); + $groupBUser = User::factory()->create(['status' => 'ACTIVE']); + + $groupA->groupMembers()->create(['member_id' => $groupAUser->id, 'member_type' => User::class]); + $groupB->groupMembers()->create(['member_id' => $groupBUser->id, 'member_type' => User::class]); + + // Add group B to group A + $groupA->groupMembers()->create(['member_id' => $groupB->id, 'member_type' => Group::class]); + + $users = []; + $process->getConsolidatedUsers($groupA->id, $users); + + $this->assertEquals([$groupAUser->id, $groupBUser->id], $users); + } +}