From 32250ef01344130e8630ab77b4985ccb383d5903 Mon Sep 17 00:00:00 2001 From: Agustin Busso <90727999+agustinbusso@users.noreply.github.com> Date: Tue, 12 Oct 2021 14:57:49 -0300 Subject: [PATCH 1/3] Added validation for undefined id's before send a request --- src/DataProvider.js | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/src/DataProvider.js b/src/DataProvider.js index 00cbf2732..78d264fba 100644 --- a/src/DataProvider.js +++ b/src/DataProvider.js @@ -51,9 +51,9 @@ export default { baseURL() { return localStorage.getItem('baseURL'); }, - + // Methods below are used in the components - + getTasks(params) { const endpoint = _.get(window, 'PM4ConfigOverrides.getTasksEndpoint', '/tasks'); return this.get(endpoint + params).then(response => { @@ -83,7 +83,8 @@ export default { const cache = this.screensCache.find(screen => screen.id == id); if (cache) { resolve({data: cache}); - } else { + } + if (!cache && id != undefined) { const request = this.get(endpoint + `/${id}${query}`); request.then(response => { if (response.data.nested) { @@ -94,7 +95,7 @@ export default { } }); }, - + postScript(id, params) { let endpoint = _.get( window, From 619a0f8c730b31aa0e49f001c96a6e9186ad97fd Mon Sep 17 00:00:00 2001 From: Agustin Busso <90727999+agustinbusso@users.noreply.github.com> Date: Tue, 12 Oct 2021 15:16:51 -0300 Subject: [PATCH 2/3] Revert "Added validation for undefined id's before send a request" This reverts commit 32250ef01344130e8630ab77b4985ccb383d5903. --- src/DataProvider.js | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/src/DataProvider.js b/src/DataProvider.js index 78d264fba..00cbf2732 100644 --- a/src/DataProvider.js +++ b/src/DataProvider.js @@ -51,9 +51,9 @@ export default { baseURL() { return localStorage.getItem('baseURL'); }, - + // Methods below are used in the components - + getTasks(params) { const endpoint = _.get(window, 'PM4ConfigOverrides.getTasksEndpoint', '/tasks'); return this.get(endpoint + params).then(response => { @@ -83,8 +83,7 @@ export default { const cache = this.screensCache.find(screen => screen.id == id); if (cache) { resolve({data: cache}); - } - if (!cache && id != undefined) { + } else { const request = this.get(endpoint + `/${id}${query}`); request.then(response => { if (response.data.nested) { @@ -95,7 +94,7 @@ export default { } }); }, - + postScript(id, params) { let endpoint = _.get( window, From 5ec72c26418869957777337b9879403c9fef209b Mon Sep 17 00:00:00 2001 From: Agustin Busso <90727999+agustinbusso@users.noreply.github.com> Date: Tue, 12 Oct 2021 15:27:46 -0300 Subject: [PATCH 3/3] Added validation for undefined id before send a request --- src/DataProvider.js | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/src/DataProvider.js b/src/DataProvider.js index 00cbf2732..78d264fba 100644 --- a/src/DataProvider.js +++ b/src/DataProvider.js @@ -51,9 +51,9 @@ export default { baseURL() { return localStorage.getItem('baseURL'); }, - + // Methods below are used in the components - + getTasks(params) { const endpoint = _.get(window, 'PM4ConfigOverrides.getTasksEndpoint', '/tasks'); return this.get(endpoint + params).then(response => { @@ -83,7 +83,8 @@ export default { const cache = this.screensCache.find(screen => screen.id == id); if (cache) { resolve({data: cache}); - } else { + } + if (!cache && id != undefined) { const request = this.get(endpoint + `/${id}${query}`); request.then(response => { if (response.data.nested) { @@ -94,7 +95,7 @@ export default { } }); }, - + postScript(id, params) { let endpoint = _.get( window,